TrigHTTBankGen: clang-tidy , cppcheck unint member variables

Trigger/EFTracking/EFTrackingSim/TrigHTTAlgorithms/src/HTTOverlapRemovalTool.h

@@ -68,7 +68,7 @@ private:
   Gaudi::Property <std::string> m_algorithm { this, "ORAlgo", "Normal", "Overlap removal algorithm"};
   Gaudi::Property <bool> m_doFastOR { this, "doFastOR", false, "Use fast overlap removal algorithm instead of default"};
 
-  int m_totLayers;                 //  Total number of layers used for a track
+  int m_totLayers = 0;                 //  Total number of layers used for a track
   ORAlgo m_algo;                    //  Internal ORAlgo enum for faster compare
 
 

Trigger/EFTracking/EFTrackingSim/TrigHTTBankGen/src/HTTConstGenAlgo.h

@@ -98,7 +98,7 @@ class HTTConstGenAlgo : public AthAlgorithm
         ServiceHandle<ITrigHTTMappingSvc> m_HTTMapping{this, "TrigHTTMappingSvc","TrigHTTMappingSvc"};
         ServiceHandle<ITHistSvc> m_tHistSvc{this, "THistSvc","THistSvc"};
 
-        const HTTPlaneMap* m_pmap;
+        const HTTPlaneMap* m_pmap = nullptr;
 
 
 	
@@ -116,16 +116,16 @@ class HTTConstGenAlgo : public AthAlgorithm
         ///////////////////////////////////////////////////////////////////////
         // ROOT Objects
 
-        TFile *m_mafile;
-        TTree *m_ctree;
-        TTree *m_matrix_tree;
-        TTree *m_good_tree;
+        TFile *m_mafile = nullptr;
+        TTree *m_ctree = nullptr;
+        TTree *m_matrix_tree = nullptr;
+        TTree *m_good_tree = nullptr;
 
-        TH1F *m_h_vc;
-        TH1F *m_h_vd;
-        TH1F *m_h_vf;
-        TH1F *m_h_vz;
-        TH1F *m_h_veta;
+        TH1F *m_h_vc = nullptr;
+        TH1F *m_h_vd = nullptr;
+        TH1F *m_h_vf = nullptr;
+        TH1F *m_h_vz = nullptr;
+        TH1F *m_h_veta = nullptr;
 
         ///////////////////////////////////////////////////////////////////////
         // Slice Info
@@ -137,11 +137,11 @@ class HTTConstGenAlgo : public AthAlgorithm
         ///////////////////////////////////////////////////////////////////////
         // Sizes
 
-        int m_nLayers;
-        int m_nKernel;
-        int m_nKAverages;
-        int m_nCoords;
-        int m_nCoords_2; // m_nCoords^2
+        int m_nLayers = 0;
+        int m_nKernel = 0;
+        int m_nKAverages = 0;
+        int m_nCoords = 0;
+        int m_nCoords_2 = 0; // m_nCoords^2
 
 
         ///////////////////////////////////////////////////////////////////////

Trigger/EFTracking/EFTrackingSim/TrigHTTBankGen/src/HTTMatrixGenAlgo.h

@@ -115,7 +115,7 @@ class HTTMatrixGenAlgo : public AthAlgorithm
         HTTTrackPars m_sliceMax = 0;
         HTTTrackParsI m_nBins;
 
-        HTTEventInputHeader*         m_eventHeader;
+        HTTEventInputHeader*         m_eventHeader = nullptr;
 
         ///////////////////////////////////////////////////////////////////////
         // Meta Data
@@ -150,9 +150,9 @@ class HTTMatrixGenAlgo : public AthAlgorithm
         TH1I* m_h_3hitsInLayer[HTTTrackPars::NPARS];
         TH1I* m_h_notEnoughHits[HTTTrackPars::NPARS];
 
-        TH1I* m_h_trackQoP_okHits;
-        TH1I* m_h_trackQoP_okRegion;
-        TH1I* m_h_nHit;
+        TH1I* m_h_trackQoP_okHits = nullptr;
+        TH1I* m_h_trackQoP_okRegion = nullptr;
+        TH1I* m_h_nHit = nullptr;
 };
 
 #endif // HTTMatrixGenAlgo_h

Trigger/EFTracking/EFTrackingSim/TrigHTTBankGen/src/HTTMatrixIO.h

@@ -100,7 +100,7 @@ class HTTMatrixWriter
         int m_nLayers;
         int m_nCoords;
         int m_nCoords2;
-        float m_coverage;
+        float m_coverage = 0.0F;
 
         std::vector<short> m_bins_QoP;
         std::vector<short> m_bins_phi;

Trigger/EFTracking/EFTrackingSim/TrigHTTBankGen/src/HTTMatrixMergeAlgo.h

@@ -64,25 +64,25 @@ class HTTMatrixMergeAlgo : public AthAlgorithm
 	Gaudi::Property<bool> m_Monitor {this, "Monitor", false, "flag to enable the monitor"};
 
 
-        int m_region_start;
-        int m_region_end;
+        int m_region_start = 0;
+        int m_region_end = 0;
 
         int m_nFiles = 0;
         int m_nLayers = 0;
-        int m_nDim;
-        int m_nDim2;
+        int m_nDim = 0;
+        int m_nDim2 = 0;
 
         ///////////////////////////////////////////////////////////////////////
         // Meta Data
 
         // Histograms
-        TH1I* m_h_nSector;
-        TH1I* m_h_nHit;
-        TH1F* m_h_c;
-        TH1F* m_h_d;
-        TH1F* m_h_phi;
-        TH1F* m_h_coto;
-        TH1F* m_h_z;
+        TH1I* m_h_nSector = nullptr;
+        TH1I* m_h_nHit = nullptr;
+        TH1F* m_h_c = nullptr;
+        TH1F* m_h_d = nullptr;
+        TH1F* m_h_phi = nullptr;
+        TH1F* m_h_coto = nullptr;
+        TH1F* m_h_z = nullptr;
 
         ///////////////////////////////////////////////////////////////////////
         // Helper Functions

Trigger/EFTracking/EFTrackingSim/TrigHTTBankGen/src/HTTMatrixReductionAlgo.h

@@ -50,8 +50,8 @@ class HTTMatrixReductionAlgo: public AthAlgorithm
 
         ServiceHandle<ITrigHTTMappingSvc> m_HTTMapping {this, "TrigHTTMappingSvc","TrigHTTMappingSvc"};
         ServiceHandle<ITHistSvc> m_tHistSvc {this, "THistSvc","THistSvc"};
-        HTTPlaneMap const * m_pmap_1st;
-        HTTPlaneMap const * m_pmap_2nd;
+        HTTPlaneMap const * m_pmap_1st = nullptr;
+        HTTPlaneMap const * m_pmap_2nd = nullptr;
 
         ///////////////////////////////////////////////////////////////////////
         // Configuration
@@ -60,8 +60,8 @@ class HTTMatrixReductionAlgo: public AthAlgorithm
 	Gaudi::Property<int> m_region {this, "region", 0, "Region to run"};
 	Gaudi::Property<int> m_nRegions {this, "nbank", 96, "Number of regions and thus banks to create"};
 
-        int m_region_start;
-        int m_region_end;
+        int m_region_start = 0;
+        int m_region_end = 0;
 
         ///////////////////////////////////////////////////////////////////////
         // Data