Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ATLAS-EGammaATLAS-EGamma
  • athenaathena
  • Merge requests
  • !4

MaterialEffectsBase simplify . Second attempt

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Christos Anastopoulos requested to merge MaterialEffectsBase_moveToHolder_simplify into master Jun 11, 2021
  • Overview 0
  • Commits 6
  • Changes 11

Trying to simplify the MaterialEffectBase.

One of the issues that came up is the MaterialEffectBase has a "policy" to clone/delete Surfaces not based on if the Surfaces are "free" but on if there is an associated detector element.

For now try to also handle this case from the "Holder". When we will have all the case perhaps we should try and factorize things a bit better

Mentioning @sroe

Edited Jun 11, 2021 by Christos Anastopoulos
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: MaterialEffectsBase_moveToHolder_simplify