lhc-sm-api issueshttps://gitlab.cern.ch/LHCData/lhc-sm-api/-/issues2021-03-08T16:19:47+01:00https://gitlab.cern.ch/LHCData/lhc-sm-api/-/issues/1Follow-up from "Sigmon 60 multi signal nxcals" review the refactoring of dict...2021-03-08T16:19:47+01:00Thibaud Marie Eric Buffetthibaud.buffet@cern.chFollow-up from "Sigmon 60 multi signal nxcals" review the refactoring of dictionnaries to domain objects.The following discussion from !32 should be addressed:
- [ ] @garnierj started a [discussion](https://gitlab.cern.ch/LHCData/lhc-sm-api/-/merge_requests/32#note_4268050): (+1 comment)
> maybe I missed it .. but why relying on a Di...The following discussion from !32 should be addressed:
- [ ] @garnierj started a [discussion](https://gitlab.cern.ch/LHCData/lhc-sm-api/-/merge_requests/32#note_4268050): (+1 comment)
> maybe I missed it .. but why relying on a Dict[str, int] for these 2 timestamps?
>
> I see that everywhere `t_start` and `t_end` are hardcoded.
>
> If the use of a dictionary is necessary, introduce a constant, particularly because countless variables are named `t_start` and `t_end` as well.
> If the use of a dictionary is not necessary, introduce an object.