Skip to content

GitLab

Open
Created by Thibaud Marie Eric Buffet@thbuffetMaintainer0 of 1 task completed0/1 task

Follow-up from "Sigmon 60 multi signal nxcals" review the refactoring of dictionnaries to domain objects.

The following discussion from !32 (merged) should be addressed:

  • @garnierj started a discussion: (+1 comment)

    maybe I missed it .. but why relying on a Dict[str, int] for these 2 timestamps?

    I see that everywhere t_start and t_end are hardcoded.

    If the use of a dictionary is necessary, introduce a constant, particularly because countless variables are named t_start and t_end as well. If the use of a dictionary is not necessary, introduce an object.