[SIGMON-222] Support many EE references
Context
- ticket: https://its.cern.ch/jira/browse/SIGMON-222
-
lhc-sm-hwcMR: lhc-sm-hwc!60 (merged)
What was done
- Support for many reference EE events added (in the same way as it was already done for the discharges)
-
Referenceclass removed, all the methods moved tolhcsmapi.reference.pyandlhcsmapi.analysis.comparison - CSVs with the reference data moved to
lhcsmapi.resources.reference -
pkgutilused to read the CSVs (instead of joining the paths) - small refactoring of the
references methods and tests - 2 new methods added to
PcQuery(get_fgc_timestamp_refandget_ee_timestamp_ref) replacingget_timestamp_ref(csv_column_name)
TODO
- ?
QA
- code was unit tested
- notebooks were checked
Review objectives
- assessment of code functionality
- assessment of code quality
- identifying potential refactorings / logic common to other projects
- knowledge sharing
Edited by Aleksandra Mnich