Skip to content

fixing fakes normalization and histogram dimension checking

Yuzhan Zhao requested to merge scipp/collinear-w/RooUnfold:bug_fixed/dimension_normalizaion into master

Fakes normalization:

  • In the RooUnfoldBayes method, the fakes were not normalized: since the line this->_Nji = this->_res->Mresponse(true); returns a normalized _Nji, the fakes should be assigned with this->_Nji(i,this->_nc-1)= fakes[i]/nfakes;

Dimension/bin counting in RooUnfoldResponse:

  • the internal TH1 creation double counted the number of bins.
  • Dimension check for _res needs to use the _overflow flag to properly compare with the 1D measure and truth.
Edited by Yuzhan Zhao

Merge request reports