From 0abc0fbeb7b19234e5284021be24de03da374ce5 Mon Sep 17 00:00:00 2001
From: Xiaocong Ai <xiaocong.ai@cern.ch>
Date: Thu, 19 Mar 2020 14:08:01 -0700
Subject: [PATCH] Revise the KF error message
---
Core/include/Acts/Fitter/KalmanFitter.hpp | 3 ++-
Core/include/Acts/Fitter/KalmanFitterError.hpp | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Core/include/Acts/Fitter/KalmanFitter.hpp b/Core/include/Acts/Fitter/KalmanFitter.hpp
index 8ecc7471b..a55fac024 100644
--- a/Core/include/Acts/Fitter/KalmanFitter.hpp
+++ b/Core/include/Acts/Fitter/KalmanFitter.hpp
@@ -546,6 +546,8 @@ class KalmanFitter {
// We count the processed state
++result.processedStates;
} else if (surface->surfaceMaterial() != nullptr) {
+ // We only create track states here if there is already measurement
+ // detected
if (result.measurementStates > 0) {
// No source links on surface, add either hole or passive material
// TrackState entry multi trajectory. No storage allocation for
@@ -991,7 +993,6 @@ class KalmanFitter {
/// It could happen that the fit ends in zero processed states.
/// The result gets meaningless so such case is regarded as fit failure.
- //@TODO: should we require the number of measurments >0 ?
if (kalmanResult.result.ok() and not kalmanResult.processedStates) {
kalmanResult.result = Result<void>(KalmanFitterError::PropagationInVain);
}
diff --git a/Core/include/Acts/Fitter/KalmanFitterError.hpp b/Core/include/Acts/Fitter/KalmanFitterError.hpp
index 78d599ff0..b7f9ad7a9 100644
--- a/Core/include/Acts/Fitter/KalmanFitterError.hpp
+++ b/Core/include/Acts/Fitter/KalmanFitterError.hpp
@@ -40,7 +40,7 @@ class KalmanFitterErrorCategory : public std::error_category {
case KalmanFitterError::OutputConversionFailed:
return "Kalman output conversion failed";
case KalmanFitterError::PropagationInVain:
- return "No detector observed during the propagation";
+ return "No measurement detected during the propagation";
default:
return "unknown";
}
--
GitLab