Skip to content

Set minimum Boost version to 1.59 (was ACTS-107)

Original author Stewart Martin-Haugh @smh

Hi, I don't have much time yet to get involved but wanted to try it out. As a minimal improvement, I noticed that boost 1.59 is the minimum in the readme, but this is not enforced by cmake.

Patch: {noformat} diff --git a/Tests/EventData/CMakeLists.txt b/Tests/EventData/CMakeLists.txt index 09b029c..f9f14e3 100644 --- a/Tests/EventData/CMakeLists.txt +++ b/Tests/EventData/CMakeLists.txt @@ -3,7 +3,7 @@ option (BUILD_TESTS "build unit tests" ON)

if (BUILD_TESTS) # we need boost

  • find_package (Boost REQUIRED)
  • find_package (Boost 1.59 REQUIRED)

    if (Boost_FOUND) add_executable (ParameterSetTest ParameterSetTests.cpp) {noformat}

What do I do now? Make a fork and then merge request?

Cheers, Stewart

Edited by Moritz Kiehn
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information