Bugs in CylinderVolumeBuilder (was ACTS-293)

Original author Julia Hrdinka @jhrdinka

In the CylinderVolumeBuilder in the overlapsInZ() function only two cases of overlapping are covered (https://gitlab.cern.ch/acts/a-common-tracking-sw/blob/master/Core/include/ACTS/Tools/CylinderVolumeBuilder.hpp#L93). A more general comparison should be introduced, which checks if two intervals are overlapping. This more general comparison can also be used for overlapsInR(). In the containesInR() function matching radii should also be allowed and '>' should be changed into '>=' .

Edited Mar 27, 2019 by Moritz Kiehn

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information