Skip to content

PlaneLayerTests call SurfaceArrayCreator::surfaceArrayOnPlane wrong

The PlaneLayerTests rely on the default value of the bValue parameter to SurfaceArrayCreator::surfaceArrayOnPlane, binX, which isn't right for that test as its surfaces are actually aligned on the Z axis.

This could be considered a usability defect of the surfaceArrayOnPlane API, however, as binX is a weird default (since surfaces are in the XY plane unless transformed, binZ would make more sense). Futher, it is questionable whether the bValue parameter should have a default value at all, given that the right default depends on the input surfaces.

If the bValue default of surfaceArrayOnPlane is changed/removed, then the one of dependent APIs such as LayerCreator::planeLayer should be changed as well for consistency.

More context on Mattermost

Edited by Hadrien Benjamin Grasland
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information