Skip to content

Duplication in CylinderVolumeBuilder::Config (was ACTS-82)

Original author Christian Gumpert @cgumpert

There seems to be a duplication for the material information in CylinderVolumeBuilder::Config. As far as I can tell, the {{volumeMaterialProperties}} are never used. I think we have two options:

  1. keep the {{volumeMaterialsProperties}} and create the {{volumeMaterial}} object on the fly
  2. require a valid {{volumeMaterial}} object and remove the {{volumeMaterialProperties}} completely.

I would be in favor of option 2) as it creates less code (no check for on-the-fly creation of {{volumeMaterial}}).

Another related question: Don't we want to share {{Material}} objects between surfaces with the same material? Don't we need to use {{shared_ptr}} in this case?

Edited by Moritz Kiehn
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information