Increase the borders of the line bound
All threads resolved!
All threads resolved!
The bounds [0, r] are too small, as the local coordinate eLOC_R also has a sign (could be -r). So I set them to [-r, r].
The sign convention can be found in e.g. LineSurface::globalToLocal.
Edited by Paul Gessinger-Befurt
Merge request reports
Activity
- Resolved by Paul Gessinger-Befurt
added 799 commits
-
6d254582...08180b80 - 795 commits from branch
acts:master
- b70ef89a - Increase the borders of the line bound
- 9dd42359 - update format
- a1260ecd - remove expected failure from linebounds test
- 389f76fe - Add tests for new line bounds behaviour
Toggle commit list-
6d254582...08180b80 - 795 commits from branch
I rebased manually, and added a test for the new behaviour.
@asalzbur Can you maybe hit the button?
added 7 commits
-
389f76fe...b0eac0ae - 3 commits from branch
acts:master
- 6b887146 - Increase the borders of the line bound
- 822be161 - update format
- 51123f94 - remove expected failure from linebounds test
- 981f17a5 - Add tests for new line bounds behaviour
Toggle commit list-
389f76fe...b0eac0ae - 3 commits from branch
changed milestone to %0.10.02
added Bug label
changed milestone to %0.12.00
assigned to @rlangenb
added 40 commits
-
981f17a5...5024f5a7 - 36 commits from branch
acts:master
- 413807b0 - Increase the borders of the line bound
- 759c8024 - update format
- 34ddb28d - remove expected failure from linebounds test
- 8b15ccad - Add tests for new line bounds behaviour
Toggle commit list-
981f17a5...5024f5a7 - 36 commits from branch
Had to rebase locally. Can you reapprove @rlangenb?
mentioned in commit 5848dca3
changed milestone to %0.10.04
mentioned in merge request atlas/atlasexternals!547 (merged)
mentioned in merge request atlas/athena!26660 (merged)
Please register or sign in to reply