Skip to content
Snippets Groups Projects

Increase the borders of the line bound

Merged Nils Braun requested to merge nibraun/acts-core:bugfix/line-bounds-radius into master
All threads resolved!

The bounds [0, r] are too small, as the local coordinate eLOC_R also has a sign (could be -r). So I set them to [-r, r].

The sign convention can be found in e.g. LineSurface::globalToLocal.

Edited by Paul Gessinger-Befurt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 799 commits

    Compare with previous version

  • Paul Gessinger-Befurt resolved all discussions

    resolved all discussions

  • I rebased manually, and added a test for the new behaviour.

    @asalzbur Can you maybe hit the button?

  • added 7 commits

    Compare with previous version

  • changed milestone to %0.10.02

  • added Bug label

  • Paul Gessinger-Befurt changed the description

    changed the description

  • changed milestone to %0.12.00

  • assigned to @rlangenb

  • Robert Johannes Langenberg approved this merge request

    approved this merge request

  • added 40 commits

    Compare with previous version

  • Had to rebase locally. Can you reapprove @rlangenb?

  • Robert Johannes Langenberg approved this merge request

    approved this merge request

  • mentioned in commit 5848dca3

  • changed milestone to %0.10.04

  • mentioned in merge request atlas/athena!26660 (merged)

  • Please register or sign in to reply
    Loading