Skip to content
Snippets Groups Projects

Add Bounding Volume Hierarchy capabilities for Navigation

Merged Paul Gessinger requested to merge pagessin/acts-core:ray-rebased into master

This MR adds navigation capabilities using BVH. TrackingVolume can now be created with a contained BVH. It owns the bounding box and has a pointer to the hierarchy structure. The TrackingVolume can then be queried for intersecting contained surfaces by giving a position, direction and opening angle. It then internally uses a ray or a frustum to do the intersect search. The navigator learns how to deal with these TrackingVolumes. Currently, it will only use rays (leading to bad behavior in case of low-momentum/high-bfield). A basic estimation of the required opening angle for a given momentum and b field is included but commented out. This scenario will be addressed in the future, because the navigator will have to handle potentially required re-navigation, when a particle is deflected out of the initial frustum.

Closes #486 (closed)

Edited by Paul Gessinger

Merge request reports

Pipeline #885695 passed

Pipeline passed for beb3f3f9 on pagessin:ray-rebased

Test coverage 71.00% (1.00%) from 1 job

Merged by Paul GessingerPaul Gessinger 5 years ago (May 28, 2019 3:01pm UTC)

Loading

Pipeline #885921 passed

Pipeline: acts-documentation

#886100

    Pipeline passed for fa8a4e03 on master

    Test coverage 71.00% (1.00%) from 1 job

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Paul Gessinger added 1 commit

    added 1 commit

    • 778682bb - hasBVH -> hasBoundingVolumeHierarchy

    Compare with previous version

  • Paul Gessinger resolved all discussions

    resolved all discussions

  • Paul Gessinger changed title from Add BVH capabilities for Navigation to Add Bounding Volume Hierarchy capabilities for Navigation

    changed title from Add BVH capabilities for Navigation to Add Bounding Volume Hierarchy capabilities for Navigation

  • Paul Gessinger added 11 commits

    added 11 commits

    • 778682bb...317c5ae8 - 6 commits from branch acts:master
    • 4f8a4095 - Add navigation facilities for BVH
    • 655c7617 - Add min/max methods to ConstrainedStep
    • 7866c27b - TrkVol: Move definition of methods to ipp
    • 89a947ea - Remove default argument in ipp
    • af9b5bc8 - hasBVH -> hasBoundingVolumeHierarchy

    Compare with previous version

  • Robert Johannes Langenberg approved this merge request

    approved this merge request

  • Paul Gessinger added 1 commit

    added 1 commit

    • 513ee5b4 - Put BVH data test case into external file

    Compare with previous version

  • Robert Johannes Langenberg approved this merge request

    approved this merge request

  • I added a TrackingVolumeTest which essentially runs the same test as BVHNavigationTest did and still does. The actual test case is now in a separate file, and the box count and iteration count is steered in a macro. Essentially, now the "integration test" is a longer running version of the "unit test". I added this because the "integration test" is not counted in the coverage, this way it is.

  • Paul Gessinger added 1 commit

    added 1 commit

    Compare with previous version

  • Paul Gessinger resolved all discussions

    resolved all discussions

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading