Deprecation of getROOTDirectory
During a discussion with our GSoC student Viktor the question arose whether this getROOTDirectory deprecation could be removed:
// Change to ROOT directory is not thread safe, only do this for module without parallelization support
if(!module->canParallelize()) {
// DEPRECATED: Switching to the directory should be removed, but can break current modules
module->getROOTDirectory()->cd();
}
When exactly is this still necessary? Because if we run with experimental_multithreading = true
we also don't do this call. Does ROOT internally handle this as soon as we do what is in the Allpix base class:
// Enable relevant multithreading if needed (disabled by default)
if(global_config.get<bool>("experimental_multithreading", false)) {
// Enable thread safety for ROOT
ROOT::EnableThreadSafety();
}
Would it hurt to always enable ROOT's thread safety features and remove above deprecated code?