Skip to content

Redefine Position of PixelCenter

Simon Spannagel requested to merge pixelcenter into master

Currently, DetectorModel::getPixelCenter() returns a position at the sensor surface. I would argue that in most calculations done with this position, the reference plane of the sensor (i.e. z = 0) does make more sense.

Hence here the suggestion to change it.

Impact on framework:

  • getWeightingPotential calls DetectotField::getRelativeTo() which ignores the ref.z() position, no impact.
  • DetectorHistogrammer only uses x() and y(), no impact.
  • Detector::getPixel() now produces pixels with their position at the sensor center plane - which makes more sense to me.

Merge request reports