Skip to content

Module Output Files: Allow Absolute Paths and Subdirectories

Simon Spannagel requested to merge file_access into master

Currently, the path to module output files created via Module::createOutputFile() is assembled crudely as string. This leads to

  • invalid paths in case the input is an absolute path (/tmp/test.root)
  • errors in case the input is a relative path but contains subdirectories (tmp/test.root)
  • odd errors if the target is an existing directory

This MR

  • uses std::filesystem::path and its nice tools to assemble correct paths
  • now allows for absolute output paths but prints a warning if they are used
  • returns a sensible error in case the target is a directory

Merge request reports