Skip to content

Paths in SFramework config files are (still) not resolved using the TQPathManager

While a past MR !309 (merged) has already tackled the handling of file outputs by the TSStatisticsManager itself, this does not include all output files produced by SFramework yet...

Here's a preliminary list of all the places (compiled with grep):

ActionBatchCalculate.cxx:        ws->writeToFile(filename.Data());
ActionBatchScan.cxx:      ws->writeToFile(wsfile);
ActionExportModels.cxx:        if(model->writeToFile(filename,true,1,true)){
ActionExportWorkspace.cxx:        workspace->writeToFile(filename.Data(),true);
ActionExtractYieldChanges.cxx:        output->writeToFile(outrootfile);
ActionPrintResults.cxx:      bool write = config->getTagString("writeToFile",filename);
ActionPrintSystematicsImpact.cxx:      outFolder.writeToFile(TQFolder::concatPaths(outputPath,"systematicsImpact.root"),true);
TSStatisticsCalculator.cxx:    this->fWorkspace->writeToFile(writePreWS,true);
TSStatisticsCalculator.cxx:    this->fWorkspace->writeToFile(writePostWS,true);
TSStatisticsManager.cxx:      config->writeToFile(outfile);

ActionBatchCalculate.cxx:        tmp->exportToTextFile(snapshotfile);
ActionBatchCalculate.cxx:        if(outconfig->exportToTextFile(outconfigfile)){
ActionBatchScan.cxx:        base.exportToTextFile(outfile);
ActionExportModels.cxx:        if (model->exportToTextFile(filename)) {
ActionExportResults.cxx:        if (result->exportToTextFile(filename,true)) {
TSCLSignificanceEvaluator.cxx:		if(canRecycle) results->exportToTextFile(sigfname);
TSStatisticsManager.cxx:      config->exportToTextFile(outfile);

ActionPlotCorrelations.cxx:      std::ofstream log;
ActionPlotResults.cxx:      std::ofstream out(ofname.Data());
ActionPlotResults.cxx:      std::ofstream out(outputfile);
ActionPlotSystematicsHistograms.cxx:        std::ofstream summary(fname.Data());
ActionPrintResults.cxx:      std::ofstream outfile;

ActionPlotCorrelations.cxx:      c->SaveAs(outputfile);
ActionPlotHypothesisTest.cxx:        c->SaveAs(outputFile);
ActionPlotLikelihoodScan.cxx:          c->SaveAs(outputFile);
ActionPlotResults.cxx:        c->SaveAs(outputfile);
ActionPlotSystematicsSignificance.cxx:        c->SaveAs(filename+"_down"+extension);
ActionPlotSystematicsSignificance.cxx:        c->SaveAs(filename+"_up"+extension);
ActionPlotSystematicsSignificance.cxx:        c->SaveAs(filename+"_max"+extension);
ActionPlotSystematicsStatus.cxx:        c->SaveAs(filename);
ActionPlotToys.cxx:        c->SaveAs(outputFile);

ActionImportModels.cxx:        model = TQFolder::loadFolder(filename+":"+objectName);
ActionImportResults.cxx:        result = TQFolder::loadFolder(filename);

ActionBatchCalculate.cxx:        resultset->getFolder(TQFolder::concatPaths(this->component,version->GetName(),"FitResults")+"+")->importFromTextFile(TQFolder::concatPaths(path,"snapshots.txt"));
ActionPlotLikelihoodScan.cxx:        plot->importFromTextFile(path);
ActionPlotResults.cxx:      if (config->hasTag("textReplacements")) textReplacements->importFromTextFile(config->getTagStringDefault("textReplacements",""));
ActionPlotResults.cxx:      output->importFromTextFile(path);
ActionPrintSystematicsImpact.cxx:        textReplacements.importFromTextFile(s);
TSCLSignificanceEvaluator.cxx:	this->config->importFromTextFile(configfilename);
TSCLSignificanceEvaluator.cxx:		results->importFromTextFile(sigfname);
TSModelBuilder.cxx:    if(!model->importFromTextFile(file,msg)){
TSModelBuilder.cxx:      if(!sf->importFromTextFile(patch,msg)){

ActionCreateWorkspace.cxx:          TFile * histosFile = TFile::Open(histosFilename.Data(), "RECREATE", histosFilename.Data(), manager->getHistogramsFileCompression());
ActionExportHistograms.cxx:        TFile* outfile = TFile::Open(outfilename,"RECREATE");
ActionExportResults.cxx:        TFile * file = TFile::Open(filename.Data(), "RECREATE");
ActionImportWorkspace.cxx:      TFile * file = TFile::Open(filename.Data(), "READ");
ActionPlotSystematicsSignificance.cxx:        TFile * file = TFile::Open(filename.Data(), "RECREATE");
ActionPlotSystematicsStatus.cxx:        TFile * file = TFile::Open(filename.Data(), "RECREATE");

These places fall into different categories.

  • Genuine input and output files - these should be trival fixes.
    • all the ActionImport... and ActionExport...
    • all the ActionPlot... and ActionPrint...
    • everything in TSModelBuilder and TSModelFactory
  • Temporary files related to Batch submission - these might need to be handled differently, but I'm not sure about this, maybe an opinion by @kolehmann would be helpful here.
    • all the ActionBatch...
  • Some things I'm not sure about how to deal with, sicne they are either debugging outputs or have accumulated quite a bit of dust (basically everything else)

This is a lot of work, but it would be good to have these things fixed for the tutorial!