TSImpactCalculator contradicts itself
There is a conflicting use of tags in the TSImpactCalculator at these locations:
https://gitlab.cern.ch/atlas-caf/CAFCore/blob/master/SFramework/Root/TSImpactCalculator.cxx#L139
and
https://gitlab.cern.ch/atlas-caf/CAFCore/blob/master/SFramework/Root/TSImpactCalculator.cxx#L150
The issue only occurs if the conditional snapshot does not yet exist as only in this case the snapshottags are evaluated w.r.t floatPars and constPars. As the floatPars set during the first part of runPreFit(...) are not removed the snapshottags when trying to load (or create) the conditional snapshot the snapshottags are contradicting themselves at this point:
floatPars = "*"
constPars = "*"
The reason why this has likely not been observed before is that we usually ran the corresponding breakdown fits before such that the snapshots already exist.
This issue has first appeared when the corresponding minimizations in the breakdown code failed (but in fact the impact ones converge, see issue #83 (closed) )