Umami merge requestshttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests2022-01-14T15:53:16+01:00https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/337Adding Yamllint as pre-commit hook2022-01-14T15:53:16+01:00Manuel GuthAdding Yamllint as pre-commit hook`yamllint` is now also ran as pre-commit hook
closes #101`yamllint` is now also ran as pre-commit hook
closes #101https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/336Merge Integration test files for preprocessing2022-01-14T14:26:08+01:00Alexander FrochMerge Integration test files for preprocessingThis MR does the following:
* Fixing indentation in the docker pipeline yaml
* Merging the integration test files of the different preprocessing methods into one.
* Adapting the names of the preprocessing integration tests in the pipeli...This MR does the following:
* Fixing indentation in the docker pipeline yaml
* Merging the integration test files of the different preprocessing methods into one.
* Adapting the names of the preprocessing integration tests in the pipeline.
* Removing old unused files (closes #113)
* Merging the integration test files of the different tagger trainings into one.
* Old integration test files are removed.
* Fixing an old naming issue (Dl1r was called DL1 in some integration tests).
* Adapting pipelines to new files.
* Speeded up the training of dips a bit (closes #107)Alexander FrochAlexander Frochhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/335Sorting the Preprocess config a bit2022-01-12T15:43:52+01:00Alexander FrochSorting the Preprocess config a bitThis MR adds the following:
* Removing unused Preprocessing config (Hits, GNN). Those should be moved [here](https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami-config-tags).
* Adding comments to preprocess configs. Also ...This MR adds the following:
* Removing unused Preprocessing config (Hits, GNN). Those should be moved [here](https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami-config-tags).
* Adding comments to preprocess configs. Also updated the preprocessing docs.
* Moving `class_labels` to the `sampling` block because it is not used in `preparation`.
* Moving `intermediate_index_file` to parameters.
* `convert` to bottom of the file and renamed to `convert_to_tfrecord`.
* Split the unit tests again.
* Removing `iterations`.
* Adapting the tests.
Also:
* Fixing a remnant bug of !334.
* Adapting the plotting of `plotting_epoch_performance.py` to the fixes made here and in !334.
* Removing the zpext test files from the tfrecords training integration test to check if this is now working (the standard integration test without tfrecords checks if it is working with zpext).Alexander FrochAlexander Frochhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/333Pylint improvements2022-01-12T14:44:56+01:00Manuel GuthPylint improvementsFixing certain pylint errorsFixing certain pylint errorshttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/331Adding fix for DIPS/UMAMI integration test2022-01-11T15:39:44+01:00Alexander FrochAdding fix for DIPS/UMAMI integration testThis MR adds:
* Fixes a small issue with the integration tests of DIPS and UMAMI. The tests where called multiple times due to wrongly specifying which test should run (contributes to #107).
* Adding an exception to pylint (too-many-inst...This MR adds:
* Fixes a small issue with the integration tests of DIPS and UMAMI. The tests where called multiple times due to wrongly specifying which test should run (contributes to #107).
* Adding an exception to pylint (too-many-instance-attributes).Alexander FrochAlexander Frochhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/332Fixing flake8 issue and adding kwargs for plotting2022-01-11T14:50:40+01:00Manuel GuthFixing flake8 issue and adding kwargs for plottingThis MR fixes an issue with `flake8` which is related to #110 taking long to run the pre-commit hook.
In addition kwargs are introduced in the input variable plottingThis MR fixes an issue with `flake8` which is related to #110 taking long to run the pre-commit hook.
In addition kwargs are introduced in the input variable plottinghttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/330Fixing typo check in input variable plotting2022-01-11T11:51:59+01:00Alexander FrochFixing typo check in input variable plottingThis MR fixes #108. Correct checks are added and unit tests to check the behavior are implemented.
Closes #108This MR fixes #108. Correct checks are added and unit tests to check the behavior are implemented.
Closes #108Alexander FrochAlexander Frochhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/328Pylint improvements2021-12-23T13:34:26+01:00Manuel GuthPylint improvementsFixing several pylint errors:
- using `isinstance()` for type checking
step towards #105Fixing several pylint errors:
- using `isinstance()` for type checking
step towards #105https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/302move weights calculation to resampling2021-12-21T18:29:58+01:00Frederic Rennermove weights calculation to resamplingRemove weight initialization from prepare and move the weights calculation to the write step. Also moved the options for the weighting procedure into the sampling options of the preprocess config.
Closes #96Remove weight initialization from prepare and move the weights calculation to the write step. Also moved the options for the weighting procedure into the sampling options of the preprocess config.
Closes #96Frederic RennerFrederic Rennerhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/324Splitting up requirements2021-12-21T07:09:01+01:00Manuel GuthSplitting up requirementsSplitting requirements and adding a new base image `umamibase-plus` with additional packages not necessarily needed for umami itselfSplitting requirements and adding a new base image `umamibase-plus` with additional packages not necessarily needed for umami itselfhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/327Fixing docker build of umami base plus image2021-12-20T14:47:19+01:00Manuel GuthFixing docker build of umami base plus imagehttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/325pylint additions2021-12-20T12:48:51+01:00Manuel Guthpylint additionshttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/326quick fix such that pipeline master runs2021-12-20T11:18:12+01:00Manuel Guthquick fix such that pipeline master runshttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/322Kaniko Docker Builder2021-12-17T14:16:36+01:00Jackson BarrKaniko Docker BuilderChanging docker building to use the Kaniko builder, addressing #87.
closes #87Changing docker building to use the Kaniko builder, addressing #87.
closes #87https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/320Adding tfrecords for DIPS2021-12-17T11:39:15+01:00Alexander FrochAdding tfrecords for DIPSAlexander FrochAlexander Frochhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/321pylint init2021-12-17T10:51:58+01:00Manuel Guthpylint initadding pylint in the CI without `allow_failure`
a first pick of disabled errors was made, still lots of warnings and errors are raised
fixing black line length
step towards #105adding pylint in the CI without `allow_failure`
a first pick of disabled errors was made, still lots of warnings and errors are raised
fixing black line length
step towards #105https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/316Updating doc strings2021-12-16T12:38:13+01:00Manuel GuthUpdating doc stringsfirst step towards #97first step towards #97https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/314Fixing unit tests to run at once2021-12-15T17:45:18+01:00Manuel GuthFixing unit tests to run at oncecloses #94closes #94https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/310replacing .format with fstrings2021-12-15T15:24:11+01:00Manuel Guthreplacing .format with fstringshttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/309moving functions into separate histogram tools2021-12-15T13:42:00+01:00Manuel Guthmoving functions into separate histogram toolsadding separate histogram tools in new module `umami.helper_tools`
extending testing of these functionsadding separate histogram tools in new module `umami.helper_tools`
extending testing of these functions