Umami merge requestshttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests2022-11-23T15:11:58+01:00https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/673Moving/adding checks for options to train_config configuration2022-11-23T15:11:58+01:00Alexander FrochMoving/adding checks for options to train_config configuration## Summary
This MR introduces the following changes
* Moving check for `working_point` and `n_jets` to train_config configuration for validation/evaluation with a freshly trained tagger.
* Adding check for `frac_values` to train_config...## Summary
This MR introduces the following changes
* Moving check for `working_point` and `n_jets` to train_config configuration for validation/evaluation with a freshly trained tagger.
* Adding check for `frac_values` to train_config configuration for validation/evaluation with a freshly trained tagger.
* Adding checks for `tagger` and `frac_values_comp` to the train_config configuration for the validation/evaluation without a freshly trained tagger.
* Removing unused checks in various places for the moved/added checks.
* Adding unit tests for the configuration for the new checks
Relates to the following issues
* Closing #208
## Conformity
- [X] [Changelog entry](https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/blob/master/changelog.md)
- [X] [Documentation](https://umami-docs.web.cern.ch)
- [X] [Development guidelines](https://umami-docs.web.cern.ch/setup/development/)
- [X] [Style guides](https://umami-docs.web.cern.ch/setup/development/good-practices/)Alexander FrochAlexander Frochhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/489Draft: Small fix in histogram plotting API2022-03-22T18:00:16+01:00Joschka BirkDraft: Small fix in histogram plotting API## Summary
This MR introduces the following changes
* Set ratio uncertainty to zero for reference ratio (horizontal line at 1)
## Conformity
- ~~[ ] [Changelog entry](https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/...## Summary
This MR introduces the following changes
* Set ratio uncertainty to zero for reference ratio (horizontal line at 1)
## Conformity
- ~~[ ] [Changelog entry](https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/blob/master/changelog.md)~~
- ~~[] [Documentation](https://umami-docs.web.cern.ch)~~
- [x] [Development guidelines](https://umami-docs.web.cern.ch/setup/development/)
- [x] [Style guides](https://umami-docs.web.cern.ch/setup/development/good-practices/)Joschka BirkJoschka Birkhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/486Small fix in plotting_epoch_performance script2022-03-22T10:04:34+01:00Joschka BirkSmall fix in plotting_epoch_performance script## Summary
This MR introduces the following changes
* small fix for the following error
```bash
$ plotting_epoch_performance.py -c training_bb_dips_loose_16M_jets/metadata/Dips-PFlow-Training-config.yaml --dict training_bb_dips_loose_1...## Summary
This MR introduces the following changes
* small fix for the following error
```bash
$ plotting_epoch_performance.py -c training_bb_dips_loose_16M_jets/metadata/Dips-PFlow-Training-config.yaml --dict training_bb_dips_loose_16M_jets/validation_WP0p77_300000jets_Dict.json
INFO:umami: Using train config file training_bb_dips_loose_16M_jets/metadata/Dips-PFlow-Training-config.yaml
INFO:umami: Using config file /home/fr/fr_fr/fr_jb666/b-tagging/packages/umami/umami/training_bb_dips_loose_16M_jets/metadata/PFlow-Preprocessing.yaml
Traceback (most recent call last):
File "/home/fr/fr_fr/fr_jb666/b-tagging/packages/umami_dev/python_install/bin/plotting_epoch_performance.py", line 7, in <module>
exec(compile(f.read(), __file__, 'exec'))
File "/home/fr/fr_fr/fr_jb666/b-tagging/packages/umami_dev/umami/plotting_epoch_performance.py", line 207, in <module>
main(parser_args, training_config, preprocessing_config)
File "/home/fr/fr_fr/fr_jb666/b-tagging/packages/umami_dev/umami/plotting_epoch_performance.py", line 180, in main
for comp_tagger in comp_tagger_list
UnboundLocalError: local variable 'comp_tagger_list' referenced before assignment
```
## Conformity
- ~~[x] [Changelog entry](https://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/blob/master/changelog.md)~~
- ~~[x] [Documentation](https://umami-docs.web.cern.ch)~~
- ~~[x] [Development guidelines](https://umami-docs.web.cern.ch/setup/development/)~~
- ~~[x] [Style guides](https://umami-docs.web.cern.ch/setup/development/good-practices/)~~Joschka BirkJoschka Birkhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/362Merging master in protected branch2022-01-21T14:44:14+01:00Alexander FrochMerging master in protected branchhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/350Merging Master2022-01-19T11:30:39+01:00Alexander FrochMerging MasterAlexander FrochAlexander Frochhttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/288Remove overlap of plotlabel with unit2021-12-20T13:52:34+01:00Frederic RennerRemove overlap of plotlabel with unithttps://gitlab.cern.ch/atlas-flavor-tagging-tools/algorithms/umami/-/merge_requests/155Remove hard-coded labels for DIPS2021-08-17T18:03:22+02:00Alexander FrochRemove hard-coded labels for DIPSThis MR will remove the hard-coded labels in the training process for DIPS. I did this only for DIPS in one go, because the MR is already very large (Sorry for that...) but I wasn't able to make it smaller. But the next MRs concerning th...This MR will remove the hard-coded labels in the training process for DIPS. I did this only for DIPS in one go, because the MR is already very large (Sorry for that...) but I wasn't able to make it smaller. But the next MRs concerning the rewriting of the DL1r and UMAMI tools should be less.Preprocessing rewriteAlexander FrochAlexander Froch