training-dataset-dumper merge requestshttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests2024-03-28T18:13:46+01:00https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/658Simple fix to submitting track. syst. variations to grid via loop2024-03-28T18:13:46+01:00Vid HomsakSimple fix to submitting track. syst. variations to grid via loop### Description
Just an intermediate solution until in-parallel submission is done so that people don't have to change the config file 30x and then push changes 30x to git.
I just made a folder with config files containing track varia...### Description
Just an intermediate solution until in-parallel submission is done so that people don't have to change the config file 30x and then push changes 30x to git.
I just made a folder with config files containing track variations that can be specified as input config files in a bash for loop which calls `grid-submit -c EMPFlowRetag_minimal_configs/EMPFlowRetag_minimal_${track_systematic}` etc.
Also includes changes from my other [MR](https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/655#note_7796694), so first merge the other one i guess.
Review checklist:
- [ ] CI Passing
- [ ] Comments addressed
- [ ] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/657Updated documentation to use Derivation_tf rather than Reco_tf.2024-03-28T18:06:15+01:00Thomas Benjamin DingleyUpdated documentation to use Derivation_tf rather than Reco_tf.Hi @dguest, updated documentation for making new test files.Hi @dguest, updated documentation for making new test files.https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/656update readme2024-03-28T15:52:18+01:00Lorenzo Santiupdate readmeUpdate readme.
stup athena.sh instead of analysisbase.sh
tagging @svanstroUpdate readme.
stup athena.sh instead of analysisbase.sh
tagging @svanstrohttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/655Added SV mass, HadronConeExclTruthLabelID and running flipped+standard for tr...2024-03-28T18:06:16+01:00Vid HomsakAdded SV mass, HadronConeExclTruthLabelID and running flipped+standard for track. syst. retag jobs<!--
If this is your first time making an MR please read
ftag.docs.cern.ch/getting_involved/how_to_ftag/#code-gitlab
-->
### Description
<!--Please provide a detailed description of your changes here-->
<!--Please link any relevant is...<!--
If this is your first time making an MR please read
ftag.docs.cern.ch/getting_involved/how_to_ftag/#code-gitlab
-->
### Description
<!--Please provide a detailed description of your changes here-->
<!--Please link any relevant issues:-->
<!--Closes #issue will automatically close the issue when the MR is merged-->
<!--Relates to #issue will link the issue to the MR-->
<!--The following items need to be addressed before your request can be merged-->
<!--Please proactively take care of them!-->
Review checklist:
- [x] CI Passing
- [x] Comments addressed
- [ ] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/654Add GN2v01 No Aux model2024-03-28T15:21:53+01:00Samuel Van StroudAdd GN2v01 No Aux modelcc @jmwagner
- [ ] CI Passing
- [ ] Comments addressed
- [ ] Source branch is up to date with targetcc @jmwagner
- [ ] CI Passing
- [ ] Comments addressed
- [ ] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/653Change default for JetMatcher block2024-03-28T12:25:36+01:00Samuel Van StroudChange default for JetMatcher block### Description
pt priority within a dR cone of 0.3 is probably not what we want for a defualt.
this makes dR minimisation the default matching approach.
@wlai has been looking at matching pflow to ufo jets and things look a bit muddy...### Description
pt priority within a dR cone of 0.3 is probably not what we want for a defualt.
this makes dR minimisation the default matching approach.
@wlai has been looking at matching pflow to ufo jets and things look a bit muddy..
it might also not be optimal for tau..
Review checklist:
- [x] CI Passing
- [x] Comments addressed
- [x] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/652move retag and retag-lite to using MC202024-03-28T11:43:23+01:00Dan Guestmove retag and retag-lite to using MC20Right now some systematics we'll want in retagging aren't supported in mc23. I'm moving tests over to using mc20 so that we can build tests around these systematics, as we're doing in !648.Right now some systematics we'll want in retagging aren't supported in mc23. I'm moving tests over to using mc20 so that we can build tests around these systematics, as we're doing in !648.https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/651Make ca config accumulator more module for taucomp2024-03-28T11:14:08+01:00Nikita Ivvan PondMake ca config accumulator more module for taucompImplements the changes recommended in !649Implements the changes recommended in !649https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/650Cleanup min deltaR(track, hit) algorithm2024-03-27T13:14:07+01:00Dan GuestCleanup min deltaR(track, hit) algorithmWhen I was compiling I got some errors around repeated property names. I couldn't bring myself to just fix that and not clean up the overall algorithm.
Should do the same thing, maybe faster, definitely simpler.
Might be of interest to...When I was compiling I got some errors around repeated property names. I couldn't bring myself to just fix that and not clean up the overall algorithm.
Should do the same thing, maybe faster, definitely simpler.
Might be of interest to @rkusters.https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/649Moved taucomp dumping into new ca block approach2024-03-27T13:13:19+01:00Nikita Ivvan PondMoved taucomp dumping into new ca block approachRemoved old 'taucomp' executable in favour of new python CA block approach. Partly resolves #138.Removed old 'taucomp' executable in favour of new python CA block approach. Partly resolves #138.https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/648Draft: Error running rich configuration (EMPFlowRetagAthena), TRK_RES_D0_MEAS...2024-03-28T16:40:58+01:00Thomas Benjamin DingleyDraft: Error running rich configuration (EMPFlowRetagAthena), TRK_RES_D0_MEAS within EMPFlowRetag causes error.Hi @dguest, here's a draft MR of the bug we discuss on MM.Hi @dguest, here's a draft MR of the bug we discuss on MM.https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/647Fix trackless grid2024-03-26T14:38:34+01:00Roman KustersFix trackless gridYesterday in the [MR for the blocks](https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/645) I forgot to change the grid submission. <br>
This should fix it
Sorry for this, @svanstro
- [x] CI Pass...Yesterday in the [MR for the blocks](https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/645) I forgot to change the grid submission. <br>
This should fix it
Sorry for this, @svanstro
- [x] CI Passing
- [x] Comments addressed
- [x] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/646Cleanup kfold config2024-03-26T13:23:20+01:00Samuel Van StroudCleanup kfold config### Description
this MR does two things
- removes the `EMPFlow_kfold.json` config, returning to the original default `EMFPlfow.json`.
- remove the `FoldDecoratorAlg` since we can run it from athena https://gitlab.cern.ch/atlas/athena/-/...### Description
this MR does two things
- removes the `EMPFlow_kfold.json` config, returning to the original default `EMFPlfow.json`.
- remove the `FoldDecoratorAlg` since we can run it from athena https://gitlab.cern.ch/atlas/athena/-/merge_requests/67272
Review checklist:
- [x] CI Passing
- [x] Comments addressed
- [x] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/645Add trackless block2024-03-26T13:44:28+01:00Roman KustersAdd trackless blockThe issue of issue [138](https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/issues/138) is adressed here <br>
I used MultiFoldTagger as starting point and removed/added unnecessary/necessary commands. <br>
@svans...The issue of issue [138](https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/issues/138) is adressed here <br>
I used MultiFoldTagger as starting point and removed/added unnecessary/necessary commands. <br>
@svanstro , can you have a look that everything is correct?
Review checklist:
- [x] CI Passing
- [ ] Comments addressed
- [x] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/644Clean up writers2024-03-26T14:45:32+01:00Samuel Van StroudClean up writers### Description
I'm removed some wrappers around writers that seemed trivial, @dguest should probably take a look at this in case these were doing someting worthwhile though..
Review checklist:
- [x] CI Passing
- [x] Comments addresse...### Description
I'm removed some wrappers around writers that seemed trivial, @dguest should probably take a look at this in case these were doing someting worthwhile though..
Review checklist:
- [x] CI Passing
- [x] Comments addressed
- [x] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/643Automatic documentation for blocks2024-03-26T13:54:28+01:00Samuel Van StroudAutomatic documentation for blocksAdds automatic documentation for CA blocks, and cleaned up a few other bits.Adds automatic documentation for CA blocks, and cleaned up a few other bits.https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/642Replace scripts with CA blocks2024-03-25T15:02:51+01:00Samuel Van StroudReplace scripts with CA blocks### Description
Following up from https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/637.
This relates to #138 and closes #135.
The following blocks are added
- `MultifoldTagger`, replacing `dum...### Description
Following up from https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/637.
This relates to #138 and closes #135.
The following blocks are added
- `MultifoldTagger`, replacing `dump-kfold` and `dump-run3-paper` (attention @nekumari)
- `FixedConeAssociation` and `ShrinkingConeAssociation` (@wlai should be able to use these with the above to replace some stuff in `dump-ufo`
- `FoldHashDecorator` replacing `dump-augmented`
I'm intentionally not squashing here so there are some examples of adding individual blocks in the commit history.
Review checklist:
- [x] CI Passing
- [x] Comments addressed
- [x] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/641Draft: Caloclusters22024-03-28T11:17:32+01:00Ivan OleksiyukDraft: Caloclusters2### Description
Make it possible to dump calo clusters as constituents of the jet
Related to this issue:
atlas-flavor-tagging-tools/training-dataset-dumper#128
Review checklist:
- [ ] CI Passing
- [ ] Comments addressed
- [ ] Source b...### Description
Make it possible to dump calo clusters as constituents of the jet
Related to this issue:
atlas-flavor-tagging-tools/training-dataset-dumper#128
Review checklist:
- [ ] CI Passing
- [ ] Comments addressed
- [ ] Source branch is up to date with targethttps://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/640Addition grid submit checks2024-03-22T15:26:33+01:00Nikita Ivvan PondAddition grid submit checksFixes bug where user tries to select dumping a certain number of events with `grid-submit` and has voms setup, but does not have rucio setup.
Adds a check that rucio is setup, and exits if not.Fixes bug where user tries to select dumping a certain number of events with `grid-submit` and has voms setup, but does not have rucio setup.
Adds a check that rucio is setup, and exits if not.https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/639Retry CI jobs once2024-03-21T21:49:06+01:00Samuel Van StroudRetry CI jobs once<!--
If this is your first time making an MR please read
ftag.docs.cern.ch/getting_involved/how_to_ftag/#code-gitlab
-->
### Description
Tests can be a bit flaky, let's default to a single retry.
Review checklist:
- [x] CI Passing
- ...<!--
If this is your first time making an MR please read
ftag.docs.cern.ch/getting_involved/how_to_ftag/#code-gitlab
-->
### Description
Tests can be a bit flaky, let's default to a single retry.
Review checklist:
- [x] CI Passing
- [x] Comments addressed
- [x] Source branch is up to date with target