Skip to content

Internal cleanup: hit and truth outputs

Dan Guest requested to merge dguest/training-dataset-dumper:cleanup into r22

This cleans up a few things following !182 (merged) and !225 (merged):

  • Split the SingleBTagTools into const SingleBTagTools and SingleBTagOutputs. I hope this distinction makes it clear that none of the tools should be mutable in the event loop. At the very least it should and enforce const-ness in the future1.
  • Absorb the Hit class into the only file that uses it, HitDecorator.cxx. The work it was doing was so minimal that making its methods free functions seemed simpler.
  • Remove the TruthToolkit struct in SingleBTagTools, replace it with TruthWriter, which was one of the three original data members of TruthToolkit. The other two members were copied out of a configuration object, and were only used to initialize other tools, in a scope where the the original configuration object was still available.

  1. For now SingleBTagTools is still not const, because some methods from Athena were non-const. This should be reverted once we bump to a release containing atlas/athena!49253 (merged) ↩

Edited by Dan Guest

Merge request reports