Skip to content

Draft: Complementary merge request to Athena hit-level information accessing

Mathias Josef Backes requested to merge backes/training-dataset-dumper:hits-branch into main

Description

Review checklist:

  • CI Passing
  • Comments addressed
  • Source branch is up to date with target

Hi @dguest,

this is the complementary MR to atlas/athena!73611 (merged), which gives the opportunity to actually run an onnx model in TDD. Right now tests are of course failing because the necessary algorithms are not yet part of athena, therefore I kept it a draft. Detailed description:

  • trigger.py: executes the relevant algorithms to make the hit-level information available to the network.
  • cleanHits.cxx: avoiding overlap removal because it is black magic
  • trigger_hitz_network.json: One example of a config file running a HitZ network. It is extremely important to set "save_only_clean_hits": false, , otherwise not all the hits are saved and one will get differences to the Salt evaluation of the network.

This might be interesting for people that work with this in the future.

Merge request reports