MC Job Options issueshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues2019-07-03T15:14:27+02:00https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/14Protection for CI jobs triggered by mistake (gitlab bugs)2019-07-03T15:14:27+02:00Spyros ArgyropoulosProtection for CI jobs triggered by mistake (gitlab bugs)Currently the CI job scripts depend on the correct triggering of the jobs by the logic coded into the `gitlab-ci.yml` file.
If a job gets triggered by mistake it will return a failure, because the `grep` commands will not find any mat...Currently the CI job scripts depend on the correct triggering of the jobs by the logic coded into the `gitlab-ci.yml` file.
If a job gets triggered by mistake it will return a failure, because the `grep` commands will not find any matching file. In principle there is no need for such a triggered job to return failure.
This can be solved by using
```
set -e
grep ...
set +e
```
#11Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/13Test CI with multiple simultaneous commits2019-07-03T15:14:28+02:00Spyros ArgyropoulosTest CI with multiple simultaneous commitsNeed to add at least two DSID directories simultaneously and
* [x] check that the jobs run, going through all the new DSID directories
* [x] check with steering scriptNeed to add at least two DSID directories simultaneously and
* [x] check that the jobs run, going through all the new DSID directories
* [x] check with steering scriptSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/11Wrong job triggering2019-07-03T15:14:26+02:00Spyros ArgyropoulosWrong job triggeringhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/commit/e4d5928c74e5d3f0ca6c00e6304b6845844b07de
Adding a non jO file triggered several jO-related jobs.
Need to investigate and fix.
* [x] Check if it is fixed by c2bb3e51770d5780e...https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/commit/e4d5928c74e5d3f0ca6c00e6304b6845844b07de
Adding a non jO file triggered several jO-related jobs.
Need to investigate and fix.
* [x] Check if it is fixed by c2bb3e51770d5780ead48ad82fc0c295d34f9afe
This is now fixed as discussed in #9 and also in #14 (will close this automatically through the MR)Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/8Develop CI checks for jO that require new base fragments2019-07-01T13:17:58+02:00Spyros ArgyropoulosDevelop CI checks for jO that require new base fragmentsAn example can be found in `421xxx/421002`.
Perhaps for the moment we don't need anything more than the `run_athena` job implemented in the `run_athena` branch, but this will not catch the problematic case described below.
Someone has ...An example can be found in `421xxx/421002`.
Perhaps for the moment we don't need anything more than the `run_athena` job implemented in the `run_athena` branch, but this will not catch the problematic case described below.
Someone has 421002 locally where they override the common file with their local one and then they forget to push it to the repo.
The athena job in this case still runs (see attachment below) but probably produces different results from what the local job produced. This is impossible to catch with the current checks.
Maybe one way would be to run athena with exactly the same settings (random numbers etc, extracted from log.generate) and then perhaps write a basic rivet routine (that the uploader should also provide for their local run). Maybe it's a bit too much but we should see how to avoid the above problem.
* [x] Check 421002 with new automatic script
* [x] Check what happens when 421002 is added without the `Sherpa_i` directory
=> Athena runs with no error
* [ ] Develop logic to avoid the situation reported here
[log.generate_without_Sherpa_i](/uploads/2972af7f71bb85defeb491437cdae3f6/log.generate_without_Sherpa_i)[log.generate_with_Sherpa_i](/uploads/fbc9fd01b84211061628ecf2a972d07f/log.generate_with_Sherpa_i)
@fsiegert can you tell from the log.generate files above which one was using `Sherpa_i/2.2.6_BaseFragment.py`?
And how are we supposed to know if a user should or shouldn't upload an additional directory in a DSID directory?https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/225logParser failed due to missing platform info2024-02-01T14:46:57+01:00Yang LiulogParser failed due to missing platform infoHi @sargyrop , as we discussed in [Fixing automatic determination of release for CI runs (!2861) · Merge requests · atlas-physics / pmg / MC Job Options · GitLab (cern.ch)](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_re...Hi @sargyrop , as we discussed in [Fixing automatic determination of release for CI runs (!2861) · Merge requests · atlas-physics / pmg / MC Job Options · GitLab (cern.ch)](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2861). It seems the added line to extract the platform info will cause problem for some of the jobs.
[Here](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/6821117) is one example.
Many thanks for your time to help.
Cheers
Yanghttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/2185360 GeV shoudl be an allowed energy in the CI2023-10-20T11:15:28+02:00Jan Kretzschmar5360 GeV shoudl be an allowed energy in the CIhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2669
Run 3 HI and reference run energy will be 5360 GeV, so the CI should not fail with
"ERROR: unknown ecmEnergy: 5360.0"
Full log file also on lxplus in ~jkretz/pu...https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2669
Run 3 HI and reference run energy will be 5360 GeV, so the CI should not fail with
"ERROR: unknown ecmEnergy: 5360.0"
Full log file also on lxplus in ~jkretz/public/log.generateSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/197check_jo_consistency failed2022-12-19T16:20:55+01:00Yiming Abulaiticheck_jo_consistency failedHi,
When I commit a second time after fix something in Control file, the consistency check failed.
The consistency is checking some other files that is not a part of my commits (I am trying to register 518405-518446 range).
But job is fa...Hi,
When I commit a second time after fix something in Control file, the consistency check failed.
The consistency is checking some other files that is not a part of my commits (I am trying to register 518405-518446 range).
But job is failed due to some errors related to 421xxx/421100/..
So How can I fix this?
Cheers,
Ablet
Error part:
OK: No generator full name is found
Generators used: ['Py8', 'EG']
ERROR: file /builds/atlas-physics/pmg/mcjoboptions/scripts/../421xxx/421100/mc.Py8EG_A14NNPDF23LO_Ztautau.py contains includes pointing to MC15JobOptions
Failed Job
https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/26543765Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/176Job Failed #220519692022-05-26T00:34:53+02:00Jan KretzschmarJob Failed #22051969Job [#22051969](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/22051969) failed for 6964c28821e9ec0e33f4548a73191e02293e6c5b:
Hi @sargyrop , this pipeline appears to throw a couple of warnings and errors eventually. This i...Job [#22051969](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/22051969) failed for 6964c28821e9ec0e33f4548a73191e02293e6c5b:
Hi @sargyrop , this pipeline appears to throw a couple of warnings and errors eventually. This is using a pretty old SL6 release, so maybe it cannot be fixed...? Maybe you can just have a quick look and let us know.
thanks, JanSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/174Arithmetic expression error in check_logParser.sh2022-05-17T16:23:22+02:00Spyros ArgyropoulosArithmetic expression error in check_logParser.shSee https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/21845100See https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/21845100https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/172EVNTtoEVNT and ECM: fails to download input EVNT in CI2022-05-17T16:03:17+02:00Matthew GignacEVNTtoEVNT and ECM: fails to download input EVNT in CIHi,
A few of the CI jobs fail for some E2E jOs in mc21: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/21697381
Looks like the $ECMENERGY environment variable is not correctly set. In this type of transform, the ECM is no...Hi,
A few of the CI jobs fail for some E2E jOs in mc21: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/21697381
Looks like the $ECMENERGY environment variable is not correctly set. In this type of transform, the ECM is not required and not written into the log, which is probably the underlying issue. Any ideas on how to detect this?
As an aside, I noticed that the log.generate.short is claiming ecmEnergy of 13000 GeV, though the transform was run with 13600 TeV (not that it matters...). I guess the 13000 is a default somewhere, which maybe is causing some issues?
Cheers,
MatthewSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/171CI download to check for grid input LHEs with mc21_13p6TeV scope2022-05-10T07:28:54+02:00Jan KretzschmarCI download to check for grid input LHEs with mc21_13p6TeV scopeIn https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1824 I hit the problem, that Grid input LHEs are always trying to be downloaded with mc15_13TeV or mc16_13TeV scope, I think the origin of this is here:
https://gi...In https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1824 I hit the problem, that Grid input LHEs are always trying to be downloaded with mc15_13TeV or mc16_13TeV scope, I think the origin of this is here:
https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/scripts/run_athena.sh#L115-138
First, it would probably be preferable, if we get the CME string from the CME value rather than fixing it to 13 TeV.
Second, we now also need to allow mc21
As shortest patch we could just keep extending the list of allowed scopes, here mc21_13p6TeV being the obvious one to add immediately.
Many thanks, Janhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/163ecmEnergy in logParser fixed to 13000 GeV?2022-04-06T11:25:01+02:00Jan KretzschmarecmEnergy in logParser fixed to 13000 GeV?I have the impression that logParser fixes the ecmEnergy to 13000 GeV in the log.generate.short irrespective what the given log file gives
https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/scripts/logParser.py#L471
Thi...I have the impression that logParser fixes the ecmEnergy to 13000 GeV in the log.generate.short irrespective what the given log file gives
https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/scripts/logParser.py#L471
This impacted https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1748
(I can fix that MR myself now)https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/161logParser expects randomSeed arg even for E2E jobs2022-03-25T14:51:01+01:00Jan KretzschmarlogParser expects randomSeed arg even for E2E jobsHi,
in https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1725 I think I 'discovered' an issue that the logParser requires the argument 'randomSeed' to be present also for EVNT-to-EVNT (afterburner filtering) jobs. T...Hi,
in https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1725 I think I 'discovered' an issue that the logParser requires the argument 'randomSeed' to be present also for EVNT-to-EVNT (afterburner filtering) jobs. The problem is: even if you give the argument, it is not printed to the log file. Not sure if this is an issue of the transform, but in any case these jobs are not really supposed to need ranfdom numbers in most case.
Thanks, JanSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/24Job Failed #48807582019-09-07T18:41:13+02:00Spyros ArgyropoulosJob Failed #4880758Job [#4880758](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/4880758) failed for c37bfdba233ab60aa7eaa675e7e20a779f139397:
Hi @ewelina
could you tell me how you added the common files in the commit 6e8ff9e140f5adc76760...Job [#4880758](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/4880758) failed for c37bfdba233ab60aa7eaa675e7e20a779f139397:
Hi @ewelina
could you tell me how you added the common files in the commit 6e8ff9e140f5adc7676050434594499325345137 ?
The `check_added_files` should have run on your branch but it didn't.
Things would be cleaner if we delete the branches after each MR is approved. So I will delete testart now and you can recreate it for a future MR. Is this ok with you?
* [ ] delete testart
* [ ] understand why `check_added_files` didn't run on 6e8ff9e140f5adc7676050434594499325345137Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/186Automatically merging MR from pipeline2022-08-25T09:35:17+02:00Spyros ArgyropoulosAutomatically merging MR from pipelineWhen running `merge_request_api.sh -m` from the pipeline we get a method not allowed because the pipeline is still running.
Need to fix this in order to enable an automatic merging - perhaps turn it into a "merge when pipeline succeeds...When running `merge_request_api.sh -m` from the pipeline we get a method not allowed because the pipeline is still running.
Need to fix this in order to enable an automatic merging - perhaps turn it into a "merge when pipeline succeeds"
See !2001Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/185Rebasing branching for automatically created MR when merging2024-02-18T07:24:20+01:00Spyros ArgyropoulosRebasing branching for automatically created MR when mergingWhen trying to merge automatically created MR we can get
```
./scripts/merge_request_api.sh -m
MR: 1993 - approvals left: 0
Merging 1993
{"message":"Branch cannot be merged"}
```
when previous MRs were merged in between.
One would have...When trying to merge automatically created MR we can get
```
./scripts/merge_request_api.sh -m
MR: 1993 - approvals left: 0
Merging 1993
{"message":"Branch cannot be merged"}
```
when previous MRs were merged in between.
One would have to rebase:
![Screenshot_2022-08-23_at_09.34.00](/uploads/d2d8219eaf65ec850b6169a63c62b2c8/Screenshot_2022-08-23_at_09.34.00.png)
from the CI which will launch another pipeline.
Need to see how to treat this in the pipeline.Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/227Establish CI to handle stale MRs and branches2024-02-19T11:14:22+01:00Spyros ArgyropoulosEstablish CI to handle stale MRs and branchesFollowing !2906 we should add a CI job that uses this functionality to handle MRs that are open for long with failed pipelines and also delete the associated branches when closing the MRsFollowing !2906 we should add a CI job that uses this functionality to handle MRs that are open for long with failed pipelines and also delete the associated branches when closing the MRsSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/223Block the usage of xAOD filters in HepMC3 releases2024-01-26T23:10:32+01:00Spyros ArgyropoulosBlock the usage of xAOD filters in HepMC3 releasesSee [this talk](https://indico.cern.ch/event/1372411/contributions/5770199/attachments/2788275/4861850/rel23_Jan2_24.pdf) for a description of the problem.
We want to block all jO that use HepMC3 (all r23.6 for the moment - to be fine t...See [this talk](https://indico.cern.ch/event/1372411/contributions/5770199/attachments/2788275/4861850/rel23_Jan2_24.pdf) for a description of the problem.
We want to block all jO that use HepMC3 (all r23.6 for the moment - to be fine tuned later) that use xAOD filters.Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/221CI has to run on AlamLinux9 environment2024-01-31T07:55:48+01:00Yiming AbulaitiCI has to run on AlamLinux9 environmentHi All,
The new release 23.6.20 is available only on the AlamLinux9 environment.
But GIT CI don't support AL9 yet.
So in order to test new JOs with 23.6.20 CI has to run on AL9.
Depends on https://gitlab.cern.ch/atlas/athena/-/merge_re...Hi All,
The new release 23.6.20 is available only on the AlamLinux9 environment.
But GIT CI don't support AL9 yet.
So in order to test new JOs with 23.6.20 CI has to run on AL9.
Depends on https://gitlab.cern.ch/atlas/athena/-/merge_requests/67225Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/220Query ProdSys instead of rucio when checking for registered files2023-11-09T15:57:22+01:00Spyros ArgyropoulosQuery ProdSys instead of rucio when checking for registered filesCurrently when `[skip modfiles]` is used `notify.sh` is checking on rucio if samples with a given DSID exist.
When a sample is obsoleted it apparently takes very long for the information to propagate so we should check if we can use Prod...Currently when `[skip modfiles]` is used `notify.sh` is checking on rucio if samples with a given DSID exist.
When a sample is obsoleted it apparently takes very long for the information to propagate so we should check if we can use ProdSys instead.Spyros ArgyropoulosSpyros Argyropoulos