MC Job Options issueshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues2024-02-19T11:14:22+01:00https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/227Establish CI to handle stale MRs and branches2024-02-19T11:14:22+01:00Spyros ArgyropoulosEstablish CI to handle stale MRs and branchesFollowing !2906 we should add a CI job that uses this functionality to handle MRs that are open for long with failed pipelines and also delete the associated branches when closing the MRsFollowing !2906 we should add a CI job that uses this functionality to handle MRs that are open for long with failed pipelines and also delete the associated branches when closing the MRsSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/225logParser failed due to missing platform info2024-02-01T14:46:57+01:00Yang LiulogParser failed due to missing platform infoHi @sargyrop , as we discussed in [Fixing automatic determination of release for CI runs (!2861) · Merge requests · atlas-physics / pmg / MC Job Options · GitLab (cern.ch)](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_re...Hi @sargyrop , as we discussed in [Fixing automatic determination of release for CI runs (!2861) · Merge requests · atlas-physics / pmg / MC Job Options · GitLab (cern.ch)](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2861). It seems the added line to extract the platform info will cause problem for some of the jobs.
[Here](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/6821117) is one example.
Many thanks for your time to help.
Cheers
Yanghttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/223Block the usage of xAOD filters in HepMC3 releases2024-01-26T23:10:32+01:00Spyros ArgyropoulosBlock the usage of xAOD filters in HepMC3 releasesSee [this talk](https://indico.cern.ch/event/1372411/contributions/5770199/attachments/2788275/4861850/rel23_Jan2_24.pdf) for a description of the problem.
We want to block all jO that use HepMC3 (all r23.6 for the moment - to be fine t...See [this talk](https://indico.cern.ch/event/1372411/contributions/5770199/attachments/2788275/4861850/rel23_Jan2_24.pdf) for a description of the problem.
We want to block all jO that use HepMC3 (all r23.6 for the moment - to be fine tuned later) that use xAOD filters.Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/221CI has to run on AlamLinux9 environment2024-01-31T07:55:48+01:00Yiming AbulaitiCI has to run on AlamLinux9 environmentHi All,
The new release 23.6.20 is available only on the AlamLinux9 environment.
But GIT CI don't support AL9 yet.
So in order to test new JOs with 23.6.20 CI has to run on AL9.
Depends on https://gitlab.cern.ch/atlas/athena/-/merge_re...Hi All,
The new release 23.6.20 is available only on the AlamLinux9 environment.
But GIT CI don't support AL9 yet.
So in order to test new JOs with 23.6.20 CI has to run on AL9.
Depends on https://gitlab.cern.ch/atlas/athena/-/merge_requests/67225Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/220Query ProdSys instead of rucio when checking for registered files2023-11-09T15:57:22+01:00Spyros ArgyropoulosQuery ProdSys instead of rucio when checking for registered filesCurrently when `[skip modfiles]` is used `notify.sh` is checking on rucio if samples with a given DSID exist.
When a sample is obsoleted it apparently takes very long for the information to propagate so we should check if we can use Prod...Currently when `[skip modfiles]` is used `notify.sh` is checking on rucio if samples with a given DSID exist.
When a sample is obsoleted it apparently takes very long for the information to propagate so we should check if we can use ProdSys instead.Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/2185360 GeV shoudl be an allowed energy in the CI2023-10-20T11:15:28+02:00Jan Kretzschmar5360 GeV shoudl be an allowed energy in the CIhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2669
Run 3 HI and reference run energy will be 5360 GeV, so the CI should not fail with
"ERROR: unknown ecmEnergy: 5360.0"
Full log file also on lxplus in ~jkretz/pu...https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2669
Run 3 HI and reference run energy will be 5360 GeV, so the CI should not fail with
"ERROR: unknown ecmEnergy: 5360.0"
Full log file also on lxplus in ~jkretz/public/log.generateSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/216Allow rucio to download files stored on datadisk2023-09-29T15:48:41+02:00Spyros ArgyropoulosAllow rucio to download files stored on datadiskIn !2641 the CI failed because the input LHE was stored on datadisk
```
rucio list-file-replicas mc23_13p6TeV:TXT.33690939._000003.tar.gz.1
| mc23_13p6TeV | TXT.33690939._000003.tar.gz.1 | 1.345 MB | 6ed2753b | FZK-LCG2_DATADISK: roo...In !2641 the CI failed because the input LHE was stored on datadisk
```
rucio list-file-replicas mc23_13p6TeV:TXT.33690939._000003.tar.gz.1
| mc23_13p6TeV | TXT.33690939._000003.tar.gz.1 | 1.345 MB | 6ed2753b | FZK-LCG2_DATADISK: root://atlasxrootd-kit.gridka.de:1094//pnfs/gridka.de/atlas/disk-only/atlasdatadisk/rucio/mc23_13p6TeV/c5/61/TXT.33690939._000003.tar.gz.1 |
```
Misha said this is not an issue for prodsys because `rucio download` can be used from everywhere.
Apparently we can request special access for `mcgensvc` from mailto:atlas-adc-ddm-support@cern.ch
(we should keep Misha in cc)
We probably also need to request a new grid certificate for `mcgensvc`Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/212Allow running `mc??_valid` input files2023-07-31T09:40:55+02:00Spyros ArgyropoulosAllow running `mc??_valid` input filesCurrently the CI cannot run on input files named like `mc15_valid.602232.Ph_ttj_MiNNLO_scale5_LHE.evgen.TXT.e8531/TXT.34045098._000002.tar.gz.1`
The `valid` replaces the COM energy so it is potentially a not well defined naming conventi...Currently the CI cannot run on input files named like `mc15_valid.602232.Ph_ttj_MiNNLO_scale5_LHE.evgen.TXT.e8531/TXT.34045098._000002.tar.gz.1`
The `valid` replaces the COM energy so it is potentially a not well defined naming convention, since the COM energy is taken automatically from `ecmEnergy` from `log.generate` which is [directly printed from the transform](https://gitlab.cern.ch/atlas/athena/-/blob/main/Generators/EvgenJobTransforms/share/skel.GENtoEVGEN.py#L105) - from the command line arguments.
One solution is to ignore the `ecmEnergy` completely if we see that the input filed is named as `mc??_valid` however I think that's problematic because an LHE should correspond to a given COM energy and we should not allow it to be used indepndently of the `ecmEnergy`.
@katharin @mgignac @dhirschSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/210Make some jo checks stricter?2024-02-18T07:23:36+01:00Spyros ArgyropoulosMake some jo checks stricter?```
runArgs.inputGeneratorFile = outputDS.replace('tar.gz', 'events')
```
passes the check since when running the jO outside the transform it leads to an undefined object.
Maybe we need another way to avoid such issues.```
runArgs.inputGeneratorFile = outputDS.replace('tar.gz', 'events')
```
passes the check since when running the jO outside the transform it leads to an undefined object.
Maybe we need another way to avoid such issues.Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/206Investigate whether the comment from mcgensvc in the notify job can be made i...2023-03-09T12:39:28+01:00Spyros ArgyropoulosInvestigate whether the comment from mcgensvc in the notify job can be made in a way that needs resolvingSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/204Apply basic tests also to fragments included from top jO2023-12-20T18:58:13+01:00Spyros ArgyropoulosApply basic tests also to fragments included from top jOVia check_jo_content probablyVia check_jo_content probablySpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/200Failures on grid coming from treatment of runArgs.jobConfig not caught in CI2023-02-02T07:45:25+01:00Spyros ArgyropoulosFailures on grid coming from treatment of runArgs.jobConfig not caught in CIOriginal file: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/9938e84d065b3b479dd57e063889896daa7ff9e7/521xxx/521163/MadGraphControl_TRSM_HHH.py#L21
Original MR: !2251
Pipeline passed: https://gitlab.cern.ch/atlas-physic...Original file: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/9938e84d065b3b479dd57e063889896daa7ff9e7/521xxx/521163/MadGraphControl_TRSM_HHH.py#L21
Original MR: !2251
Pipeline passed: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/5008939
https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/9938e84d065b3b479dd57e063889896daa7ff9e7/521xxx/521163/MadGraphControl_TRSM_HHH.py#L21
This then failed on the grid: see ATLMCPROD-10348 example log: https://bigpanda.cern.ch//media/filebrowser/a8f96442-63a3-4574-aee8-53704fce19da/mc15_13TeV/tarball_PandaJob_5732336628_SiGNET/log.generate
Fix in: !2288
New file in: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/521xxx/521163/MadGraphControl_TRSM_HHH.py
Offending line seems to be:
```
f_list = os.listdir(runArgs.jobConfig[0])
```
where `runArgs.jobConfig[0]` on the grid seems to evaluate to `521163` while on the CI it would evaluate to `../521163`. Not clear from which level `Gen_tf.py` runs on the grid.
@mborodin could you point me to the code that executes `Gen_tf.py` on the grid?Spyros ArgyropoulosSpyros Argyropoulos2023-02-05https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/197check_jo_consistency failed2022-12-19T16:20:55+01:00Yiming Abulaiticheck_jo_consistency failedHi,
When I commit a second time after fix something in Control file, the consistency check failed.
The consistency is checking some other files that is not a part of my commits (I am trying to register 518405-518446 range).
But job is fa...Hi,
When I commit a second time after fix something in Control file, the consistency check failed.
The consistency is checking some other files that is not a part of my commits (I am trying to register 518405-518446 range).
But job is failed due to some errors related to 421xxx/421100/..
So How can I fix this?
Cheers,
Ablet
Error part:
OK: No generator full name is found
Generators used: ['Py8', 'EG']
ERROR: file /builds/atlas-physics/pmg/mcjoboptions/scripts/../421xxx/421100/mc.Py8EG_A14NNPDF23LO_Ztautau.py contains includes pointing to MC15JobOptions
Failed Job
https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/26543765Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/194Notify changes assigns MR to wrong person2022-11-20T17:08:34+01:00Spyros ArgyropoulosNotify changes assigns MR to wrong personneed to assign to convenersneed to assign to convenersSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/193Turn off branch pipelines2023-01-03T08:22:29+01:00Spyros ArgyropoulosTurn off branch pipelinesIf someone opens a MR when a branch pipeline is still running 2 concurrent pipelines are created.
One will fail since the one that finishes first will push to the branch and then the last CI job will try to push to a branch that is beh...If someone opens a MR when a branch pipeline is still running 2 concurrent pipelines are created.
One will fail since the one that finishes first will push to the branch and then the last CI job will try to push to a branch that is behind.
![Screenshot_2022-11-17_at_16.36.11](/uploads/afe31bf16cbf3496ccb1bf6f2703d7ac/Screenshot_2022-11-17_at_16.36.11.png)
We should turn off all branch pipelines.Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/192setup_athena pipeline failing2022-11-17T10:18:51+01:00Spyros Argyropoulossetup_athena pipeline failingSee !2152
The branch pipeline succeeds: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/4772445
Merge request pipeline succeeds when `log.generate.short` is present: https://gitlab.cern.ch/atlas-physics/pmg/mcjobopti...See !2152
The branch pipeline succeeds: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/4772445
Merge request pipeline succeeds when `log.generate.short` is present: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/25883448
Merge request pipeline fails when `log.generate.short` is not present: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/25883547
Branch pipeline also fails when `log.generate.short` is not present: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/25883631Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/190Remove possibility to skip all pipelines2022-10-08T10:37:24+02:00Spyros ArgyropoulosRemove possibility to skip all pipelinesWe should remove the `[skip all]` option since it is abused with no reason.
Need to think how to redesign the pipeline to make this happen.We should remove the `[skip all]` option since it is abused with no reason.
Need to think how to redesign the pipeline to make this happen.Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/188Allow to skip Nfiles check in gridpack2022-09-06T20:27:53+02:00Spyros ArgyropoulosAllow to skip Nfiles check in gridpackThe following discussion from !2014 should be addressed:
- [ ] @narayan started a [discussion](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2014#note_5975654): (+3 comments)
> Hi @sargyrop
>
> S...The following discussion from !2014 should be addressed:
- [ ] @narayan started a [discussion](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2014#note_5975654): (+3 comments)
> Hi @sargyrop
>
> Shall I do ``[skip Athena]`` in order to get this merged ?
>
> Cheers
> RohinSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/186Automatically merging MR from pipeline2022-08-25T09:35:17+02:00Spyros ArgyropoulosAutomatically merging MR from pipelineWhen running `merge_request_api.sh -m` from the pipeline we get a method not allowed because the pipeline is still running.
Need to fix this in order to enable an automatic merging - perhaps turn it into a "merge when pipeline succeeds...When running `merge_request_api.sh -m` from the pipeline we get a method not allowed because the pipeline is still running.
Need to fix this in order to enable an automatic merging - perhaps turn it into a "merge when pipeline succeeds"
See !2001Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/185Rebasing branching for automatically created MR when merging2024-02-18T07:24:20+01:00Spyros ArgyropoulosRebasing branching for automatically created MR when mergingWhen trying to merge automatically created MR we can get
```
./scripts/merge_request_api.sh -m
MR: 1993 - approvals left: 0
Merging 1993
{"message":"Branch cannot be merged"}
```
when previous MRs were merged in between.
One would have...When trying to merge automatically created MR we can get
```
./scripts/merge_request_api.sh -m
MR: 1993 - approvals left: 0
Merging 1993
{"message":"Branch cannot be merged"}
```
when previous MRs were merged in between.
One would have to rebase:
![Screenshot_2022-08-23_at_09.34.00](/uploads/d2d8219eaf65ec850b6169a63c62b2c8/Screenshot_2022-08-23_at_09.34.00.png)
from the CI which will launch another pipeline.
Need to see how to treat this in the pipeline.Spyros ArgyropoulosSpyros Argyropoulos