MC Job Options issueshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues2019-09-05T18:29:04+02:00https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/27Rename jO to remove date and fix CI accordingly2019-09-05T18:29:04+02:00Spyros ArgyropoulosRename jO to remove date and fix CI accordinglyNeed to move from `mc[0-9][0-9].` to `mc.`Need to move from `mc[0-9][0-9].` to `mc.`Spyros ArgyropoulosSpyros Argyropoulos2019-08-31https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/50Bug: `run_athena` job failing because of `check_jo_consistency` checks2019-11-23T15:49:20+01:00Spyros ArgyropoulosBug: `run_athena` job failing because of `check_jo_consistency` checksWhen running in CI `run_athena` gives the following:
```
18:39:53 Shortened traceback (most recent user call last):
18:39:53 File "/cvmfs/atlas.cern.ch/repo/sw/software/21.6/AthGeneration/21.6.13/InstallArea/x86_64-slc6-gcc62-opt/jobO...When running in CI `run_athena` gives the following:
```
18:39:53 Shortened traceback (most recent user call last):
18:39:53 File "/cvmfs/atlas.cern.ch/repo/sw/software/21.6/AthGeneration/21.6.13/InstallArea/x86_64-slc6-gcc62-opt/jobOptions/EvgenJobTransforms/skel.GENtoEVGEN.py", line 246, in <module>
18:39:53 include(check_jofiles)
18:39:53 File "/cvmfs/atlas.cern.ch/repo/sw/Generators/MC16JobOptions/scripts/check_jo_consistency.py", line 128, in <module>
18:39:53 main()
18:39:53 File "/cvmfs/atlas.cern.ch/repo/sw/Generators/MC16JobOptions/scripts/check_jo_consistency.py", line 123, in main
18:39:53 check_mc15includes(file)
18:39:53 File "/cvmfs/atlas.cern.ch/repo/sw/Generators/MC16JobOptions/scripts/check_jo_consistency.py", line 98, in check_mc15includes
18:39:53 with open(file) as f:
18:39:53 IOError: [Errno 2] No such file or directory: '421xxx/421305/mc.Sh_288_Wmunu_EnhLogPtV.py'
18:39:53 Py:Athena INFO leaving with code 8: "an unknown exception occurred"
```
This is because of /cvmfs/atlas.cern.ch/repo/sw/Generators/MC16JobOptions/scripts/check_jo_consistency.py L123.
`/cvmfs/atlas.cern.ch/repo/sw/Generators/MC16JobOptions/scripts/check_jo_consistency.py` returns in this case:
`421xxx/421999/mc.Sh_228_Wmunu_EnhLogPtV.py` so when running from `421xxx/tmp_421999` the python file can't locate the jo file.BetaSpyros ArgyropoulosChen Pengchen.peng@cern.chSpyros Argyropoulos2019-11-22https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/60Fix behaviour of pipelines when [skip ci] is used2020-01-15T13:14:35+01:00Spyros ArgyropoulosFix behaviour of pipelines when [skip ci] is usedApparently there has been a change in the gitlab policy where, if we enforce that pipelines must succeed there must always be a CI job that runs successfully, so we might have to implement something like https://docs.gitlab.com/ee/user/p...Apparently there has been a change in the gitlab policy where, if we enforce that pipelines must succeed there must always be a CI job that runs successfully, so we might have to implement something like https://docs.gitlab.com/ee/user/project/merge_requests/merge_when_pipeline_succeeds.html (see Limitations).
https://gitlab.cern.ch/help/user/project/merge_requests/merge_when_pipeline_succeeds.md#only-allow-merge-requests-to-be-merged-if-the-pipeline-succeeds
Associated gitlab issues describing the policy change:
https://gitlab.com/gitlab-org/gitlab/issues/14791
https://gitlab.com/gitlab-org/gitlab-foss/issues/66271
Affects !180 see also !184BetaSpyros ArgyropoulosSpyros Argyropoulos2020-01-17https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/76Add dat files in DSID directories in whitelist2020-02-21T10:51:10+01:00Spyros ArgyropoulosAdd dat files in DSID directories in whitelistShould add `*.dat` in whitelistShould add `*.dat` in whitelistS1.2020Spyros ArgyropoulosSpyros Argyropoulos2020-02-15https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/79Recursive extraction of GRID links2020-02-24T10:11:18+01:00Spyros ArgyropoulosRecursive extraction of GRID linksThis is causing the failure in !256.
It seems that the scripts are for some reason not using enough steps to resolve
```
950xxx/950031/mc_13TeV.Sh_228_ttbar_AllHadronic_EnhMaxHTavrgTopPT.GRID.tar.gz -> ../../700xxx/700050/mc_13TeV.Sh_2...This is causing the failure in !256.
It seems that the scripts are for some reason not using enough steps to resolve
```
950xxx/950031/mc_13TeV.Sh_228_ttbar_AllHadronic_EnhMaxHTavrgTopPT.GRID.tar.gz -> ../../700xxx/700050/mc_13TeV.Sh_228_ttbar_AllHadronic_EnhMaxHTavrgTopPT.GRID.tar.gz
```
back to
```
/eos/user/c/cgutscho/mc/700047/mc_13TeV.Sh_228_ttbar_AllHadronic_EnhMaxHTavrgTopPT.GRID.tar.gz
```
By the way @cgutscho @fsiegert isn't this workflow problematic? You have multiple files pointing to `/eos/user/c/cgutscho/mc/700047/mc_13TeV.Sh_228_ttbar_AllHadronic_EnhMaxHTavrgTopPT.GRID.tar.gz`, which has already been transferred to cvmfs, so in principle Chris can decide to remove this file from his eos area and CI again would fail.S1.2020Spyros ArgyropoulosSpyros Argyropoulos2020-02-22https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/78commit script broken2020-02-22T16:06:55+01:00Christian Gutschowcommit script brokenLook like the recent MR !252 broke the commit script, since it's doesn't accept JOs and gridpacks apparently:
```
Checking jO consistency and DSID ranges ...
950xxx/950031/mc.Sh_228_ttbar_dilepton_FusingFragFix_valid.py in correct DSI...Look like the recent MR !252 broke the commit script, since it's doesn't accept JOs and gridpacks apparently:
```
Checking jO consistency and DSID ranges ...
950xxx/950031/mc.Sh_228_ttbar_dilepton_FusingFragFix_valid.py in correct DSID range
New DSID directory: 950xxx/950031 ...
OK: log.generate file found.
OK: log.generate file contains no errors
OK: CI job expected to last less than 1h - time estimate: 0.05 hours
Will now add files to git commit
File: log.generate cannot be added to the commit. Skipping.
File: log.generate.short cannot be added to the commit. Skipping.
File: mc_13TeV.Sh_228_ttbar_AllHadronic_EnhMaxHTavrgTopPT.GRID.tar.gz cannot be added to the commit. Skipping.
File: mc.Sh_228_ttbar_dilepton_FusingFragFix_valid.py cannot be added to the commit. Skipping.
Added: Sherpa_i
```
This was found in !256.S1.2020Spyros ArgyropoulosSpyros Argyropoulos2020-02-22https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/80Improve following of recursive links in eos and run_athena CI jobs2020-03-01T09:26:02+01:00Spyros ArgyropoulosImprove following of recursive links in eos and run_athena CI jobsSuggestion from Frank: use `readlink -f`
Need to see if this is accessible in the CI bash version or perhaps find a bash version where it is (if it's small enough).Suggestion from Frank: use `readlink -f`
Need to see if this is accessible in the CI bash version or perhaps find a bash version where it is (if it's small enough).S1.2020Spyros ArgyropoulosSpyros Argyropoulos2020-03-01https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/91Commit script: block usage of DSIDs that are already used in any remote branch2020-03-16T13:55:42+01:00Spyros ArgyropoulosCommit script: block usage of DSIDs that are already used in any remote branchCurrently the commit script only checks that a DSID is not used in remote branches **only if the DSID is outside the allowed range**.
We should extend this to cover all DSIDs, so that users who try to assign DSIDs themselves do not cr...Currently the commit script only checks that a DSID is not used in remote branches **only if the DSID is outside the allowed range**.
We should extend this to cover all DSIDs, so that users who try to assign DSIDs themselves do not create problems with other MRs.S1.2020Spyros ArgyropoulosSpyros Argyropoulos2020-03-15https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/99Throw error in CI if no `evgenConfig.nEventsPerJob` is used in the file2020-04-08T10:51:29+02:00Spyros ArgyropoulosThrow error in CI if no `evgenConfig.nEventsPerJob` is used in the filePerhaps better to incorporate into #98Perhaps better to incorporate into #98S1.2020Spyros ArgyropoulosSpyros Argyropoulos2020-04-05https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/105int conversion of a string "nevents" that contains a float2020-04-29T21:17:33+02:00Xiaohu Sunint conversion of a string "nevents" that contains a floatQuite often people define nevents by multiplying a bunch of numbers (safe margin, truth efficiency etc.), then nevents is a float. The log file would contain
20:49:39 Py:MadGraphUtils INFO Setting nevents = 11000.0.
where "1100.0" ...Quite often people define nevents by multiplying a bunch of numbers (safe margin, truth efficiency etc.), then nevents is a float. The log file would contain
20:49:39 Py:MadGraphUtils INFO Setting nevents = 11000.0.
where "1100.0" is picked by logParser as a string.
Then in the check script
https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/scripts/logParser.py#L271
neventsMG=int(generatorDict['nevents'][0])
will crash, as int("11000.0") would not work.
ValueError: invalid literal for int() with base 10
Would this be fixed? Thanks!
Best,
Xiaohu2020-04-30https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/109logParser fails in CI when run on MadGraph due to nevents check2020-05-17T14:24:09+02:00Spyros ArgyropouloslogParser fails in CI when run on MadGraph due to nevents checkAs seen in !412 when running a jO with:
```
evgenConfig.nEventsPerJob = 10000
nevents = runArgs.maxEvents1.2 if runArgs.maxEvents>0 else 1.1evgenConfig.nEventsPerJob
```
`logParser` fails with
```
ERROR: Increase nevents to be gener...As seen in !412 when running a jO with:
```
evgenConfig.nEventsPerJob = 10000
nevents = runArgs.maxEvents1.2 if runArgs.maxEvents>0 else 1.1evgenConfig.nEventsPerJob
```
`logParser` fails with
```
ERROR: Increase nevents to be generated in MG from 120 to 11000
```S1.2020Spyros ArgyropoulosSpyros Argyropoulos2020-05-16https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/120Allow runArgs to be referred to in JOs but not to be overwritten by JOs2020-08-22T13:08:09+02:00Christian GutschowAllow runArgs to be referred to in JOs but not to be overwritten by JOsSee !631 for an example.See !631 for an example.S2.2020Spyros ArgyropoulosSpyros Argyropoulos2020-08-14https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/122Bug: handling of jobs with external LHE file in logParser step2020-09-06T13:46:23+02:00Spyros ArgyropoulosBug: handling of jobs with external LHE file in logParser stepWhen external LHE files are used `log.generate.short` is added to the commit but `run_athena` just skips the job without producing any `log.generate_ci` file. Then the `check_logParser` job thinks this is a bug because if `log.generate.s...When external LHE files are used `log.generate.short` is added to the commit but `run_athena` just skips the job without producing any `log.generate_ci` file. Then the `check_logParser` job thinks this is a bug because if `log.generate.short` is present `log.generate_ci` should also be present as well at this point in the CI and complains see !652S2.2020Spyros ArgyropoulosSpyros Argyropoulos2020-09-04https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/144Pipelines failing when only links are included?2021-06-21T16:50:31+02:00Spyros ArgyropoulosPipelines failing when only links are included?The following discussion from !1225 should be addressed:
- [ ] @jshahini started a [discussion](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1225#note_4588898): (+1 comment)
> Hi @cgutscho
>
> I...The following discussion from !1225 should be addressed:
- [ ] @jshahini started a [discussion](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1225#note_4588898): (+1 comment)
> Hi @cgutscho
>
> Indeed it is a duplicate, but this is by design in order to clear the CI. To give some context, these JOs are for a SUSY grid expansion.
>
> I originally tried to upload everything using only symlinks to that control file, but the CI pipelines were failing, claiming that the jobs couldn't find ```MadGraphControl_SimplifiedModel_GG_directRPVLQD.py```
>
> So I duplicated the control file you pointed to and included it in this MR so that the pipelines would succeed. After the MR gets accepted, I was going to make another one where I change all the control files to be symlinks to ```/502xxx/502416/MadGraphControl_SimplifiedModel_GG_directRPVLQD.py```. That way, there would be no duplicated control files floating around.
>
> I realize this is remarkably convoluted, so I'm more than happy to hear other ideas about preparing the JOs for grid expansions in R21.
>
> Cheers,
> Jeff
Failed pipeline: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/2741834
![Screenshot_2021-06-21_at_14.50.38](/uploads/1b1ebf50941d6c15803a23b2ad2bcd32/Screenshot_2021-06-21_at_14.50.38.png)S1.2021Spyros ArgyropoulosSpyros Argyropoulos2021-06-27https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/155MR not being linked on JIRAs2021-12-03T14:57:38+01:00Matthew GignacMR not being linked on JIRAsIn some recent requests, it was noticed that the MRs are not being linked on JIRA. For example see: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1510In some recent requests, it was noticed that the MRs are not being linked on JIRA. For example see: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/1510Spyros ArgyropoulosSpyros Argyropoulos2021-12-05https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/156commit_new_dsid.sh replace correct symbolic links2022-02-20T19:39:51+01:00Yiming Abulaiticommit_new_dsid.sh replace correct symbolic linksDear,
The commit_new_dsid.sh script replaces the DSID path in the symbolic event if the symbolic link is correct.
for example, my symbolic link is "../../510xxx/510250/file". When the script copy 100xx/* to DSID directory the "../../510...Dear,
The commit_new_dsid.sh script replaces the DSID path in the symbolic event if the symbolic link is correct.
for example, my symbolic link is "../../510xxx/510250/file". When the script copy 100xx/* to DSID directory the "../../510xxx/510250/" is replaced by the first new DSID (for example "../../511xxx/511424/").
Is it possible to let commit_new_dsid.sh keep the symbolic links when it is in 500xx-999xx range?
Cheers,
AbletSpyros ArgyropoulosSpyros Argyropoulos2022-02-20https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/158Handle purple list in logParser2022-05-05T16:15:51+02:00Spyros ArgyropoulosHandle purple list in logParserTBD if this is something that we can catch and report e.g. in the parser
See !1673TBD if this is something that we can catch and report e.g. in the parser
See !1673Spyros ArgyropoulosSpyros Argyropoulos2022-04-01https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/166Add checks for python2/3 compatibility of jO2022-04-21T17:21:24+02:00Spyros ArgyropoulosAdd checks for python2/3 compatibility of jOan example DSID is 830099: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/830xxx/830099/mc.H7EG_jetjet_72_Cluster_JZ1.py
R21: 21.6.85
R22: You can try 22.6.13 (later releases have issues with EvtGen_i — should be ...an example DSID is 830099: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/830xxx/830099/mc.H7EG_jetjet_72_Cluster_JZ1.py
R21: 21.6.85
R22: You can try 22.6.13 (later releases have issues with EvtGen_i — should be fixed soon).Spyros ArgyropoulosSpyros Argyropoulos2022-04-25https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/200Failures on grid coming from treatment of runArgs.jobConfig not caught in CI2023-02-02T07:45:25+01:00Spyros ArgyropoulosFailures on grid coming from treatment of runArgs.jobConfig not caught in CIOriginal file: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/9938e84d065b3b479dd57e063889896daa7ff9e7/521xxx/521163/MadGraphControl_TRSM_HHH.py#L21
Original MR: !2251
Pipeline passed: https://gitlab.cern.ch/atlas-physic...Original file: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/9938e84d065b3b479dd57e063889896daa7ff9e7/521xxx/521163/MadGraphControl_TRSM_HHH.py#L21
Original MR: !2251
Pipeline passed: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/5008939
https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/9938e84d065b3b479dd57e063889896daa7ff9e7/521xxx/521163/MadGraphControl_TRSM_HHH.py#L21
This then failed on the grid: see ATLMCPROD-10348 example log: https://bigpanda.cern.ch//media/filebrowser/a8f96442-63a3-4574-aee8-53704fce19da/mc15_13TeV/tarball_PandaJob_5732336628_SiGNET/log.generate
Fix in: !2288
New file in: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/521xxx/521163/MadGraphControl_TRSM_HHH.py
Offending line seems to be:
```
f_list = os.listdir(runArgs.jobConfig[0])
```
where `runArgs.jobConfig[0]` on the grid seems to evaluate to `521163` while on the CI it would evaluate to `../521163`. Not clear from which level `Gen_tf.py` runs on the grid.
@mborodin could you point me to the code that executes `Gen_tf.py` on the grid?Spyros ArgyropoulosSpyros Argyropoulos2023-02-05https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/issues/225logParser failed due to missing platform info2024-02-01T14:46:57+01:00Yang LiulogParser failed due to missing platform infoHi @sargyrop , as we discussed in [Fixing automatic determination of release for CI runs (!2861) · Merge requests · atlas-physics / pmg / MC Job Options · GitLab (cern.ch)](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_re...Hi @sargyrop , as we discussed in [Fixing automatic determination of release for CI runs (!2861) · Merge requests · atlas-physics / pmg / MC Job Options · GitLab (cern.ch)](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2861). It seems the added line to extract the platform info will cause problem for some of the jobs.
[Here](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/6821117) is one example.
Many thanks for your time to help.
Cheers
Yang