Skip to content

GitLab

Closed
Created by Jeff Shahinian@jshahiniDeveloper

check_unique_controlFile.sh fails when it shouldn't?

check_unique_controlFile.sh is apparently a new part of the CI. I noticed that it fails even when given symlinks. For example, when uploading JOs (with symlinks to one control file) that look like this:

$ ls -a *
100001:
myJO_1.py
myControlFile.py

100002:
myJO_2.py
myControlFile.py -> ../100001/myControlFile.py

The CI job fails and recommends that you use symlinks (even if you already are):

ERROR: Duplicate file(s) found:
./100xxx/100001/myControlFile.py
If the files have exactly the same content, please only keep one physical file replacing the rest with symbolic links.
If the files have differences consider renaming the files that you added.
You can check for differences with diff -w file1 file2

Perhaps we need to add -type f to this line as well? Here's an example of a failing CI job:

https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/13818890

Tagging @sargyrop

Best,

Jeff