MC Job Options merge requestshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests2019-08-26T09:46:51+02:00https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/22Resolve "check_added_files needs to be less strict"2019-08-26T09:46:51+02:00Frank SiegertResolve "check_added_files needs to be less strict"Closes #26Closes #26Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/24[skip athena] add new jobs for production tests2019-08-26T10:53:33+02:00Ewelina Maria Lobodzinska[skip athena] add new jobs for production testsadd three tests for production systemadd three tests for production systemhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/23add new tests [skip athena][skip ci]2019-08-26T11:38:56+02:00Frank Siegertadd new tests [skip athena][skip ci]This replaces (and hopefully fixes) !21This replaces (and hopefully fixes) !21Ewelina Maria LobodzinskaEwelina Maria Lobodzinskahttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/27[skip ci] Update Py8EG_A2MSTW2008LO_minbias_inelastic_high.py2019-09-03T11:31:08+02:00Ewelina Maria Lobodzinska[skip ci] Update Py8EG_A2MSTW2008LO_minbias_inelastic_high.pyhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/26Update mc16.Py8EG_A2MSTW2008LO_minbias_inelastic_high.py2019-09-03T11:31:44+02:00Ewelina Maria LobodzinskaUpdate mc16.Py8EG_A2MSTW2008LO_minbias_inelastic_high.pycorrect JOs because the FindJets syntax was changed [skip ci]correct JOs because the FindJets syntax was changed [skip ci]https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/28[skip ci] Update mc.Py8EG_A2MSTW2008LO_minbias_inelastic_high.py to correct t...2019-09-03T12:03:42+02:00Ewelina Maria Lobodzinska[skip ci] Update mc.Py8EG_A2MSTW2008LO_minbias_inelastic_high.py to correct the Findjets syntaxhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/29Add Generator List file and update checkconsistency function2019-09-05T14:25:21+02:00Chen Pengchen.peng@cern.chAdd Generator List file and update checkconsistency functionSpyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/25Changing naming conventions of jO files, removing year [skip ci]2019-09-05T18:29:04+02:00Spyros ArgyropoulosChanging naming conventions of jO files, removing year [skip ci]As discussed in the last meeting I remove the year from the jO files and also the scripts.
**NB**: the GRID files are still called `mc16_13TeV.*.GRID.tar.gz`
Closes #27 As discussed in the last meeting I remove the year from the jO files and also the scripts.
**NB**: the GRID files are still called `mc16_13TeV.*.GRID.tar.gz`
Closes #27 Frank SiegertFrank Siegerthttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/30Patch 62019-09-06T15:46:32+02:00Ewelina Maria LobodzinskaPatch 6add JOs for multiinput runningadd JOs for multiinput runninghttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/31Patch 72019-09-06T15:51:21+02:00Ewelina Maria LobodzinskaPatch 7add JOs for tesing of MG running without EVNT outputadd JOs for tesing of MG running without EVNT outputhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/32Patch 92019-09-06T15:56:51+02:00Ewelina Maria LobodzinskaPatch 9add JOs for ART test with MG producing only LHE (without EVNT)add JOs for ART test with MG producing only LHE (without EVNT)https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/14Updated documentation and fixes for multiple DSIDs2019-09-07T11:55:16+02:00Spyros ArgyropoulosUpdated documentation and fixes for multiple DSIDsMore info will be added - just to keep track of added items for now.
* [x] Added checklist for approvers in `.gitlab/merge_request_templates/new_jO.md` also in `README` (Closes #19)
* [x] Updated instructions for how to upload new jO...More info will be added - just to keep track of added items for now.
* [x] Added checklist for approvers in `.gitlab/merge_request_templates/new_jO.md` also in `README` (Closes #19)
* [x] Updated instructions for how to upload new jO using the automatic script (Closes #18)
* [x] Added `git push -o ci.skip origin` in automatic script to skip the pipelines when the branch is first created
* [x] Pick up Frank's change for `check_added_files`
* [x] Skip athena jobs for directories where there is no `log.generate.short` (Closes #17)
* [x] Use `Gen_tf` instead of `Generate_tf` (Closes #16)
* [x] Check that there are no explicit "MC15JobOptions/..." includes
* [x] Change `check_modified_files` to fix #25 Frank SiegertFrank Siegerthttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/33Modify README [skip modfiles]2019-09-07T18:17:38+02:00Spyros ArgyropoulosModify README [skip modfiles]Small change to make it clear for developers that when squashing commits they need to be careful about picking up the correct message or specifying by hand a correct CI tag in the squashed commit messageSmall change to make it clear for developers that when squashing commits they need to be careful about picking up the correct message or specifying by hand a correct CI tag in the squashed commit messageFrank SiegertFrank Siegerthttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/34Moving 422124 to 422xxx and adding protection against such misplaced director...2019-09-10T10:31:24+02:00Spyros ArgyropoulosMoving 422124 to 422xxx and adding protection against such misplaced directories [skip ci]I think 422124 was by mistake put in 421xxx.
Gen_tf crashes in any case.
I have also added a check against this:
```
python scripts/check_jo_consistency.py
===> Checking jobOption consistency...
ERROR: modified jO lives in...I think 422124 was by mistake put in 421xxx.
Gen_tf crashes in any case.
I have also added a check against this:
```
python scripts/check_jo_consistency.py
===> Checking jobOption consistency...
ERROR: modified jO lives in directory 421xxx/422124. Need to put it in 422xxx/422124
```Ewelina Maria LobodzinskaEwelina Maria Lobodzinskahttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/35Changing the generate dictionary in logParser and adding check discussed in #...2019-09-12T11:28:32+02:00Spyros ArgyropoulosChanging the generate dictionary in logParser and adding check discussed in #21 [skip modfiles]**Changing the generate dictionary which would make logParser crash for 21.6.10 and later**
This would create a crash if logParser was run for release >= 21.6.10, since the old dictionary was using `Py:Generate`, which would now not b...**Changing the generate dictionary which would make logParser crash for 21.6.10 and later**
This would create a crash if logParser was run for release >= 21.6.10, since the old dictionary was using `Py:Generate`, which would now not be found.
**Adding check to see if Gen_tf is run #21**
The test is not complete because of the problem discussed inn #21.
It will take effect from 21.6.11 onwardsFrank SiegertFrank Siegerthttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/36Find remote branch name in commit script #32 [skip modfiles]2019-09-13T14:39:36+02:00Spyros ArgyropoulosFind remote branch name in commit script #32 [skip modfiles]Some changes in commit script to
* find remote name (Closes #32)
* improve handling of branches to be created
* fixing bug in `checkWhiteList` (missing brackets)Some changes in commit script to
* find remote name (Closes #32)
* improve handling of branches to be created
* fixing bug in `checkWhiteList` (missing brackets)Frank SiegertFrank Siegerthttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/38add 421126 for ART test2019-09-13T14:46:02+02:00Ewelina Maria Lobodzinskaadd 421126 for ART test[skip ci] add JOs for ART test with 2 jet filters[skip ci] add JOs for ART test with 2 jet filtershttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/39Update Twiki link in MR template [skip modfiles]2019-09-14T12:38:18+02:00Frank SiegertUpdate Twiki link in MR template [skip modfiles][skip ci][skip ci]Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/37Add n files per job in logParser [skip modfiles]2019-09-14T20:35:15+02:00Spyros ArgyropoulosAdd n files per job in logParser [skip modfiles]Adding check for nFilesPerJob < 100 in logParser
Closes #28Adding check for nFilesPerJob < 100 in logParser
Closes #28Frank SiegertFrank Siegerthttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/40Only push from check_logParser if log.generate.short was removed [skip modfiles]2019-09-15T08:43:39+02:00Spyros ArgyropoulosOnly push from check_logParser if log.generate.short was removed [skip modfiles]This should fix the failed job in [5469382](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/5469382)This should fix the failed job in [5469382](https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/5469382)Frank SiegertFrank Siegert