MC Job Options merge requestshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests2024-02-25T07:24:22+01:00https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2926Benchmark points for SUSY Run3 displaced track analysis2024-02-25T07:24:22+01:00Yang LiuBenchmark points for SUSY Run3 displaced track analysisMake sure that all the items in the checklists are duly followed:\
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
ATLMCPROD-11021
## Checklist for approval
This...Make sure that all the items in the checklists are duly followed:\
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
ATLMCPROD-11021
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).\
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [x] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [ ] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2925HH>bbll JOs for trigger studies2024-02-23T20:12:25+01:00Marisilvia DonadelliHH>bbll JOs for trigger studiesMake sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-ATLMCPROD-11081
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [x] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [ ] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [ ] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.Marisilvia DonadelliMarisilvia Donadellihttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2924gammajet herwig part 22024-02-23T22:37:33+01:00Haifeng Ligammajet herwig part 2Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-10976
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [x] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [x] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2923JOs for tta(bb) H7 signal2024-02-23T17:59:32+01:00Marisilvia DonadelliJOs for tta(bb) H7 signalMake sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-11072
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [ ] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [x] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.Marisilvia DonadelliMarisilvia Donadellihttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2922validation ggH samples for matching2024-02-23T14:31:56+01:00Ana Rosario Cueto Gomezvalidation ggH samples for matchingMake sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-11085
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [x] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [ ] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2921gammajet herwig part 12024-02-23T13:17:32+01:00Haifeng Ligammajet herwig part 1Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-10976
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [x] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [x] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2920Cleaning up keywords not accepted in rel23.6 [skip modfiles]2024-02-23T11:27:50+01:00Marisilvia DonadelliCleaning up keywords not accepted in rel23.6 [skip modfiles]## Description of bug
bbll, bbtautau, bbZZ and bbWW keywords not recognised in rel 23.6.24, being used for HH>bbll trigger studies.
## Changes introduced
The above-mentioned keywords were removed.
## Tests
Validation plots:
http...## Description of bug
bbll, bbtautau, bbZZ and bbWW keywords not recognised in rel 23.6.24, being used for HH>bbll trigger studies.
## Changes introduced
The above-mentioned keywords were removed.
## Tests
Validation plots:
https://docs.google.com/presentation/d/1ykNIu1PBfyXuYKELGWFvhFCzDjfdZTtTjP4igu7g1oY/edit#slide=id.g2bb3d6bb213_0_0
JOs and log generate files:
https://cernbox.cern.ch/files/link/public/Nhd92AuYl2iLSnb?tiles-size=1&items-per-page=100&view-mode=resource-table
## Issues resolved
Closes #Dominic HirschbuehlAna Rosario Cueto GomezDominic Hirschbuehlhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2919Herwig Lund2024-02-22T17:14:39+01:00Haifeng LiHerwig LundMake sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-10870
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [ ] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [ ] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [ ] The request has been approved by the PA/CP group
- [ ] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [ ] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [ ] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [ ] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [ ] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [ ] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [ ] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2918put back xAODMETFilter for 602765-79 and correct test JOs for xAODFilters2024-02-23T12:45:47+01:00Ewelina Maria Lobodzinskaput back xAODMETFilter for 602765-79 and correct test JOs for xAODFiltersput back xAODMETFilter for 602765-79 and correct test JOs (from the 421xxx directory) for xAODFiltersput back xAODMETFilter for 602765-79 and correct test JOs (from the 421xxx directory) for xAODFiltersDominic HirschbuehlAna Rosario Cueto GomezDominic Hirschbuehlhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2917HH>bbyy JOs for trigger studies ATLMCPROD-108412024-02-22T15:08:28+01:00Marisilvia DonadelliHH>bbyy JOs for trigger studies ATLMCPROD-10841Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-10841
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [x] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [ ] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.Marisilvia DonadelliMarisilvia Donadellihttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2916Wprime2024-02-21T19:16:12+01:00Haifeng LiWprimeMake sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-10983
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [ ] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [ ] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2915Use NLO PDF for cLFV MGPy8 samples2024-02-22T12:31:13+01:00Katharina VossUse NLO PDF for cLFV MGPy8 samples## Description of bug
LO PDF set instead of NLO PDF set was used
## Changes introduced
Changing `NNPDF31_lo_as_0118` (`315000`) to `NNPDF31_nlo_as_0118` (`303400`)
## Tests
The newly uploaded job options and log.generate files were ...## Description of bug
LO PDF set instead of NLO PDF set was used
## Changes introduced
Changing `NNPDF31_lo_as_0118` (`315000`) to `NNPDF31_nlo_as_0118` (`303400`)
## Tests
The newly uploaded job options and log.generate files were tested with the commit_new_dsid script using the --dry-run command line option
## Issues resolved
Closes #Dominic HirschbuehlAna Rosario Cueto GomezDominic Hirschbuehlhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2914Wprime2024-02-21T16:42:29+01:00Haifeng LiWprimeMake sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-10983
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [ ] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [ ] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [ ] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [ ] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [ ] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [ ] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [ ] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2913Relax check for saveProcDir for reshowering jO2024-02-21T14:55:47+01:00Spyros ArgyropoulosRelax check for saveProcDir for reshowering jO## Description of bug
Not really a bug but when reshowering jO were used (MG not run) test introduced in !2862 was failing while no `saveProcDir=True` would be found in the jO.
## Changes introduced
Do not run MG checks if
```
19:01:...## Description of bug
Not really a bug but when reshowering jO were used (MG not run) test introduced in !2862 was failing while no `saveProcDir=True` would be found in the jO.
## Changes introduced
Do not run MG checks if
```
19:01:59 Py:MadGraphUtils INFO Setting nevents = 110
```
line is not present in log, which indicates that MG is not run.
## Tests
#### Before
![Screenshot_2024-02-21_at_14.52.50](/uploads/9cbdbf84f20b043778cd8cd2849aa537/Screenshot_2024-02-21_at_14.52.50.png)
#### After
![Screenshot_2024-02-21_at_14.52.20](/uploads/4aa62c379911ad83fcab98ee0d4e97fb/Screenshot_2024-02-21_at_14.52.20.png)
## Issues resolved
Closes #224Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2912Fixing check for xAOD filters2024-02-21T14:05:04+01:00Spyros ArgyropoulosFixing check for xAOD filters## Description of bug
The check introduced in !2857 and updated in !2910 is too strict.
Apparently the HepMC bug does not affect certain filters, in particular the MET ones and because of https://gitlab.cern.ch/atlas/athena/-/blob/rele...## Description of bug
The check introduced in !2857 and updated in !2910 is too strict.
Apparently the HepMC bug does not affect certain filters, in particular the MET ones and because of https://gitlab.cern.ch/atlas/athena/-/blob/release/23.6.12/Generators/GeneratorFilters/src/MissingEtFilter.cxx?ref_type=tags#L25 it is causing issues.
There are two solutions:
1. fine-tune more (done here, in particular excluding the MET filters and `CreatexAODSlimContainers.py` from the test)
2. get rid of the test completely
Ewelina was in favour of the 2nd option. @ancuetog @dhirsch should we go with the 2nd option instead?
## Changes introduced
## Tests
#### Before
![Screenshot_2024-02-21_at_11.22.26](/uploads/15f693c5db004dea6b8284f3d23b49ed/Screenshot_2024-02-21_at_11.22.26.png)
#### After
![Screenshot_2024-02-21_at_11.37.02](/uploads/19628a82fa2ec5dde59b09fa3e96ca5b/Screenshot_2024-02-21_at_11.37.02.png)
## Issues resolved
Closes #Dominic HirschbuehlAna Rosario Cueto GomezDominic Hirschbuehlhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2911SC4.2 LbyL jO2024-02-20T17:15:23+01:00Jan KretzschmarSC4.2 LbyL jOMake sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLHI-524
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [x] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [x] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2910Fine tune check for xAOD filters in rel23.6 to only exclude usage with HepMC32024-02-21T11:43:09+01:00Spyros ArgyropoulosFine tune check for xAOD filters in rel23.6 to only exclude usage with HepMC3## Changes introduced
Fine-tune check introduced in !2857 to only exclude usage of xAOD filters in rel23.6 that are using HepMC3. (HepMC2 is allowed)
## Tests
Works fine on a log provided by @silvinha
## Issues resolved
Closes ### Changes introduced
Fine-tune check introduced in !2857 to only exclude usage of xAOD filters in rel23.6 that are using HepMC3. (HepMC2 is allowed)
## Tests
Works fine on a log provided by @silvinha
## Issues resolved
Closes #Spyros ArgyropoulosSpyros Argyropouloshttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2909Run3 aMC@NLO ttZ samples2024-02-20T21:57:52+01:00Lucia KeszeghovaRun3 aMC@NLO ttZ samplesMake sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket n...Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.
## JIRA ticket
<!-- Fill the line below with the JIRA ticket number, e.g. ATLMCPROD-1234 -->
ATLMCPROD-10675
## Checklist for approval
This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.
- [x] I have followed the [guidelines in McSampleRequestProcedure](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/McSampleRequestProcedure)
- [x] I have provided the ATLMCPROD JIRA ticket where the request has been discussed
- [x] The request has been approved by the PA/CP group
- [x] The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
- [x] If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
- [x] CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
- [x] Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
- [x] Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
- [x] Check that the DSID range assigned is correct (500000-999999) and corresponds to [right generator block](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/PmgMcSoftware#DSID_blocks)
- [x] Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2908Add missing files for low mass long lived RPV Higgsino DSIDs with LQD coupling2024-02-28T15:59:13+01:00Yang LiuAdd missing files for low mass long lived RPV Higgsino DSIDs with LQD coupling## Description of bug
Missing file in 537548 and wrong file in 537549
## Changes introduced
Add missing files in 537548 and 537549.
Deleted wrong file in 537549
## Tests
## Issues resolved
Closes ### Description of bug
Missing file in 537548 and wrong file in 537549
## Changes introduced
Add missing files in 537548 and 537549.
Deleted wrong file in 537549
## Tests
## Issues resolved
Closes #Dominic HirschbuehlAna Rosario Cueto GomezDominic Hirschbuehlhttps://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/merge_requests/2907Fix recursive adding of files in DSID subdirectories in commit script2024-02-18T07:18:34+01:00Spyros ArgyropoulosFix recursive adding of files in DSID subdirectories in commit script## Description of bug
In !1588 the line
```bash
for file in $(find $dsiddir/* -not -type d); do
```
was replaced with
```python
for newfile in glob.glob(f'{dsiddir}/*', recursive = True):
```
which is not equivalent. The latter fails to...## Description of bug
In !1588 the line
```bash
for file in $(find $dsiddir/* -not -type d); do
```
was replaced with
```python
for newfile in glob.glob(f'{dsiddir}/*', recursive = True):
```
which is not equivalent. The latter fails to expand subdirectories and as a result if we have files in a structure like `DSID/Herwig7_i/SomeModule.py`, `SubModule.py` is not added to the commit.
## Changes introduced
Fix globbing pattern
## Tests
#### Before
![Screenshot_2024-02-18_at_07.11.32](/uploads/385d8e0d81cf44312e7fc9921a826665/Screenshot_2024-02-18_at_07.11.32.png)
#### After
![Screenshot_2024-02-18_at_07.11.20](/uploads/b4e61d9bfe7254dabd72f5a579533736/Screenshot_2024-02-18_at_07.11.20.png)
## Issues resolved
Closes #Spyros ArgyropoulosSpyros Argyropoulos