Skip to content

Fix bug when copying links pointing to eos

Spyros Argyropoulos requested to merge fixLinkCopy into master

Description of bug

When assigning DSIDs the commit script would do first a cp -a which would copy files and links.
For links a second pass was made in order to fix relative links and make them point to the correct (new) DSID which was being booked.
The bug is that this would also try to fix links pointing to eos and since the DSID directory of an eos file could not be extracted it would lead to an error:

ERROR: 500xxx/500336/mc_13TeV.MGPy8EG_A14NNPDF23LO_Wmunu3jets_FxFx.GRID.tar.gz is pointing to a file in the same DSID directory. Avoid the link and consider renaming the original file.

reported by @fgiuli

Changes introduced

Skip the second pass (link reassignement) when a link is pointing to eos

Tests

Running on directory from Francesco

./scripts/commit_new_dsid.sh -d=100002 -m='FxFX V+3jets inclusive samples' --nogit
INFO: will use following remote for pushing: origin
Will use branch: dsid_sargyrop_100002...
Will create new branch: dsid_sargyrop_100002
Checking jO consistency and DSID ranges ...
New DSID directory: 500xxx/500335 ...
	OK: log.generate file found.
	OK: log.generate file contains no errors
	OK: CI job expected to last less than 1h - time estimate: 0.12 hours
	Will now add files to git commit
		File: 500xxx/500335/log.generate cannot be added to the commit. Skipping.
		Will add: 500xxx/500335/log.generate.short
		Will add: 500xxx/500335/mc_13TeV.MGPy8EG_A14NNPDF23LO_Wenu3jets_FxFx.GRID.tar.gz
		Will add: 500xxx/500335/mc.MGPy8EG_A14NNPDF23LO_Wenu3jets_FxFx.py

Issues resolved

Closes #

Merge request reports