From 0a1ab521f716cce76fa805ea4a10a53ecbb5bcc7 Mon Sep 17 00:00:00 2001
From: Elemer Nagy <elemer.nagy@cern.ch>
Date: Tue, 27 Sep 2022 21:29:40 +0200
Subject: [PATCH] Removed DL1r variables from monitoring as required in
 ATR-26330 in the...

Removed DL1r variables from monitoring as required in ATR-26330 in the migration of the t0 b-jet trigger monitoring code (see ATR-20079)
---
 .../python/TrigBjetMonitorAlgorithm.py        | 87 -------------------
 .../src/TrigBjetMonitorAlgorithm.cxx          | 79 -----------------
 2 files changed, 166 deletions(-)

diff --git a/Trigger/TrigMonitoring/TrigBjetMonitoring/python/TrigBjetMonitorAlgorithm.py b/Trigger/TrigMonitoring/TrigBjetMonitoring/python/TrigBjetMonitorAlgorithm.py
index a58a26ed7d65..580d48fa33f9 100644
--- a/Trigger/TrigMonitoring/TrigBjetMonitoring/python/TrigBjetMonitorAlgorithm.py
+++ b/Trigger/TrigMonitoring/TrigBjetMonitoring/python/TrigBjetMonitorAlgorithm.py
@@ -456,37 +456,6 @@ def TrigBjetMonConfig(inputFlags):
       # b-tagging quantities
 
 
-            HistName = 'IP3D_pu_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='IP3D_pu probability distribution;IP3D_pu;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='IP3D_pu probability distribution;IP3D_pu;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
-            HistName = 'IP3D_pb_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='IP3D_pb probability distribution;IP3D_pb;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='IP3D_pb probability distribution;IP3D_pb;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
-            HistName = 'IP3D_pc_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='IP3D_pc probability distribution;IP3D_pc;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='IP3D_pc probability distribution;IP3D_pc;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
-            HistName = 'wIP3D_Rbu_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='LogLH IP3D_pb/IP3D_pu probability ratio distribution;LogLH IP3D_pb/IP3D_pu;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=-50.,xmax=50.)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='LogLH IP3D_pb/IP3D_pu probability ratio distribution;LogLH IP3D_pb/IP3D_pu;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=-50.,xmax=50.)
 
             HistName = 'xMVtx_tr_' + chain[2:]
             if chain[0:1] == "E" :
@@ -548,30 +517,6 @@ def TrigBjetMonConfig(inputFlags):
                                              path='Shifter/'+chain[2:],xbins=40,xmin=0.0,xmax=40.0)
 
 
-            HistName = 'RNNIP_pu_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of RNNIP_pu probability;RNNIP_pu;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of RNNIP_pu probability;RNNIP_pu;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
-            HistName = 'RNNIP_pc_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of RNNIP_pc probability;RNNIP_pc;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of RNNIP_pc probability;RNNIP_pc;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
-            HistName = 'RNNIP_pb_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of RNNIP_pb probability;RNNIP_pb;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of RNNIP_pb probability;RNNIP_pb;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
 
             HistName = 'DL1d_pu_tr_' + chain[2:]
             if chain[0:1] == "E" :
@@ -606,38 +551,6 @@ def TrigBjetMonConfig(inputFlags):
                                              path='Shifter/'+chain[2:],xbins=200,xmin=-50.,xmax=50.)
 
 
-            HistName = 'DL1r_pu_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of DL1r_pu probability;DL1r_pu;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of DL1r_pu probability;DL1r_pu;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
-            HistName = 'DL1r_pc_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of DL1r_pc probability;DL1r_pc;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of DL1r_pc probability;DL1r_pc;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
-            HistName = 'DL1r_pb_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of DL1r_pb probability;DL1r_pb;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of DL1r_pb probability;DL1r_pb;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=0.0,xmax=1.0)
-
-            HistName = 'DL1r_mv_tr_' + chain[2:]
-            if chain[0:1] == "E" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of DL1r_mv LLR;DL1r_mv;Events',
-                                             path='Expert/'+chain[2:],xbins=200,xmin=-50.,xmax=50.)
-            if chain[0:1] == "S" :
-                BjetMonGroup.defineHistogram(HistName, title='Distribution of DL1r_mv LLR;DL1r_mv;Events',
-                                             path='Shifter/'+chain[2:],xbins=200,xmin=-50.,xmax=50.)
-
 
             HistName = 'DIPSL_pu_tr_' + chain[2:]
             if chain[0:1] == "E" :
diff --git a/Trigger/TrigMonitoring/TrigBjetMonitoring/src/TrigBjetMonitorAlgorithm.cxx b/Trigger/TrigMonitoring/TrigBjetMonitoring/src/TrigBjetMonitorAlgorithm.cxx
index f17e09648313..9d7256ce2250 100644
--- a/Trigger/TrigMonitoring/TrigBjetMonitoring/src/TrigBjetMonitorAlgorithm.cxx
+++ b/Trigger/TrigMonitoring/TrigBjetMonitoring/src/TrigBjetMonitorAlgorithm.cxx
@@ -475,35 +475,6 @@ StatusCode TrigBjetMonitorAlgorithm::fillHistograms( const EventContext& ctx ) c
 	    ATH_CHECK( btaggingLinkInfo.isValid() ) ;
 	    const xAOD::BTagging* btag = *(btaggingLinkInfo.link);
 	    
-	    // IP3D variables
-	    NameH = "IP3D_pu_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto IP3D_pu = Monitored::Scalar<float>(NameH,0.0);
-	    IP3D_pu = btag->IP3D_pu();
-	    ATH_MSG_DEBUG("        IP3D_pu: " << IP3D_pu);
-	    fill("TrigBjetMonitor",IP3D_pu);
-	    
-	    NameH = "IP3D_pb_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto IP3D_pb = Monitored::Scalar<float>(NameH,0.0);
-	    IP3D_pb = btag->IP3D_pb();
-	    ATH_MSG_DEBUG("        IP3D_pb: " << IP3D_pb);
-	    fill("TrigBjetMonitor",IP3D_pb);
-	    
-	    NameH = "IP3D_pc_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto IP3D_pc = Monitored::Scalar<float>(NameH,0.0);
-	    IP3D_pc = btag->IP3D_pc();
-	    ATH_MSG_DEBUG("        IP3D_pc: " << IP3D_pc);
-	    fill("TrigBjetMonitor",IP3D_pc);
-	    
-	    // LogLH variables
-	    NameH = "wIP3D_Rbu_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto wIP3D = Monitored::Scalar<double>(NameH,0.0);
-	    btag->loglikelihoodratio("IP3D", wIP3D);
-	    ATH_MSG_DEBUG("        wIP3D: " << wIP3D);
-	    fill("TrigBjetMonitor",wIP3D);
 	    
 	    // SV1 variables (credit LZ)
 	    NameH = "xNVtx_tr_"+trigName;
@@ -560,28 +531,6 @@ StatusCode TrigBjetMonitorAlgorithm::fillHistograms( const EventContext& ctx ) c
 	    ATH_MSG_DEBUG("        jf_efrc: " << jf_efrc);
 	    fill("TrigBjetMonitor",jf_efrc);
 	    
-	    // Run-3 discriminators
-	    
-	    NameH = "RNNIP_pu_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto RNNIP_pu = Monitored::Scalar<double>(NameH,0.0);
-	    btag->pu("rnnip",RNNIP_pu);
-	    ATH_MSG_DEBUG("        RNNIP_pu: " << RNNIP_pu);
-	    fill("TrigBjetMonitor",RNNIP_pu);
-	    
-	    NameH = "RNNIP_pc_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto RNNIP_pc = Monitored::Scalar<double>(NameH,0.0);
-	    btag->pc("rnnip",RNNIP_pc);
-	    ATH_MSG_DEBUG("        RNNIP_pc: " << RNNIP_pc);
-	    fill("TrigBjetMonitor",RNNIP_pc);
-	    
-	    NameH = "RNNIP_pb_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto RNNIP_pb = Monitored::Scalar<double>(NameH,0.0);
-	    btag->pb("rnnip",RNNIP_pb);
-	    ATH_MSG_DEBUG("        RNNIP_pb: " << RNNIP_pb);
-	    fill("TrigBjetMonitor",RNNIP_pb);
 	    
 	    
 	    NameH = "DL1d_pu_tr_"+trigName;
@@ -613,34 +562,6 @@ StatusCode TrigBjetMonitorAlgorithm::fillHistograms( const EventContext& ctx ) c
 	    ATH_MSG_DEBUG("        DL1d_mv: " << DL1d_mv << " LLR: " << theLLR); 
 	    
 	    
-	    NameH = "DL1r_pu_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto DL1r_pu = Monitored::Scalar<double>(NameH,0.0);
-	    btag->pu("DL1r",DL1r_pu);
-	    ATH_MSG_DEBUG("        DL1r_pu: " << DL1r_pu);
-	    fill("TrigBjetMonitor",DL1r_pu);
-	    
-	    NameH = "DL1r_pc_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto DL1r_pc = Monitored::Scalar<double>(NameH,0.0);
-	    btag->pc("DL1r",DL1r_pc);
-	    ATH_MSG_DEBUG("        DL1r_pc: " << DL1r_pc);
-	    fill("TrigBjetMonitor",DL1r_pc);
-	    
-	    NameH = "DL1r_pb_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto DL1r_pb = Monitored::Scalar<double>(NameH,0.0);
-	    btag->pb("DL1r",DL1r_pb);
-	    ATH_MSG_DEBUG("        DL1r_pb: " << DL1r_pb);
-	    fill("TrigBjetMonitor",DL1r_pb);
-	    
-	    NameH = "DL1r_mv_tr_"+trigName;
-	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-	    auto DL1r_mv = Monitored::Scalar<double>(NameH,0.0);
-	    theLLR = LLR (DL1r_pu, DL1r_pc, DL1r_pb, DL1r_mv);
-	    if ( theLLR ) fill("TrigBjetMonitor",DL1r_mv);
-	    ATH_MSG_DEBUG("        DL1r_mv: " << DL1r_mv << " LLR: " << theLLR); 
-	    
 	    
 	    NameH = "DIPSL_pu_tr_"+trigName;
 	    ATH_MSG_DEBUG( " NameH: " << NameH  );
-- 
GitLab