From 2b561318ce7774f28c6332ca2f73f105d78c1ff6 Mon Sep 17 00:00:00 2001
From: scott snyder <snyder@bnl.gov>
Date: Wed, 6 Jan 2021 15:47:51 +0100
Subject: [PATCH] TrigInDetAnalysisUser: Fix clang warnings.
Pass large objects by const reference, not by value.
Implicit declaration of assignment is deprecated if there's an explicit
copy ctor. Make the copy ctor default instead.
---
.../TrigInDetAnalysisUser/Analysis/src/comparitor.cxx | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Trigger/TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/comparitor.cxx b/Trigger/TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/comparitor.cxx
index f250b9c910fc..01dbf04b9f5c 100644
--- a/Trigger/TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/comparitor.cxx
+++ b/Trigger/TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/comparitor.cxx
@@ -4,7 +4,7 @@
** @author mark sutton
** @date Fri 12 Oct 2012 13:39:05 BST
**
- ** Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+ ** Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
**/
@@ -197,9 +197,9 @@ public:
bands() { }
- bands( const bands& b ) : m_limits(b.m_limits), m_labels(b.m_labels) { }
+ bands( const bands& b ) = default;
- bands( std::vector<double> limits, std::vector<std::string> labels )
+ bands( const std::vector<double>& limits, const std::vector<std::string>& labels )
: m_limits(limits), m_labels(labels)
{ }
--
GitLab