From a198d119bc093611ebd6a6e9dbb666867c242692 Mon Sep 17 00:00:00 2001
From: scott snyder <sss@karma>
Date: Fri, 17 Sep 2021 17:34:36 -0400
Subject: [PATCH] TrkValTools: Capture return of getHolesOnTrack in a
 unique_ptr.

Good practice, and also needed for compatibility with upcoming debugging
changes to try to track down ATLASRECTS-6331.
---
 .../TrkValTools/src/MeasurementVectorNtupleTool.cxx           | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Tracking/TrkValidation/TrkValTools/src/MeasurementVectorNtupleTool.cxx b/Tracking/TrkValidation/TrkValTools/src/MeasurementVectorNtupleTool.cxx
index ba82392cce00..59bd35f50dc0 100644
--- a/Tracking/TrkValidation/TrkValTools/src/MeasurementVectorNtupleTool.cxx
+++ b/Tracking/TrkValidation/TrkValTools/src/MeasurementVectorNtupleTool.cxx
@@ -559,7 +559,7 @@ StatusCode Trk::MeasurementVectorNtupleTool::fillTrackData (
   //----------------------------------------------
   // do hole search if selected
   if (m_doHoleSearch) {
-    const DataVector<const Trk::TrackStateOnSurface>* holesOnTrack = m_holeSearchTool->getHolesOnTrack(track, track.info().particleHypothesis());
+    std::unique_ptr<const Trk::TrackStates> holesOnTrack (m_holeSearchTool->getHolesOnTrack(track, track.info().particleHypothesis()));
     // loop over holes
     if (!holesOnTrack) {
       msg(MSG::WARNING) << "Got no holes on track" << endmsg;
@@ -576,8 +576,6 @@ StatusCode Trk::MeasurementVectorNtupleTool::fillTrackData (
         msg(MSG::WARNING) << "info about TrackState (hole) could not be written to ntuple" << endmsg;
       }
     } // end loop on holes
-    delete holesOnTrack;
-    holesOnTrack = nullptr;
   }
 
   return StatusCode::SUCCESS;
-- 
GitLab