From c58d5c953b7d6c411018dc521fecde796390c01a Mon Sep 17 00:00:00 2001
From: Atlas-Software Librarian <Atlas-Software.Librarian@cern.ch>
Date: Fri, 8 Apr 2016 16:00:36 +0200
Subject: [PATCH] 'CMakeLists.txt' (PFODQA-00-00-10)
---
.../PFlowValidation/PFODQA/CMakeLists.txt | 28 +++++++++++++++++++
.../PFlow/PFlowValidation/PFODQA/Changelog | 4 +++
.../PFODQA/src/PhysValCluster.cxx | 1 +
.../PFlowValidation/PFODQA/src/PhysValPFO.cxx | 1 +
4 files changed, 34 insertions(+)
create mode 100644 Reconstruction/PFlow/PFlowValidation/PFODQA/CMakeLists.txt
diff --git a/Reconstruction/PFlow/PFlowValidation/PFODQA/CMakeLists.txt b/Reconstruction/PFlow/PFlowValidation/PFODQA/CMakeLists.txt
new file mode 100644
index 000000000000..39ead08f692c
--- /dev/null
+++ b/Reconstruction/PFlow/PFlowValidation/PFODQA/CMakeLists.txt
@@ -0,0 +1,28 @@
+################################################################################
+# Package: PFODQA
+################################################################################
+
+# Declare the package name:
+atlas_subdir( PFODQA )
+
+# Declare the package's dependencies:
+atlas_depends_on_subdirs( PUBLIC
+ GaudiKernel
+ PRIVATE
+ Control/AthenaMonitoring
+ Event/xAOD/xAODCaloEvent
+ Event/xAOD/xAODPFlow
+ Reconstruction/PFlow/PFlowUtils
+ Reconstruction/PFlow/PFlowValidation/PFOHistUtils
+ Tracking/TrkValidation/TrkValHistUtils )
+
+# External dependencies:
+find_package( ROOT COMPONENTS Core Tree MathCore Hist RIO pthread )
+
+# Component(s) in the package:
+atlas_add_component( PFODQA
+ src/*.cxx
+ src/components/*.cxx
+ INCLUDE_DIRS ${ROOT_INCLUDE_DIRS}
+ LINK_LIBRARIES ${ROOT_LIBRARIES} GaudiKernel AthenaMonitoringLib xAODCaloEvent xAODPFlow PFOHistUtils TrkValHistUtils )
+
diff --git a/Reconstruction/PFlow/PFlowValidation/PFODQA/Changelog b/Reconstruction/PFlow/PFlowValidation/PFODQA/Changelog
index f1f4f3dd08d7..0798e9bf704a 100644
--- a/Reconstruction/PFlow/PFlowValidation/PFODQA/Changelog
+++ b/Reconstruction/PFlow/PFlowValidation/PFODQA/Changelog
@@ -1,3 +1,7 @@
+11 May 2015 Mark Hodgkinson
+Fix Coverity issues 17432, 16380
+Tag as PFODQA-00-00-10
+
4 November 2014 Mark Hodgkinson
Add usage of new PFOAttributes class
Tag as PFODQA-00-00-09
diff --git a/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValCluster.cxx b/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValCluster.cxx
index ea2bc87af5ee..fc8e5ce64f7f 100644
--- a/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValCluster.cxx
+++ b/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValCluster.cxx
@@ -42,6 +42,7 @@ StatusCode PhysValCluster::fillHistograms(){
if (!theClusterContainer){
if (msgLvl(MSG::WARNING)) msg(MSG::WARNING) << " Have NULL pointer to xAOD::PFOContainer " << endreq;
+ return StatusCode::SUCCESS;
}
xAOD::CaloClusterContainer::const_iterator firstCluster = theClusterContainer->begin();
diff --git a/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValPFO.cxx b/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValPFO.cxx
index a2662392ea05..d50ef7680b28 100644
--- a/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValPFO.cxx
+++ b/Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValPFO.cxx
@@ -59,6 +59,7 @@ StatusCode PhysValPFO::fillHistograms(){
if (!thePFOContainer){
if (msgLvl(MSG::WARNING)) msg(MSG::WARNING) << " Have NULL pointer to xAOD::PFOContainer " << endreq;
+ return StatusCode::SUCCESS;
}
xAOD::PFOContainer::const_iterator firstPFO = thePFOContainer->begin();
--
GitLab