From c8cf68e2e3618a0eaac7b5cce0e01bdfaf4a6b5f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ji=C5=99=C3=AD=20Ma=C5=A1=C3=ADk?=
 <Jiri.Masik@manchester.ac.uk>
Date: Wed, 23 Aug 2017 13:31:51 +0200
Subject: [PATCH] demote a per event INFO message, adjust binning

---
 .../python/TrigIDTPMonitorMonitoring.py       | 20 +++++++++----------
 .../src/TrigIDTPMonitorElectron.cxx           |  4 ++--
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/Trigger/TrigMonitoring/TrigIDTPMonitor/python/TrigIDTPMonitorMonitoring.py b/Trigger/TrigMonitoring/TrigIDTPMonitor/python/TrigIDTPMonitorMonitoring.py
index 05f0f17c8043..bcd34119ab7d 100644
--- a/Trigger/TrigMonitoring/TrigIDTPMonitor/python/TrigIDTPMonitorMonitoring.py
+++ b/Trigger/TrigMonitoring/TrigIDTPMonitor/python/TrigIDTPMonitorMonitoring.py
@@ -280,27 +280,27 @@ class TrigIDTPMonitorElectronMonitorBase(TrigGenericMonitoringToolConfig):
 
         #MONITORING THE IBL
         #Innermost detector hit efficiency profiles in bins of probe track (PT): eta and phi
-        self.Histograms += [ defineHistogram('PTeta, PTpixelFound', type='TProfile', title="Innermost layer of detector - Observed Tracks/Expected Tracks (pixel) for Precision Tracker vs eta; eta [radians]",
+        self.Histograms += [ defineHistogram('PTeta, PTpixelFound', type='TProfile', title="Expected && Found hit (IBL) for Precision Tracker vs eta; eta [radians]",
                                              xbins=15, xmin=-3, xmax=3,
                                              ymin=-0.1, ymax=1.1) ]
-        self.Histograms += [ defineHistogram('PTphi, PTpixelFound', type='TProfile', title="Innermost layer of detector - Observed Tracks/Expected Tracks (pixel) for Precision Tracker vs phi; phi [radians]",
-                                             xbins=9, xmin=-3.14, xmax=3.14,
+        self.Histograms += [ defineHistogram('PTphi, PTpixelFound', type='TProfile', title="Expected && Found hit (IBL) for Precision Tracker vs phi; phi [radians]",
+                                             xbins=14, xmin=-3.14, xmax=3.14,
                                              ymin=-0.1, ymax=1.1) ]
         #2D profile histogram of inner detector region
-        self.Histograms += [ defineHistogram('PTeta, PTphi, PTpixelFound', type='TProfile2D', title="Innermost layer of detector - Observed Tracks/Expected Tracks (pixel) for region; eta; phi",
+        self.Histograms += [ defineHistogram('PTeta, PTphi, PTpixelFound', type='TProfile2D', title="Expected && Found hit (IBL) for region; eta; phi",
                                              xbins=10, xmin=-3, xmax=3,
-                                             ybins=10, ymin=-3.14, ymax=3.14, zmin=-0.1, zmax=1.1) ]
+                                             ybins=14, ymin=-3.14, ymax=3.14, zmin=-0.1, zmax=1.1) ]
         #Next to Innermost detector hit efficiency profiles in bins of probe track (PT): eta and phi
-        self.Histograms += [ defineHistogram('PTeta, PTpixelNextToFound', type='TProfile', title="Next to innermost layer of detector - Observed Tracks/Expected Tracks (pixel) for Precision Tracker vs eta; eta [radians]",
+        self.Histograms += [ defineHistogram('PTeta, PTpixelNextToFound', type='TProfile', title="Next to innermost layer of detector - Expected && Found hit (L0) for Precision Tracker vs eta; eta [radians]",
                                              xbins=15, xmin=-3, xmax=3,
                                              ymin=-0.1, ymax=1.1) ]
-        self.Histograms += [ defineHistogram('PTphi, PTpixelNextToFound', type='TProfile', title="Next to innermost layer of detector - Observed Tracks/Expected Tracks (pixel) for Precision Tracker vs phi; phi [radians]",
-                                             xbins=9, xmin=-3.14, xmax=3.14,
+        self.Histograms += [ defineHistogram('PTphi, PTpixelNextToFound', type='TProfile', title="Next to innermost layer of detector - Expected && Found hit (L0) for Precision Tracker vs phi; phi [radians]",
+                                             xbins=22, xmin=-3.14, xmax=3.14,
                                              ymin=-0.1, ymax=1.1) ]
         #2D profile histogram of inner detector region
-        self.Histograms += [ defineHistogram('PTeta, PTphi, PTpixelNextToFound', type='TProfile2D', title="Next to innermost layer of detector - Observed Tracks/Expected Tracks (pixel) for region; eta; phi",
+        self.Histograms += [ defineHistogram('PTeta, PTphi, PTpixelNextToFound', type='TProfile2D', title="Next to innermost layer of detector - Expected && Found hit (L0) for region; eta; phi",
                                              xbins=10, xmin=-3, xmax=3,
-                                             ybins=10, ymin=-3.14, ymax=3.14, zmin=-0.1, zmax=1.1) ]
+                                             ybins=22, ymin=-3.14, ymax=3.14, zmin=-0.1, zmax=1.1) ]
     
 
 class TrigIDTPMonitorElectronOnlineMonitor(TrigIDTPMonitorElectronMonitorBase):
diff --git a/Trigger/TrigMonitoring/TrigIDTPMonitor/src/TrigIDTPMonitorElectron.cxx b/Trigger/TrigMonitoring/TrigIDTPMonitor/src/TrigIDTPMonitorElectron.cxx
index 951f80e3b363..b55808998a0b 100644
--- a/Trigger/TrigMonitoring/TrigIDTPMonitor/src/TrigIDTPMonitorElectron.cxx
+++ b/Trigger/TrigMonitoring/TrigIDTPMonitor/src/TrigIDTPMonitorElectron.cxx
@@ -938,7 +938,7 @@ HLT::ErrorCode TrigIDTPMonitorElectron::hltExecute(const HLT::TriggerElement* in
     }
     y++;
   }
-  if(m_FTFfound){
+  if(m_FTFfound==0){
     ATH_MSG_DEBUG("FTF:::1)COMBINED CRITERIA: This candidate was found to be INEFFICIENT");
   }
   if(m_FTFfound==1){
@@ -951,7 +951,7 @@ HLT::ErrorCode TrigIDTPMonitorElectron::hltExecute(const HLT::TriggerElement* in
   //~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
 
   //END OF ALGORITHM
-  ATH_MSG_INFO( "Finishing TrigIDTPMonitorElectron" );
+  ATH_MSG_DEBUG( "Finishing TrigIDTPMonitorElectron" );
 
   return HLT::OK;
 }
-- 
GitLab