1. 28 May, 2021 1 commit
  2. 15 Dec, 2020 1 commit
  3. 14 Aug, 2018 1 commit
  4. 09 Mar, 2018 1 commit
    • John Chapman's avatar
      Making TruthSvc methods const · bcab6c99
      John Chapman authored
      This merge request synchronises the `TruthSvc` implementation in
      ~master and  ~"21.0". The principle changes are to make most methods
      `const`. Two unused member variables have been deleted.
      
      
      Former-commit-id: 42af6c82
      bcab6c99
  5. 07 Mar, 2018 2 commits
    • John Chapman's avatar
      Simplifying debug printout code. · d99b1fc8
      John Chapman authored
      
      Former-commit-id: 25ec21a7
      d99b1fc8
    • John Chapman's avatar
      Robustness improvements for the TruthSvc · 243ecf8f
      John Chapman authored
      It was found that calls to `ITruthIncident::parentParticleAfterIncident(...)`
      may alter the output of subsequent calls to `ITruthIncident::parentParticle()`.
      (Whether this should be the case is a separate issue to be followed up
      elsewhere.)
      
      The `TruthSvc` needed a couple of tweaks to make it robust against
      this feature.  At the same time some of the logic was tidied up to
      make it cleaner and more descriptive comments added in a couple of
      places. See ATLASSIM-3313.
      
      
      Former-commit-id: 147a1d97
      243ecf8f
  6. 28 Feb, 2018 1 commit
  7. 20 Nov, 2017 1 commit
  8. 15 Nov, 2017 1 commit
  9. 10 Nov, 2017 1 commit
  10. 29 May, 2017 1 commit
  11. 03 Apr, 2017 1 commit
    • Elmar Ritsch's avatar
      Merge ISF_Services-00-08-00-branch into trunk (ATLASSIM-3029): Adopt package... · 4a474458
      Elmar Ritsch authored
      Merge ISF_Services-00-08-00-branch into trunk (ATLASSIM-3029): Adopt package to new location of Barcode.h and PhysicsProcessCode.h files. ATLASSIM-2281 + Register CfgGetter method for ISF_ParticleKillerSvc. ATLASSIM-2995 + Add getParticleKillerSvc CfgGetter method. ATLASSIM-2995 + Add support for pileup input collection to new ISF input processing implementation. ATLASSIM-2928 + Remove no longer needed ISF_LongLivedParticleBrokerSvc configuration as it was made obsolete by ISF_LongLivedInputConverter. ATLASSIM-2928 + Update long-lived particle simulation to new ISF input processing. ATLASSIM-2928 + Refactor ISF Input Processing for AthenaMT. ATLASSIM-2928 + Add first tests for new InputConverter AthService (ISF_Services-01-01-00)
      
      	* Merge ISF_Services-00-08-00-branch into trunk (ATLASSIM-3029):
      		* Adopt package to new location of Barcode.h and PhysicsProcessCode.h files
      		(moved from BarcodeInterfaces package into new BarcodeEvent package). This is
      		to follow ATLAS conventions about providing event-data types in dedicated
      		*Event packages. ATLASSIM-2281
      		* python/ISF_ServicesConfigDb.py - remove unneeded imports.
      		Register CfgGetter method for ISF_ParticleKillerSvc. ATLASSIM-2995
      		* python/ISF_ServicesConfig.py - add getParticleKillerSvc
      		CfgGetter method. ATLASSIM-2995. General tidying of syntax.
      		* Add support for pileup input collection to new
      		ISF input processing implementation. Crucial for
      		FastChain with pilup simulation. ATLASSIM-2928
      		* python/ISF_ServicesConfigDb.py - remove no longer needed
      		ISF_LongLivedParticleBrokerSvc configuration as it was made obsolete by
      		ISF_LongLivedInputConverter. ATLASSIM-2928
      		* Update long-lived particle simulation to new ISF input processing.
      		ATLASSIM-2928
      		* Refactor ISF Input Processing for AthenaMT. ATLASSIM-2928
      		* Add first tests for new InputConverter AthService
      	* ISF_Services-01-01-00
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: fde4cb65
      4a474458
  12. 02 Jul, 2016 1 commit
  13. 09 May, 2016 1 commit
    • Zach Marshall's avatar
      Changes for another version of the QS particle simulation truth strategy... · bda89c7a
      Zach Marshall authored
      Changes for another version of the QS particle simulation truth strategy (ISF_HepMC_Services-00-09-01)
      
      	* Changes for version 37 of quasi-stable particle simulation truth
      	strategy
      	* tag ISF_HepMC_Services-00-09-01
      
      2016-03-31  Elmar Ritsch  <Elmar.Ritsch@cern.ch>
      	* Merge changes from ISF_HepMC_Services-00-07-00->ISF_HepMC_Services-00-07-00-03
      	into trunk
      		** Migrate TruthSvc to new and simplified ISF TruthBinding implementation.
      		Relevant for reproducing legacy SD barcode behaviour as in AtlasG4. ATLASSIM-2483
      		** Always record primary particle barcode in HepMC::GenVertex weights (even for
      		regenerated particles).
      		** Improve robustness in HepMC_TruthSvc: abort in case a nullptr
      		is returned as parent particle for given truth incident
      	* tag ISF_HepMC_Services-00-09-00
      
      2015-10-23  Elmar Ritsch  <Elmar.Ritsch@cern.ch>
      	* src/HepMC_TruthSvc.cxx: fixing uninitialized member variable in
      	constructor (CID 32716, ATLASSIM-2417). (NB: This did not cause any
      	runtime issues, since the variables were getting initialized for each
      	event inside the initializeTruthCollection() method)
      ...
      (Long ChangeLog diff - truncated)
      bda89c7a
  14. 13 Nov, 2015 1 commit
    • Elmar Ritsch's avatar
      using new IBarcodeSvc methods to retrieve secondary particle and vertex... · 6fcabc24
      Elmar Ritsch authored
      using new IBarcodeSvc methods to retrieve secondary particle and vertex offsets (ATLASSIM-2249) + fixing issue where 'm_myLowestVertexBC' did not get reset with each new Athena event (ISF_HepMC_Services-00-08-00)
      
      	* src/HepMC_TruthSvc.h/cxx
      		** using new IBarcodeSvc methods to retrieve secondary particle
      		   and vertex offsets (ATLASSIM-2249)
      		** fixing issue where 'm_myLowestVertexBC' did not get reset with
      		   each new Athena event
      	* tag ISF_HepMC_Services-00-08-00
      6fcabc24
  15. 15 Sep, 2015 1 commit
    • Elmar Ritsch's avatar
      making end-vertex writing configurable per detector region (ATLASSIM-2123) +... · 8d1cb5fe
      Elmar Ritsch authored
      making end-vertex writing configurable per detector region (ATLASSIM-2123) + fixing accidental overwrite of ISF_MC12PlusTruthService CfgGetter DB entry (ISF_HepMC_Services-00-07-00)
      
      	* python/ISF_HepMC_ServicesConfigDb.py - fixing accidental overwrite of
      	ISF_MC12PlusTruthService CfgGetter DB entry
      	* src/HepMC_TruthSvc.h/cxx, python/ISF_HepMC_ServicesConfig.py - making
      	end-vertex writing configurable per detector region (ATLASSIM-2123)
      	* tag ISF_HepMC_Services-00-07-00
      
      2015-07-10  John Chapman  <John.Chapman@cern.ch>
      	* python/ISF_HepMC_ServicesConfig.py,
      	python/ISF_HepMC_ServicesConfigDb.py - add CfgGetter method for
      	ISF_MC12LLPTruthService, which should resolve ATLASSIM-1931.
      	* tag ISF_HepMC_Services-00-06-02
      
      2015-07-01  Zach Marshall <ZLMarshall@lbl.gov>
      	* Removing much of the special handling of barcodes for Q-S particle
      	simulation.  This implements the new notion of what the truth record
      	should look like, following ATLASSIM-526
      	* tag ISF_HepMC_Services-00-06-01
      
      2015-06-17  John Chapman  <John.Chapman@cern.ch>
      
      ...
      (Long ChangeLog diff - truncated)
      8d1cb5fe
  16. 17 May, 2015 1 commit
    • Elmar Ritsch's avatar
      adding null-pointer check for secondary particles returned by TruthIncident... · e27c3884
      Elmar Ritsch authored
      adding null-pointer check for secondary particles returned by TruthIncident (ISF_HepMC_Services-00-03-07)
      
      	* src/HepMC_TruthSvc.cxx - adding null-pointer check for secondary
      	particles returned by TruthIncident
      	* tag ISF_HepMC_Services-00-03-07
      
      2015-03-28  John Chapman  <John.Chapman@cern.ch>
      
      	* python/ISF_HepMC_ServicesConfig.py,
      	python/ISF_HepMC_ServicesConfigDb.py - add getMC15aTruthService,
      	which has the same configuration as
      	getMC15TruthService. ATLASSIM-1909
      	* tag ISF_HepMC_Services-00-03-06
      e27c3884
  17. 20 Mar, 2015 1 commit
    • Zach Marshall's avatar
      Adding warning message (ISF_HepMC_Services-00-03-05) · afbaaa3a
      Zach Marshall authored
      	* src/HepMC_TruthSvc.cxx: Adding warning messages
      	* tag ISF_HepMC_Services-00-03-05
      
      2015-02-27  Zach Marshall <ZLMarshall@lbl.gov>
      
      	* src/HepMC_TruthSvc.cxx: Modifying vertex barcode in the case that a
      	primary is being re-simulated (for quasi-stable particle simulation)
      	* tag ISF_HepMC_Services-00-03-04
      afbaaa3a
  18. 03 Mar, 2015 1 commit
    • John Derek Chapman's avatar
      src/HepMC_Truth.cxx - fix typo in configurable property name added in previous... · a8e93682
      John Derek Chapman authored
      src/HepMC_Truth.cxx - fix typo in configurable property name added in previous tag. ATLASSIM-526. python/ISF_HepMC_ServicesConfig.py - tidy up configuration to share repeated lines. Add a check on ISF_Flags.Simulator to check for longLived and switch off warnings in that case. Temporary measure until a better solution can be found. ATLASSIM-526. Tag ISF_HepMC_Services-00-03-03 (ISF_HepMC_Services-00-03-03)
      
      	* python/ISF_HepMC_ServicesConfig.py - remove debugging line.
      	* tag ISF_HepMC_Services-00-03-03
      
      2015-02-18  John Chapman  <John.Chapman@cern.ch>
      
      	* src/HepMC_Truth.cxx - fix typo in configurable property name
      	added in previous tag. ATLASSIM-526
      	* python/ISF_HepMC_ServicesConfig.py - tidy up configuration to
      	share repeated lines. Add a check on ISF_Flags.Simulator to check
      	for longLived and switch off warnings in that case. Temporary
      	measure until a better solution can be found. ATLASSIM-526
      	* tag ISF_HepMC_Services-00-03-02
      
      	* src/HepMC_Truth.h, src/HepMC_Truth.cxx - add
      	QuasiStableParticlesIncluded configurable property to suppress
      	warnings when behaviour is actually expected! ATLASSIM-526.
      	* tag ISF_HepMC_Services-00-03-01
      
      	2015-02-05  John Chapman  <John.Chapman@cern.ch>
      ...
      (Long ChangeLog diff - truncated)
      a8e93682
  19. 18 Feb, 2015 1 commit
    • John Derek Chapman's avatar
      python/ISF_HepMC_ServicesConfig.py - remove unnecessary calls to... · 6ba4c2aa
      John Derek Chapman authored
      python/ISF_HepMC_ServicesConfig.py - remove unnecessary calls to getPublicTool. It is sufficient to use the name of the name of the tools. Add python/ISF_HepMC_ServicesConfigDb.py - Requires ISF_Config-00-01-14. HepMC_Truth.h - move to src directory. ATLASSIM-1654. cmt/requirements - update use statements after header file move. Tag ISF_HepMC_Services-00-03-00 (ISF_HepMC_Services-00-03-00)
      
      	* python/ISF_HepMC_ServicesConfig.py - remove unnecessary calls to
      	getPublicTool. It is sufficient to use the name of the tools.
      	* add python/ISF_HepMC_ServicesConfigDb.py - Requires
      	ISF_Config-00-01-14.
      	* HepMC_Truth.h - move to src directory. ATLASSIM-1654.
      	* cmt/requirements - update use statements after header file move.
      	* tag ISF_HepMC_Services-00-03-00
      6ba4c2aa
  20. 05 Nov, 2014 1 commit
    • Elmar Ritsch's avatar
      take BarcodeService from ISF_Flags (ATLASSIM-1658) (ISF_HepMC_Services-00-02-01) · 2776f63e
      Elmar Ritsch authored
      	* python/ISF_HepMC_ServicesConfig.py - take BarcodeService from ISF_Flags
      	(ATLASSIM-1658)
      	* tag ISF_HepMC_Services-00-02-01
      
      2014-10-21  John Chapman  <John.Chapman@cern.ch>
      
      	* ISF_HepMC_Services/HepMC_TruthSvc.h - add m_passWholeVertex
      	property. ATLASSIM-1603.
      	* src/HepMC_TruthSvc.cxx - add PassWholeVertices property (default
      	True for back-compatibility). Call
      	ITruthIncident::setPassWholeVertices in
      	HepMC_TruthSvc::registerTruthIncident. ATLASSIM-1603.
      	* python/ISF_HepMC_ServicesConfig.py - add getMC15TruthService
      	method and set new PassWholeVertices property to True for
      	ISF_ValidationTruthService and
      	ISF_MC12TruthService. ATLASSIM-1603.
      	* tag ISF_HepMC_Services-00-02-00
      
      2014-10-20  Zach Marshall <ZLMarshall@lbl.gov>
      ...
      (Long ChangeLog diff - truncated)
      2776f63e
  21. 19 Sep, 2014 1 commit