GitLab

Susumu Oda authored Sep 05, 2019 and Vakhtang Tsulaia committed Sep 05, 2019

Remove PixelDetectorManager from FastSiDigitization and PixelDigitization packages (ATLASRECTS-5078)

John Derek Chapman authored May 21, 2019 and Adam Edward Barton committed May 21, 2019

Remove the property from derived classes.

Susumu Oda authored Aug 13, 2018 and Frank Winklmeier committed Aug 13, 2018

Former-commit-id: 3d995d8b

The Gaudi PluginSvc has been refactored and modernizes.
See gaudi/Gaudi!709

As well as some changes to macros that directly call on
certain features of the PluginSvc itself, other code that
has been impacted is as follows:

 - destructors of Converters must be public
 - template arguments of ServiceHandles and ToolHandles cannot always be forward defined and the associated header files may need to be explicitly included


Former-commit-id: 83042516

   - InnerDetector/InDetDigitization/PixelDigitization/


Former-commit-id: 0a301405

Former-commit-id: 9b39c6d9

Former-commit-id: c1359283

Former-commit-id: f527502e

This reverts commit cdf718bf [formerly 9d67f5b8].


Former-commit-id: 008b62d0

This reverts commit 9156e32a [formerly f73d17d3], reversing
changes made to 27d106d1 [formerly 8f2f5188].


Former-commit-id: 9d67f5b8

Former-commit-id: 1ee19443

Former-commit-id: 166ef32d

Resolved the mmory issue (one of the containers, which would normally be cleared by going out of scope, had to be cleared manually). Still a difference in the output but I think that again this is becuase of the random number generaters. Will be debugging against old commit to check.


Former-commit-id: 3ff21edc

Former-commit-id: 0a0c4caa

Private data members should start with m_.



Former-commit-id: 848dac9c

clang warnings: missing override keywords, unused variables.



Former-commit-id: 1e69727c

Former-commit-id: e44822c3

  * Replace ISiChargedDiodesProcessorTool with PixelProcessorTool.
	* Tagged as PixelDigitization-02-03-31.


Former-commit-id: c5aa163f

  * Fix coverity defect.
	* Tagged as PixelDigitization-02-03-30.

2017-02-10  Soshi Tsuno
  * Add front-end simulation tool.
  * Delete PixelCellDiscriminator. Now this functionality is done in front-end sim tool.
	* Tagged as PixelDigitization-02-03-29.


Former-commit-id: e12aa8ed

  * Small bug fix and remove warnings.
	* Tagged as PixelDigitization-02-03-28.

2017-01-30  Soshi Tsuno
  * Recover processBunchXing method for ATLASSIM-2900.
	* Tagged as PixelDigitization-02-03-27.

2016-12-26  Soshi Tsuno
  * The PixelDigitizationTool was largely cleaned up.
  * This is the preparation step toward ver.-03-00-00.
	* Tagged as PixelDigitization-02-03-26.

2016-12-25  Soshi Tsuno
  * remove SpecialPixelGenerator.
	* Tagged as PixelDigitization-02-03-25.

2016-12-21  Soshi Tsuno
  * Use ToolHandleArray for charge simulation (SurfaceChargeTool)
  * remove SurfaceChargeTool
	* Tagged as PixelDigitization-02-03-24.
...
(Long ChangeLog diff - truncated)


Former-commit-id: c9bf8664

  * Changed the pixel setting to match with 2016 operation.
	* Tagged as PixelDigitization-02-03-15

2016-06-23 Fares Djama
        * Fix Jira ticket ATLASRECTS-3262 (fix cmt/requirement file)
	* Tagged as PixelDigitization-02-03-14

2016-06-23 Fares Djama
        * Fix Jira ticket ATLASRECTS-3294: get rid of hard coded limit in jumping over ganged pixels in FE-I3
	* Tagged as PixelDigitization-02-03-13

2016-06-23 Fares Djama
        * Fix Jira ticket ATLASRECTS-2925
        * Fix a bug in Initialization method of PixelNoisyGenerator
	* Tagged as PixelDigitization-02-03-12

2016-06-17 Fares Djama
        * Fixed the decoding of noisy map from pixid to (chip,col,row):
	*   1) IBL Compatible
	*   2) Uses a new decodePixelID method in PixelCoralClientUtils-00-05-09 to avoid hard coding
...
(Long ChangeLog diff - truncated)


Former-commit-id: e1673344

src/PixelDigitizationTool.h, src/PixelDigitizationTool.cxx: revert change from PixelDigitization-02-03-08 which switched processBunchXing back to using PileUpEventInfo rather than xAOD::EventInfo. Fix initialization order warning. PixelNoisyCellGenerator no longer needs to be a member variable. Fix issue where chargedDiodes variable name was both a member variable and an input variable name to a method. python/PixelDigitizationConfig.py (BasicPixelDigitizationTool): no need to specifically add to the ToolSvc. CfgGetter will take care of this. ATLASSIM-2565. Tagged as PixelDigitization-02-03-09 (PixelDigitization-02-03-09)

	* src/PixelDigitizationTool.h, src/PixelDigitizationTool.cxx:
	revert change from PixelDigitization-02-03-08 which switched
	processBunchXing back to using PileUpEventInfo rather than
	xAOD::EventInfo. Fix initialization order
	warning. PixelNoisyCellGenerator no longer needs to be a member
	variable. Fix issue where chargedDiodes variable name was both a
	member variable and an input v...

	* update the timing simulation for 2016.
	  src/TimeSvc.cxx .h: add new parameterization from 2015 collision data.
		src/PixelCellDiscriminator.cxx .h: default use 2015 timing.
	* update Bichsel model with improved execution time.
    src/BichselSimTool.cxx .h
		src/Ibl3DBichselChargeTool.cxx .h
		src/IblPlanarBichselChargeTool.cxx .h
		src/PixelBarrelBichselChargeTool.cxx .h
		src/PixelECBichselChargeTool.cxx .h
    share/Bichsel_1.dat _1_10steps.dat _1_5steps.dat
    share/Bichsel_2.dat _2_10steps.dat _2_5steps.dat
    share/Bichsel_3.dat _3_10steps.dat _3_5steps.dat
    share/Bichsel_4.dat _4_10steps.dat _4_5steps.dat
    share/Bichsel_5.dat _5_10steps.dat _5_5steps.dat
    share/Bichsel_6.dat _6_10steps.dat _6_5steps.dat

2016-04-05  John Chapman  <John.Chapman@cern.ch>

	* src/BichselSimTool.cxx (BichselSim): comment out unused
...
(Long ChangeLog diff - truncated)

src/Ibl3DBichselChargeTool.cxx (Ibl3DBichselChargeTool): reorder initialization of member variables to remove build warning. (charge): comment out unused m_isRealBichsel variable to get rid of build warning. Tagged as PixelDigitization-02-00-20-04 (PixelDigitization-02-00-20-04)

	* src/Ibl3DBichselChargeTool.cxx (Ibl3DBichselChargeTool): reorder
	initialization of member variables to remove build warning.
	(charge): comment out unused m_isRealBichsel variable to get rid
	of build warning.
	* Tagged as PixelDigitization-02-00-20-04

2016-03-23 Magda Chelstowska <magdac@cern.ch>
	* Fixed Pixel Cabling for Run1 digi (obo John Chapman) ATLASSIM-2680
	* Tagged as PixelDigitization-02-00-20-03

2016-02-17  John Chapman  <John.Chapman@cern.ch>
	* Revert changes from PixelDigitization-02-00-20-01
	* Merge in changes from PixelDigitization-02-00-22-04 without the
	changes from PixelDigitization-02-00-21. ATLASSIM-2593
        * Set doITk flags consistently using GeometryFlags.isSLHC()
        * SurfaceChargeTool: Use IBL planar modules everywhere if doITk
	for now
        * Added more debug statements
        * src/PixelDigitizationTool.cxx - Use "at" to protect against
...
(Long ChangeLog diff - truncated)

	* Implement FE-I4 copy mechanism for small hits.
	* HitDiscCnfg folder not ready yet: HitDiscCnfg put manually to 2. Will fix once folders are available.
	* tagged as PixelDigitization-02-00-14

2015-09-24 Fares Djama
	* Remove FEI3 duplicaion mechanism for IBL.
	* Add ApplyDupli property for IBL, BL, L1, L2 ECC and DBM independently.
	* Add 3 other properties for the same regions: latency, ToT cut and maximum ToT for hit duplication.
	* tagged as PixelDigitization-02-00-13

	obo S.Roe:
	* src/PixelDigitizationTool.cxx
	* src/PixelDigitizationTool.h
	added protection to avoid ParticleGuns to be blocked
	JIRA ATLASSIM-1790
	*  tagged as PixelDigitization-02-00-09

	* src/PixelDigitizationTool.cxx
	removed the IBL tot special treatment , now is
	taken care in the conddb
	* tagged as PixelDigitization-02-00-07

2014-12-09 Matthew Klein <matthew.henry.klein@cern.ch>
	* CalibSvc now uses PixelCalibSvc for default settings with no db

2014-11-30 Silvia Miglioranzi <Silvia.Miglioranzi@cern.ch>
	* moved CalibSvc.h from src/ to PixelDigitization/
	plus adjusted the corresponding includes
	* Tagged as PixelDigitization-02-00-06

	* Fixed covarity defects
	* Tagged as PixelDigitization-02-00-05