GitLab

Attila Krasznahorkay authored Feb 19, 2020 and Walter Lampl committed Feb 19, 2020

On top of the minimal changes I also removed the usage of
atlas_depends_on_subdirs(...) from the package's configuration,
as we're trying to phase that out in master...

Protect against errors in legacy TC objects with the _v1 store
Add a throw on partial decoration data being read

     * TrigComposite (a.k.a. Decision) objects, when asked for an ElementLink, can now introspect if they've been decorated with re-mapped information.
     * Re-mapping of element links happens online at the end of processing, when EDM objects inside EventViews are copied out into EDM containers in the global event context.
     * Feature access code is reworked slightly to return LinkInfo objects rather than ElementLink objects. This is better as you can easily then also check which ROI your feature was in, etc.
     * The list of hard-coded chains was updated based on full_menu.py
     * HLTEDMCreator was updated to be given the HypoAlg output collection to remap rather than the InputMaker output. This was a bug before, features are attached by the hypo.
     * The way that `HLTEDMCreator` knows what collections need their element links updating was reworked - but reamins a bit clunky.
     * `HLTEDMCreator` indentation was standadised
     * Printing of feature properties was added to `TrigEDMChecker::dumpTDT`

Enable the thread-safety checker for most of the xAODTrig* packages and
apply the relevant fixes (mostly just `static` -> `static const`). The
following packages require less trivial fixes and still need to be done:

xAODTrigRingerAthenaPool
xAODTrigBphysAthenaPool
xAODTrigMuonAthenaPool
xAODTrigCaloAthenaPool
xAODTrigEgammaAthenaPool
xAODTriggerAthenaPool
xAODTrigger

Tim Martin authored May 08, 2019 and Walter Lampl committed May 08, 2019

Add extra type checking to TrigComposite. Allow casting to generic IParticleContainer interface. TODO add explicit check on cast

Tim Martin authored Mar 11, 2019 and Walter Lampl committed Mar 11, 2019

ATR-19379 Consistent use of DecisionID typedef. Consistent use of ElementLinkVector "seed" in R3 trigger steering.

operator<< should be declared within the namespace of its argument
so that argument-dependent lookup will work properly.

Benjamin Michael Wynne authored Dec 14, 2018 and Frank Winklmeier committed Dec 14, 2018

Former-commit-id: 871eae45

Simon George authored Dec 13, 2018 and Adam Edward Barton committed Dec 13, 2018

Former-commit-id: d8bf5ce6e53fe00e8e471b07ba431b91fa311037

Scott Snyder authored Sep 28, 2018 and Walter Lampl committed Sep 28, 2018

Former-commit-id: 57b7313c

Former-commit-id: 5e776a09

  std::string
  std::vector<std::string>
  std::vector<uint16_t>
Internally these all pack into a std::vector<int32_t> which is supported in the dynamic auxilary in the bytestream

Also converted all int to explicit int32_t and uint32_t due to introduction of short data types


Former-commit-id: a392c78c

Former-commit-id: 3dd005f2

 * copyLinkFrom
 * copyLinkCollectionFrom
 * copyAllLinksFrom
Updated TrigCompositeUtils::copyLinks to use this, this fn could then possibly be removed in the future too


Former-commit-id: d72008ce

Former-commit-id: a3426609

Former-commit-id: 97d041c2

 * Extend the TrigDecision class to hold sparse vectors of chains with positive decision
 * Move some common typedefs within the xAODTrigger package to make these accessible also in AnalysisBase in the future


Former-commit-id: 4c2d9928

Tim Martin authored Jul 04, 2018 and Adam Edward Barton committed Jul 04, 2018

Former-commit-id: 2f6e95fa

Can clean up a bit now.  In particular, we don't need the thread-local
auxid sets.



Former-commit-id: 9b36567c

Former-commit-id: 9b39c6d9

Use C++11 range-based for instead of FOREACH macro.


Former-commit-id: f3236461

Add a return value to IConstAuxStore::clearDecorations() to tell if any
decorations were actually cleared.  Allows speeding up some implementations
of clearDecorations() for the case when there are actually no decorations.



Former-commit-id: c509beee

    
To allow WriteDecorHandle to lock the decoration after setting it.

Former-commit-id: 5321cfdd

	* Tagging xAODTrigger-00-00-56.
	* xAODTrigger/versions/ByteStreamAuxContainer_v1.h,
	Root/ByteStreamAuxContainer_v1.cxx: Implement insertMove.
	* test/ut_xaodtrigger_bytestreamauxcontainer_v1_test.cxx,
	share/ut_xaodtrigger_bytestreamauxcontainer_v1_test.ref: Test it.


Former-commit-id: 259a1b51

	* Tagging xAODTrigger-00-00-55.
	* xAODTrigger/versions/ByteStreamAuxContainer_v1.h,
	Root/ByteStreamAuxContainer_v1.cxx: Update for change in behavior
	of resize.


Former-commit-id: 5585ec1a

	* Extended TrigComposite interface to allow for collections.
	* Add a std::pair<bool, TYPE> getDetail member as may be preferred by some.
	* Tagging as xAODTrigger-00-00-54


Former-commit-id: bf1fdc43

	* Extended/modified the xAOD::TrigPassBits interface, as we
	  agreed with Ryan and Lukas.
	* Tagging as xAODTrigger-00-00-53

2016-07-14 Tomasz Bold
	* extended API for TrigComposite


Former-commit-id: 8c4ddc24