1. 18 Jun, 2021 1 commit
  2. 07 Jun, 2021 1 commit
  3. 19 May, 2021 1 commit
  4. 28 Apr, 2021 1 commit
  5. 27 Apr, 2021 1 commit
  6. 22 Apr, 2021 1 commit
  7. 21 Apr, 2021 2 commits
  8. 15 Apr, 2021 1 commit
  9. 08 Apr, 2021 2 commits
  10. 27 Mar, 2021 2 commits
  11. 23 Mar, 2021 1 commit
  12. 22 Mar, 2021 1 commit
  13. 19 Mar, 2021 1 commit
  14. 18 Mar, 2021 1 commit
  15. 17 Mar, 2021 2 commits
  16. 16 Mar, 2021 1 commit
  17. 12 Mar, 2021 3 commits
  18. 05 Mar, 2021 1 commit
  19. 27 Feb, 2021 1 commit
  20. 25 Feb, 2021 1 commit
  21. 19 Feb, 2021 1 commit
  22. 18 Feb, 2021 1 commit
  23. 05 Feb, 2021 1 commit
  24. 04 Feb, 2021 1 commit
  25. 02 Feb, 2021 1 commit
  26. 29 Jan, 2021 1 commit
  27. 25 Jan, 2021 1 commit
  28. 22 Jan, 2021 1 commit
  29. 20 Jan, 2021 1 commit
  30. 08 Jan, 2021 1 commit
    • Nils Krumnack's avatar
      fix all compiler warnings for AnalysisBase on latest MacOS · 602b780a
      Nils Krumnack authored
      New compiler, new set of warnings...
      
      The main theme here is that clang now checks for range-based for loops
      whether it introduces unneeded temporaries, i.e. if the user asks for
      a reference for the loop variable, but the iterator doesn't return a
      reference or a reference of a different type, or conversely if the
      user asked for `const auto`, but could have been `const auto&`.
      
      In practice that usually hits us as:
      ```
      for (const auto& jet : jetContainer)
      ```
      which should be:
      ```
      for (const auto *jet : jetContainer)
      ```
      
      Also a couple of places like this (which miss the `const` qualifier on
      the first template parameter):
      ```
      std::map<std::string,std::string> stringMap;
      for (const std::pair<std::string,std::string>& stringPair : stringMap)
      ```
      
      For the most part I just replaced the loop variable type with what
      seemed correct.  In a few places I put explicit comments as to why I
      chose the type.
      
      Also a fair number of warnings for unused member variables in various
      packages.  Since I am not an expert on any of these packages and this
      can point to an actual bug, I commented out all unused variables and
      added a comment for actual experts to check and remove.
      
      I removed a couple of checks for `this != nullptr` which were
      originally introduced to check whether the user called a member
      function via a null pointer.  However those checks are `assert`-based,
      so with cmake they won't be included when the user calls them from a
      release, making this check mostly useless.
      
      There some other warnings I fixed in the process that should hopefully
      be self-explanatory.
      602b780a
  31. 05 Jan, 2021 1 commit
  32. 18 Dec, 2020 1 commit
  33. 16 Dec, 2020 1 commit
  34. 15 Dec, 2020 1 commit