Skip to content
GitLab
Switch branch/tag
  1. 04 Nov, 2019 1 commit
  3. 01 Nov, 2019 3 commits
  5. 30 Oct, 2019 2 commits
  7. 29 Oct, 2019 2 commits
    • Ewelina Maria Lobodzinska's avatar
      Merge branch '21.6-direct-photon-filter-remove-overlap' into '21.6' · 38f79cdd
      Ewelina Maria Lobodzinska authored 
      Add option to avoid overlap in DirectPhotonFilter slices

See merge request atlas/athena!27585
      38f79cdd
    • Frank Siegert's avatar
      Add option to avoid overlap in DirectPhotonFilter slices · 54c05cef
      Frank Siegert authored 
      Currently the DirectPhotonFilter allows to specify a pTmin and pTmax which can be matched by any photon. It is then used to slice the gamma+jet sample into supposedly complementary slices separate by photon pT.

This is problematic e.g. if there are two photons in an event, the leading one with pT>pTmax and the subleading with pTmin<pT<pTmax. This event will be accepted in the given slice, but will also be part of a higher pT slice due to the leading photon.

Here, an option is to be introduced in the DirectPhotonFilter which allows to cut exactly on the leading (and/or subleading, ...) photon instead of inclusively.

Closes AGENE-1780
      54c05cef
  9. 28 Oct, 2019 2 commits
  11. 24 Oct, 2019 2 commits
  13. 21 Oct, 2019 10 commits
  15. 20 Oct, 2019 1 commit
  17. 18 Oct, 2019 2 commits
  19. 12 Oct, 2019 1 commit
  21. 06 Oct, 2019 1 commit
    • Zach Marshall's avatar
      TestHepMC: Tidying and adding a check for valid PDG IDs · 3b058069
      Zach Marshall authored 
      The primary purpose of this commit is to add a check for invalid PDG
IDs, stemming from the discussion in !26148 .  This test is optional,
though on by default, and the user can provide a white list of IDs that
should be made exceptions to the rule, to allow exotic PDG IDs that
might not conform to still run.

At the same time, tweaking some of the logic in the filter to set a
boolean when the filter fails, then check the boolean at the end of
execution to push the filter results. This ensures that all tests run,
and that multiple tests can fail on a single event if appropriate. I
think this will be a help when debugging, but it does result in a change
of logging output (of course, the rate at which the filter fails is
still the same!).

The last part is general tidying, white space cleaning, and so on. Watch
for the "ignore white space changes" button in the diff to get to the
interesting part. This removes tabs in favor of spaces, makes the
spacing consistent, ensures we don't have multiple commands on a single
line, and so on. I tried to add a lot of comments as well, so that it's
a bit easier to see where one part of the code is ending and another is
beginning. I hope it's useful!
      3b058069
  23. 02 Oct, 2019 2 commits
  25. 26 Sep, 2019 1 commit
  27. 25 Sep, 2019 2 commits
  29. 24 Sep, 2019 3 commits
  31. 23 Sep, 2019 5 commits