Nils Erik Krumnack authored Oct 31, 2019 and Atlas Nightlybuild committed Nov 01, 2019

Configure AnaToolHandles from athena joboptions

See merge request atlas/athena!27452

(cherry picked from commit c6646656)

c49efd63 Allow AnaTool handles to be set in the JO
e36ffe20 Try to understand the failure if the AnaToolHandle is created with a name
12c502b8 Swapped empty and isUserConfigured check
0a029958 Merge branch '21.2' of ssh://gitlab.cern.ch:7999/atlas/athena into anatool_fix
6e16d41a Remove comments.. Realized that m_OriginalProperty is actually not needed
f9ad78d5 Remove the variable itself
33ebf252 Revert "Remove the variable itself"
7ab38b67 Revert "Remove comments.. Realized that m_OriginalProperty is actually not needed"
a32b03b1 Fix CI Test
6ac0bb4a Finally everything works...
993209e6 Merge branch '21.2' of ssh://gitlab.cern.ch:7999/atlas/athena into anatool_fix

EventLoop algorithms can change names after creation (and that would
be hard to fix), so I changed the code to ask the parent for their
name when the parent name is actually needed.

This update should also fix: https://its.cern.ch/jira/browse/ATLASG-1218


Former-commit-id: 841283749a47b73b73168cef7ca457d2fe39cf49

To bring the branch in sync with the 2.6.X nightlies.


Former-commit-id: 8a854675ce4b2115a9fa0e2ca059cb895286a4c5

branch. As some of the analysis tool packages already depend on features
that were not part of the code in this branch before.

The one thing that I didn't include from the master branch is the
const-correctness of the standalone implementation of ToolHandle<T>.
Since Gaudi doesn't force const-correctness for its own ToolHandle in
this branch, that just caused a lot of issues for the analysis code.
For no good reason. So the const-correctness issues will only be cleaned
up in the master branch properly.


Former-commit-id: 64b397379b90c683a755da250eed31c56508a218

added a minor tweak to ATLAS_GOOGLE_TEST_MAIN to make it compatible with/robust against using statements (AsgTools-00-00-89)

	* added a minor tweak to ATLAS_GOOGLE_TEST_MAIN to make it
	  compatible with/robust against using statements
	* tagging as AsgTools-00-00-89

2016-06-09 Nils Krumnack <Nils.Erik.Krumnack@cern.ch>
	* changed a warning message in AnaToolHandle::setProperty to an
	  info message
	* tagging as AsgTools-00-00-88

2016-06-06 Will Buttinger <will@cern.ch>
      * AnaToolHandle.icc: removed unneeded addRef, so that refcounts are all 2.
      Also stopped delete of tool when handle destroyed if the tool doesn't exist in toolsvc
      The toolsvc will try to delete tools when it finalizes, and if we had a parent tool
      referencing a subtool (via an anatoolhandle) but toolsvc decides to delete the subtool first
      then the destruction of the anatoolhandle when the parenttool is destroyed would lead to
      double delete. See ATLASG-515
      * tagging as AsgTools-00-00-87

2016-05-31 Will Buttinger <will@cern.ch>
      * AnaToolHandle.icc: fix logic for setting toolhandle properties in cmt releases
...
(Long ChangeLog diff - truncated)


Former-commit-id: f3cf9fa4

fixed AnaToolHandle::swap to work in Athena (the problem was that the release function had the AnaToolHandle it worked on hard-coded) (AsgTools-00-00-85)

	* fixed AnaToolHandle::swap to work in Athena (the problem was that
	  the release function had the AnaToolHandle it worked on hard-
	  coded)
	* tagging as AsgTools-00-00-85

2016-05-05 Nils Krumnack <Nils.Erik.Krumnack@cern.ch>
	* added documentation to the MessageCheck.h header file
	* tagging as AsgTools-00-00-84


Former-commit-id: 0c28bbef

	* Tagging AsgTools-00-00-83.
	* Root/AsgTool.cxx (getParent): Return ToolSvc if the parent
	pointer that was passed in is null.  This is apparently a
	legitimate use case in AthAnalysisBase.

2016-05-05 Will Buttinger <will@cern.ch>
	* cmt/requirements: made AtlasGoogleTest dependency private. When it was public, it would cause a weird memory corruption when compiling packages that use AsgTools. I don't understand this at all, but this is my attempt to fix the problem anyway
	* Tagging as AsgTools-00-00-82

2016-05-03 Attila Krasznahorkay <Attila.Krasznahorkay@cern.ch>
	* Only noticed now that since gtest/gtest.h is included in
	  AsgTools/UnitTest.h, we need to declare this dependency for
	  the library. (Only showed up as a problem with Xcode...)
	* Tagging as AsgTools-00-00-81

2016-05-03 Attila Krasznahorkay <Attila.Krasznahorkay@cern.ch>
	* Taught the package how to build itself in standalone
	  mode with CMake.
	* Tagging as AsgTools-00-00-80
...
(Long ChangeLog diff - truncated)


Former-commit-id: dc40e4f8