GitLab

That was introduced by two recent merge requests crossing.

Don't let cppcheck see the #error directives.

The goal here is to introduce a single python configurable in
AnalysisBase, instead of the current scheme in which there is a
separate configurable for AnaAlgorithm, AsgTool, etc. and essentially
duplicating a lot of code.

For now this duplicates even more code.  Once this is all tested and
validated, the old code will eitehr be completely removed or made to
inherit from the new classes.

Mostly so that it acts as a test of whether the EventLoop python
configuration would work properly on the grid.

I thought I had added all missing dictionaries, but there is one
missing here.

That was more or less a copy-paste error of a template function that
was never instantiated.

Unfortunately I don't have a really good way to test if it works, but
the underlying C++ is tested, and this is hopefully a close enough
duplication of what's happening for non-array tools that this is good
enough.

Originally I tried to do something more involved, but that became sort
of tedious given the logic of the python class.  Maybe at some point I
will come back and restructure the python class somewhat.  Hopefully
this is still workable as is.

The changes introduced in !42411 required additional dictionaries to
serialize any of the component configuration objects, which were not
defined in that merge request.  This is (apparently) not caught in any
unit tests, but it leads to any sub-tools to be stripped off
algorithms during batch and grid submission.

This MR should fix that by defining one dictionary and changing the
type of one member variable to avoid the need for the second.  At some
point a new test should be defined to catch these problems in CI, or
at least in the nightly tests, but for now having a quick fix seemed
more important.

This is meant as a drop-in replacement for `AnaAlgorithm` in
standalone applications that don't need most of its advanced features
and just need an easy way to configure and create a public tool.

Originally the goal was just to allow handling `ToolHandleArray`
properties, but it turned out to be a lot easier if subtools are
represented by `AsgToolConfig` in turn.

 AsgServices add ATLAS_CHECK_THREAD_SAFETY. 1st it passes it . 2nd we inherit now from it for code to be used in Athena production

AnalysisTop: small fix for using soft muons on TRUTH1 derivations

See merge request atlas/athena!44486

21.2 Adding DL1d and DIPS into FTAG2 derivations

See merge request atlas/athena!44302

Fix FPE due to log(X) where X <= 0 in jet mass calibration

See merge request atlas/athena!44419

Fixing truthTag for DL1r

See merge request atlas/athena!44342

This FPE was first seen in r22, but is present in both r21 and r22.
This commit is the r21 fix, which can then be swept into r22.
Note that the choice was made to keep the same behaviour as the current
tool, which looked for NaNs instead of preventing their creation in the
first place.  That is, negative logarithms result in a calibration factor
of 1 (no calibration) or a calibration weight of 0 (for combined mass
calibrations).

Fix typo in L3 check for NaN values

See merge request atlas/athena!44333

fix rare faulty TEnv initialization when workdir=homedir in two Egamma packages

See merge request atlas/athena!44310

Add new ttW and ttZ samples for HIGG8D1

See merge request atlas/athena!44288

Adding ghost associated HF hadrons as extra content in DAOD_PHYS in 21.2

See merge request atlas/athena!44255

Adds Electron variables and Photon AmbiguityType to HDBS2 Extra Content

See merge request atlas/athena!44043

TrigGlobalEfficiencyCorrectionTool: raising photon trigger thresholds to recommended values

See merge request atlas/athena!44060

Modification of EXOT17.py for fractionally charged particle search

See merge request atlas/athena!43719

21.2 modify electron-in-jet subtraction method

See merge request atlas/athena!43005