- 07 May, 2021 1 commit
-
-
Frank Winklmeier authored
Package only contains one testing algorithm used during early L1Topo developments.
-
- 06 May, 2021 26 commits
-
-
Vakhtang Tsulaia authored
-
Vakhtang Tsulaia authored
-
Vakhtang Tsulaia authored
TrigNavigation+TrigNavStructure+TrigSerializeCnvSvc: Race fixes. See merge request !43270
-
Vakhtang Tsulaia authored
Support tweaking and monitoring concurrency in overlay tests See merge request !43248
-
Vakhtang Tsulaia authored
Merge branch 'TrackingGeometryCondAlg_master_ensure_detector_element_cond_data_is_created' into 'master' Fix missing detector element conditions data when building the tracking geoemtry. See merge request !43265
-
Vakhtang Tsulaia authored
Extended event context retrieval fix in HepMcParticleLink Closes ATLASSIM-5123 See merge request atlas/athena!43263
-
Vakhtang Tsulaia authored
tauRecTools: improve element link handling and fix charged PFO usage in substructure reconstruction See merge request !43257
-
Vakhtang Tsulaia authored
adding weights to InDetMonitoring resolution plots See merge request !43110
-
-
Vakhtang Tsulaia authored
LArRawConditions+LArRecUtils: Fix cppcheck warnings. See merge request !43278
-
Vakhtang Tsulaia authored
TGC_CondCabling+DataModelAthenaPool: Fix cppcheck warning. See merge request !43275
-
Vakhtang Tsulaia authored
LArElecCalib: Remove ILArADC2MeVTool. See merge request !43273
-
Vakhtang Tsulaia authored
LArCalibUtils: Fix cppcheck warnings. See merge request !43183
-
scott snyder authored
Potential null pointer dereference. Suppress duplicate assignment false positive.
-
scott snyder authored
Don't pass large objects by value.
-
scott snyder authored
Prefer using preincrement for iterator classes.
-
scott snyder authored
Redundant string conversion.
-
scott snyder authored
Remove obsolete/unused ILArADC2MeVTool.
-
Andrew Mehta authored
-
Andrew Mehta authored
-
scott snyder authored
Give an error if we try to deserialize something that's already in StoreGate rather than using overwrite (except for TrigRoiDescriptorCollection). Calling overwrite() is liable to corrupt ElementLinks. See ATLASRECTS-6278 and ATEAM-734.
-
scott snyder authored
Change TrigNavStructure::m_rmutex to be a static member, as we can potentially have several instances of this class that we want to lock against each other. See ATLASRECTS-6278 and ATEAM-734.
-
scott snyder authored
Skip deserializing a blob if we've already seen it. See ATLASRECTS-6278 and ATEAM-734.
-
Goetz Gaycken authored
Ensure that detector element conditions algorithms are scheduled when adding the tracking geometry conditions alg.
-
Vakhtang Tsulaia authored
CaloJiveXML: Use SG::ConstIterator instead of DataHandle. See merge request atlas/athena!43177
-
Tadej Novak authored
-
- 05 May, 2021 13 commits
-
-
Bertrand Martin authored
Hello, This MR implements Attila's suggestion to improve the handling of element links in the tau substructure reconstruction code (ATLASRECTS-6278). The detailed explanation can be found [here](https://its.cern.ch/jira/browse/ATLASRECTS-6278?focusedCommentId=3814470&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-3814470) . The links are only used at reconstruction time, to associate various PFO types and run the substructure reconstruction. Probably, nobody ever checked whether the links were valid after they are written to AODs (and we don't write out charged PFOs anymore, which does not help), to be done soon. This part of the MR does not change the reconstruction output. The MR also fixes which charged PFOs (i.e. tau tracks) are used in the tau substructure reconstruction and shower subtraction. When we reconstruct a tau, we push its tracks in a charged PFO container, so the container is growing as we process more taus. And currently, in the shower subtraction procedure, for a given tau, we consider all the PFOs from the charged PFO container, which includes tracks from previous taus, instead of using only tracks of the current tau. It introduces a dependency on taus reconstructed upstream in the event, but this is not a bug in itself, a good track from a previous tau is a good track, and it would make sense to consider it when subtracting charged PFOs from neutral PFOs. However, rightfully using a track from another tau seems very rare (I saw 1 case in 2000 ttbar events). So I am replacing the loop over all charged PFOs in the container with a loop over the charged PFOs associated with the current tau. For completeness: with this change, we fix a very [subtle bug](https://gitlab.cern.ch/atlas/athena/-/blob/ceb26b77eb2b93b1de003b52872ae20db008339f/Reconstruction/tauRecTools/src/TauPi0ClusterScaler.cxx#L192). `dR < dRmin` should have been `dR <= dRmin`, otherwise, in case a same track is shared by tau1 and tau2, we will create chargedPFO1 when processing tau1, then chargedPFO2 when processing tau2, and in the loop over charged PFOs, we would select chargedPFO1 for tau2, as it comes first in the container, which causes some mess downstream... Cheers, Bertrand
-
Vakhtang Tsulaia authored
egammaTrackSlimmer: keep all TRT-only tracks See merge request !43237
-
-
Vakhtang Tsulaia authored
Add conversion for multiple chains in Run 2 to run 3 Nav decoder See merge request !43159
-
-
Vakhtang Tsulaia authored
Make LArFebErrorSummaryMaker reentrant See merge request !43165
-
-
Vakhtang Tsulaia authored
Fix wrong timings container in the digitisation Closes ATLASSIM-5236 See merge request !43188
-
Vakhtang Tsulaia authored
Tidy up the fast electron and photon hypo tools See merge request !43122
-
-
Vakhtang Tsulaia authored
TrigValSteering - protect against zero exec_steps when preparing exec_summary See merge request !43196
-
Vakhtang Tsulaia authored
MuonTruthAlgs: Remove unnecessary variable and fix print-out See merge request !43211
-
Vakhtang Tsulaia authored
Cleanup egamma: remove egamma covariance matrix See merge request !43223
-