1. 20 Sep, 2021 1 commit
  2. 09 Sep, 2021 1 commit
  3. 08 Sep, 2021 1 commit
  4. 01 Sep, 2021 1 commit
  5. 24 Aug, 2021 2 commits
  6. 20 Aug, 2021 2 commits
    • Rafal Bielski's avatar
      Make slicing and narrowing casts explicit · 91970608
      Rafal Bielski authored
      Make the following implicit slicing and narrowing into explicit:
      ```
      L1TopoEvent/Root/GenericTOB.cxx:30:4: warning: slicing object from type 'JetTOB' to 'BaseTOB' discards 48 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(jet)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:30:4: warning: slicing object from type 'JetTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:30:4: warning: slicing object from type 'JetTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:44:4: warning: slicing object from type 'jTauTOB' to 'BaseTOB' discards 40 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(tau)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:44:4: warning: slicing object from type 'jTauTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:44:4: warning: slicing object from type 'jTauTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:47:12: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
         , m_phi(tau.phi())
                 ^
      L1TopoEvent/Root/GenericTOB.cxx:56:4: warning: slicing object from type 'jLargeRJetTOB' to 'BaseTOB' discards 40 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(jet)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:56:4: warning: slicing object from type 'jLargeRJetTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:56:4: warning: slicing object from type 'jLargeRJetTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:59:12: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
         , m_phi(jet.phi())
                 ^
      L1TopoEvent/Root/GenericTOB.cxx:68:4: warning: slicing object from type 'jJetTOB' to 'BaseTOB' discards 40 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(jet)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:68:4: warning: slicing object from type 'jJetTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:68:4: warning: slicing object from type 'jJetTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:71:12: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
         , m_phi(jet.phi())
                 ^
      L1TopoEvent/Root/GenericTOB.cxx:80:4: warning: slicing object from type 'ClusterTOB' to 'BaseTOB' discards 44 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(cluster)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:80:4: warning: slicing object from type 'ClusterTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:80:4: warning: slicing object from type 'ClusterTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:92:4: warning: slicing object from type 'eEmTOB' to 'BaseTOB' discards 56 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(eem)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:92:4: warning: slicing object from type 'eEmTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:92:4: warning: slicing object from type 'eEmTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:95:12: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
         , m_phi(eem.phi())
                 ^
      L1TopoEvent/Root/GenericTOB.cxx:107:4: warning: slicing object from type 'eTauTOB' to 'BaseTOB' discards 56 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(etau)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:107:4: warning: slicing object from type 'eTauTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:107:4: warning: slicing object from type 'eTauTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:110:12: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
         , m_phi(etau.phi())
                 ^
      L1TopoEvent/Root/GenericTOB.cxx:122:4: warning: slicing object from type 'MuonTOB' to 'BaseTOB' discards 80 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(muon)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:122:4: warning: slicing object from type 'MuonTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:122:4: warning: slicing object from type 'MuonTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:139:4: warning: slicing object from type 'LateMuonTOB' to 'BaseTOB' discards 40 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(lateMuon)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:139:4: warning: slicing object from type 'LateMuonTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:139:4: warning: slicing object from type 'LateMuonTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:151:4: warning: slicing object from type 'MuonNextBCTOB' to 'BaseTOB' discards 40 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(muonNextBC)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:151:4: warning: slicing object from type 'MuonNextBCTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:151:4: warning: slicing object from type 'MuonNextBCTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:165:4: warning: slicing object from type 'MetTOB' to 'BaseTOB' discards 40 bytes of state [cppcoreguidelines-slicing]
         BaseTOB(met)
         ^
      L1TopoEvent/Root/GenericTOB.cxx:165:4: warning: slicing object from type 'MetTOB' to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/GenericTOB.cxx:165:4: warning: slicing object from type 'MetTOB' to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
      L1TopoEvent/Root/MuonTOB.cxx:26:13: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
         , m_phi( sizeCheck(phi, nBitsPhi()) )
                  ^
      /workspaces/build/../athena/Trigger/TrigT1/L1Topo/L1TopoEvent/L1TopoEvent/JetTOB.h:36:46: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
            int energy(JetSize js ) const { return js==JS1?m_Et1:m_Et2; }
                                                   ^
      /workspaces/build/../athena/Trigger/TrigT1/L1Topo/L1TopoEvent/L1TopoEvent/JetTOB.h:37:42: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
            int Et(JetSize js ) const { return js==JS1?m_Et1:m_Et2; }
      ```
      91970608
    • Rafal Bielski's avatar
      6d5c7905
  7. 17 Aug, 2021 2 commits
  8. 10 Aug, 2021 2 commits
  9. 07 Aug, 2021 1 commit
  10. 06 Aug, 2021 1 commit
  11. 03 Aug, 2021 1 commit
  12. 29 Jun, 2021 2 commits
  13. 23 Jun, 2021 2 commits
  14. 22 Jun, 2021 3 commits
  15. 16 Jun, 2021 1 commit
  16. 15 Jun, 2021 1 commit
  17. 14 Jun, 2021 1 commit
  18. 09 Jun, 2021 1 commit
  19. 08 Jun, 2021 1 commit
  20. 31 May, 2021 1 commit
  21. 28 May, 2021 1 commit
  22. 26 May, 2021 1 commit
  23. 25 May, 2021 1 commit
  24. 24 May, 2021 1 commit
  25. 12 May, 2021 2 commits
  26. 07 May, 2021 2 commits
  27. 03 May, 2021 1 commit
  28. 28 Apr, 2021 1 commit
  29. 26 Apr, 2021 1 commit
  30. 22 Apr, 2021 1 commit