GitLab

Antonio De Maria authored Jun 18, 2021 and Frank Winklmeier committed Jun 18, 2021

use HLT tau vertex instead of beamspot in the TauTrackFinder + adding HypoTool monitoring histograms

In topoEgammaBuilder, defer the creation of the
electronPearShapeAlignmentCorrection object from the ctor to initialize().
The electronPearShapeAlignmentCorrection ctor reads a data file,
but that's not something we generally want happening in constructors
for Gaudi components, which get run at build time during genconf, etc.

This FPE was first seen in r22
(https://its.cern.ch/jira/browse/ATR-23551), but is present in both r21
and r22. The original commit was the r21 fix, but the automatic sweep
to r22 failed.  This is a manual sweep of the same changes, where it
looks like the sweep failed because of white-space differences between
the r21 and r22 version of the file being modified.

The original r21 MR is !44419

Remove reference to nonexistent file.

As part of implementing my first dual-use service I decided that the
existing macros are not quite as elegant as I hoped, and also don't
match gaudi mechanisms as closely as I would have liked.

I also updated the dual-use service configuration, so that it works
nicely in a dual-use setting.

Don't try to build the same sources into more than one library.

Christos Anastopoulos authored Jun 15, 2021 and Frank Winklmeier committed Jun 15, 2021

MaterialEffectsOnTrack: Use optional for the Scattering angles, and unique_ptr for the energy Loss. Migrate clients to passing Scattering angles accordingly so as to avoid too many allocations

A few containers being thinned here didn't exist in r21.
This causes us to crash if we're run on a r21 ESD.
Protect against this.

tauEventTPCnv_15.0.0_test.py - passes
tauEventTPCnv_15.6.9_test.py - passes
tauEventTPCnv_17.2.9.1_test.py - passes
tauEventTPCnv_18.0.0_test.py - passes

egammaEventTPCnv_15.1.0_test.py - passes
egammaEventTPCnv_15.6.9_test.py - passes
egammaEventTPCnv_16.6.7.1_test.py - passes
egammaEventTPCnv_18.0.0_test.py - passes

TrackParticleTruthTPCnv_18.0.0_test.py - passes

RecTPCnv_15.0.0_test.py - passes
RecTPCnv_15.6.1_test.py - passes
RecTPCnv_17.0.6_test.py - passes
RecTPCnv_18.0.0_test.py - passes

`TrackParticleTPCnv_16.6.3_test` - passes
`TrackParticleTPCnv_17.2.8_test` - passes
`TrackParticleTPCnv_18.0.0_test` - passes

2) More info in README
3) V2TCalibration configuration for producing ntuples for V2T classification BDT training

Hello,

This MR is implementing a configuration for jet seeding + tau thinning that is closer to what we will use in the R22 reprocessing, namely:

* no JES-calibrated pt cut on the AntiKt4LCTopoJets used to seed the tau reconstruction
* a tau pt cut applied to the MVA tau pt at the end of the tau reconstruction, to thin the tau containers before writing them out to AOD

The tau thinning cut will be fine tuned, for now it's a simple 10 GeV pt cut.
This will lead to a significant increase in CPU as we will now run the tau reconstruction on all seed jets, not only on those with pt>15 GeV.
The impact on the AOD size depends on the MVA energy resolution and other factors that are still being tuned.
We expect to see changes in SPOT plots (ATLASRECTS-5684).

Cheers,
Bertrand

Apparently ordering by r only is insufficient to ensure that RPC hits with different doublet phi values are separated.
The MuGirl hit ordering now explicity checks the RPC dbPhi before falling back to the r value.
This should remove duplicate hits warnings such as the one reported in ATLASRECTS-6369.

Reconstructing bytestream created from MC is likely not used anymore.
For sure, the trigger flags set here no longer work. If this is a valid
use-case it needs to be migrated for Run-3.