GitLab

Joerg Stelzer authored Feb 21, 2020 and Walter Lampl committed Feb 21, 2020

Also refactor LVL1ConfigSvc a bit to clearly separate Run2 and Run3 menu
loading

* Enable creation of a default L1PrescaleSet file
* create a joboptions json file that is modified for db upload

The prescaling happens according to the HLTPrescaleSet

- print function

During reconstruction the menu is only available at the first event.
Histogram initialization and creation of some helper structures
(ItemMap, ThresholdMap) have been delayed to the first event.

Item logic when read from COOL needs to be reconstructed.

Histograms from CTPSimulation have been added to output hists file, but
are still missing metadata for merging

Prior all DataStructure-derived classes were holding a copy of the
ptree that they were constructed from. Now they hold either a
reference (ptree*) or own the original (shared_ptr<ptree>).

Basically the objects L1Menu, HLTMenu, and L1-/HLTPrescaleSet will hold
the ptree created from the json files. All sub structures will only have
a pointer to the sub-tree which is part of the big ptree.

This avoids copying ptree's around and inflating the size of the menu.
One has to be carefull when creating the sub-structure and only pass
references to sub-trees of the original tree to the constructors.

 - Missing override keywword.
 - Unused private data member.

Joerg Stelzer authored Jan 28, 2020 and Adam Edward Barton committed Jan 28, 2020

Prior all DataStructure-derived classes were holding a copy of the
ptree that they were constructed from. Now they hold either a
reference (ptree*) or own the original (shared_ptr<ptree>).

Basically the objects L1Menu, HLTMenu, and L1-/HLTPrescaleSet will hold
the ptree created from the json files. All sub structures will only have
a pointer to the sub-tree which is part of the big ptree.

This avoids copying ptree's around and inflating the size of the menu.
One has to be carefull when creating the sub-structure and only pass
references to sub-trees of the original tree to the constructors.

Move hashing functions out of this package, rename remaining helpers to instead be under the HLTTEUtils class

move tests to new home, update header guards, move python calls. DecisionHandling.TrigCompositeUtils -> TrigCompositeUtils.TrigCompositeUtils

Use `Python_.*` variables instead of the non-standard `PYTHON_.*`.

clang warning: signed/unsigned comparison.

Replace `PythonLibs` and `PythonInterp` to the corresponding
`find_package( Python ... )` calls. And remove the dependency entirely
where not necessary.

print function.
functions removed from string module.

 - print function
 - int/long
 - syntax for catching and raising exceptions
 - xrange -> range
 - file -> open; use binary files for pickles.
 - cmp
 

Retrieving a DataHandle is deprecated.
This will give a thread-safety warning soon,
so change it to an ordinary retrieve.

- print function

long fixes

Joerg Stelzer authored Dec 12, 2019 and Walter Lampl committed Dec 12, 2019

L1 trigger software can use these packages setting
set( BuildWithoutAthena True )

Package contains scripts to upload the trigger configuration to the
Run-1/2 trigger database, which is being completely replaced in Run-3.

Remove some unused, deprecated methods.

cppcheck warnings:
  - Uninitialized member variables.
  - Prefer preincrement to postincrement for iterators.
  - Prefer using the init-list to initializing members in constructors.
  - Pass std::string by const reference, not by value.
  

Updated `ComponentAccumulator` configuration tests which dump the configuration
to a pickle file. In python3 the output file needs to be explicitly opened in binary mode.
I.e. ```f = open('configdump.pkl','wb')```
rather than ```f = open('configdump.pkl','w')```