1. 01 Jul, 2021 1 commit
  2. 30 Jun, 2021 2 commits
  3. 28 Jun, 2021 4 commits
  4. 25 Jun, 2021 1 commit
  5. 24 Jun, 2021 3 commits
  6. 23 Jun, 2021 1 commit
  7. 22 Jun, 2021 2 commits
  8. 18 Jun, 2021 18 commits
    • Nils Krumnack's avatar
      avoid an overload warning in AthAnalysis · dbd77f95
      Nils Krumnack authored
      dbd77f95
    • Nils Krumnack's avatar
      allow python configurables to add themselves to EventLoop job objects · f531e432
      Nils Krumnack authored
      The ultimate goal here is to have the python configurable no longer
      inherit from the C++ object, and instead create the C++ object only at
      the moment when it is needed, instead of having it as a base class and
      performing all updates simultaneously to the python object and the C++
      object (to keep them in sync).  However, for now it mostly adds an
      alternate way of adding algorithms to jobs, to actually make the more
      fundamental change to the configurables would require all users to
      update to the new formalism of adding algorithms to jobs.
      
      This also allows additional configurable objects to be used, e.g. I
      now treat algorithm sequences and algorithms the same.
      
      This could potentially also be used to change the target or mechanism
      of configuration at some point, e.g. to push this into an intermediate
      JSON file, but that's not an immediate goal.
      f531e432
    • Nils Erik Krumnack's avatar
      rework subtools in AsgComponentConfig (was wrap AnaToolHandle around AsgToolConfig) · 4a6a0176
      Nils Erik Krumnack authored
      Since I'm back-porting to 21.2 I didn't modify the AnaToolHandle
      implementation, but I did update AsgComponentConfig accordingly.
      
      Original commit message:
      
      The basic reasoning here is that AnaToolHandle is essentially the
      out-dated and discouraged mechanism for creating tools, and has been
      replaced with AsgToolConfig for quite a while (or alternatively
      indirectly via AnaAlgorithmConfig).
      
      I did have to disable some Athena tests for setting sub-tools in
      Athena.  There are already some of those disabled, and the basic logic
      is that since this is the legacy way of doing things, unless this
      breaks existing code (as verified by CI tests) I no longer want to
      support all the possible edge cases in this rather brittle and complex
      piece of code.
      4a6a0176
    • Nils Krumnack's avatar
      remake SysListLoaderAlg into SystematicsSvc · fa68ca0d
      Nils Krumnack authored
      For now this just replaces the algorithm with a service, and
      communicates the systematics list via the service interface instead of
      via the event store.
      
      The plan is to add more functionality in future merge requests that
      will move a lot of the systematics handling functionality from the
      configuration layer into the service.
      fa68ca0d
    • Nils Krumnack's avatar
      rework AsgService interface declarations and configuration · b6a90dd4
      Nils Krumnack authored
      As part of implementing my first dual-use service I decided that the
      existing macros are not quite as elegant as I hoped, and also don't
      match gaudi mechanisms as closely as I would have liked.
      
      I also updated the dual-use service configuration, so that it works
      nicely in a dual-use setting.
      b6a90dd4
    • Nils Krumnack's avatar
      fix compilation error in AnaAlgorithm package · 492e1f73
      Nils Krumnack authored
      That was introduced by two recent merge requests crossing.
      492e1f73
    • scott snyder's avatar
      AsgTools: Fix cppcheck warnings. · 8cadf793
      scott snyder authored
      Don't let cppcheck see the #error directives.
      8cadf793
    • Pierre Antoine Delsart's avatar
      344b732f
    • Nils Krumnack's avatar
      introduce PythonConfig and EL::PythonConfigBase · 51b75b25
      Nils Krumnack authored
      The goal here is to introduce a single python configurable in
      AnalysisBase, instead of the current scheme in which there is a
      separate configurable for AnaAlgorithm, AsgTool, etc. and essentially
      duplicating a lot of code.
      
      For now this duplicates even more code.  Once this is all tested and
      validated, the old code will eitehr be completely removed or made to
      inherit from the new classes.
      51b75b25
    • Nils Krumnack's avatar
      switch unit test to using LocalDriver · 697e7375
      Nils Krumnack authored
      Mostly so that it acts as a test of whether the EventLoop python
      configuration would work properly on the grid.
      697e7375
    • Nils Krumnack's avatar
      add missing dictionary for AsgComponentConfig · 138ddd79
      Nils Krumnack authored
      I thought I had added all missing dictionaries, but there is one
      missing here.
      138ddd79
    • Nils Krumnack's avatar
      fix the "inline" constructor for ServiceHandle · 41259fa2
      Nils Krumnack authored
      That was more or less a copy-paste error of a template function that
      was never instantiated.
      41259fa2
    • Nils Krumnack's avatar
      add a addPrivateToolInArray function to DualUseConfig.py · 25e7beb4
      Nils Krumnack authored
      Unfortunately I don't have a really good way to test if it works, but
      the underlying C++ is tested, and this is hopefully a close enough
      duplication of what's happening for non-array tools that this is good
      enough.
      
      Originally I tried to do something more involved, but that became sort
      of tedious given the logic of the python class.  Maybe at some point I
      will come back and restructure the python class somewhat.  Hopefully
      this is still workable as is.
      25e7beb4
    • Nils Krumnack's avatar
      fix AnalysisBase grid submission problems introduced with !42411 · 6b7e137b
      Nils Krumnack authored
      The changes introduced in !42411 required additional dictionaries to
      serialize any of the component configuration objects, which were not
      defined in that merge request.  This is (apparently) not caught in any
      unit tests, but it leads to any sub-tools to be stripped off
      algorithms during batch and grid submission.
      
      This MR should fix that by defining one dictionary and changing the
      type of one member variable to avoid the need for the second.  At some
      point a new test should be defined to catch these problems in CI, or
      at least in the nightly tests, but for now having a quick fix seemed
      more important.
      6b7e137b
    • Nils Krumnack's avatar
      introduce StandaloneToolHandle · ca35da43
      Nils Krumnack authored
      This is meant as a drop-in replacement for `AnaAlgorithm` in
      standalone applications that don't need most of its advanced features
      and just need an easy way to configure and create a public tool.
      ca35da43
    • Nils Erik Krumnack's avatar
      change handling of sub-tools, allow configuring ToolHandleArray properties · 6be59910
      Nils Erik Krumnack authored
      Originally the goal was just to allow handling `ToolHandleArray`
      properties, but it turned out to be a lot easier if subtools are
      represented by `AsgToolConfig` in turn.
      6be59910
    • Christos Anastopoulos's avatar
      AsgServices add ATLAS_CHECK_THREAD_SAFETY. 1st it passes it . 2nd we inherit... · 9fed78e9
      Christos Anastopoulos authored
       AsgServices add ATLAS_CHECK_THREAD_SAFETY. 1st it passes it . 2nd we inherit now from it for code to be used in Athena production
      9fed78e9
    • Nils Erik Krumnack's avatar
      Merge branch '21.2-fixSoftMuonsOnTruth1' into '21.2' · 71f6094b
      Nils Erik Krumnack authored
      AnalysisTop: small fix for using soft muons on TRUTH1 derivations
      
      See merge request !44486
      71f6094b
  9. 17 Jun, 2021 3 commits
  10. 16 Jun, 2021 3 commits
  11. 15 Jun, 2021 2 commits
    • Oana Vickey Boeriu's avatar
      Merge branch 'fdibello_ttFix' into '21.2' · 48d8572f
      Oana Vickey Boeriu authored
      Fixing truthTag for DL1r
      
      See merge request !44342
      48d8572f
    • Steven Schramm's avatar
      Fix FPE due to log(X) where X <= 0 in JMS calib · 3eb03f2a
      Steven Schramm authored
      This FPE was first seen in r22, but is present in both r21 and r22.
      This commit is the r21 fix, which can then be swept into r22.
      Note that the choice was made to keep the same behaviour as the current
      tool, which looked for NaNs instead of preventing their creation in the
      first place.  That is, negative logarithms result in a calibration factor
      of 1 (no calibration) or a calibration weight of 0 (for combined mass
      calibrations).
      3eb03f2a