athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-07-08T19:01:40+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/2465321.2 remove elec charge eff corr tool from fill electron2019-07-08T19:01:40+02:00Alexander Armstrong21.2 remove elec charge eff corr tool from fill electronRequested update on previous merge request: https://gitlab.cern.ch/atlas/athena/merge_requests/24480
The second-to-last commit involves hard coding the validity range of the tool.
The last commit removed this in favor of leaving a comm...Requested update on previous merge request: https://gitlab.cern.ch/atlas/athena/merge_requests/24480
The second-to-last commit involves hard coding the validity range of the tool.
The last commit removed this in favor of leaving a comment and silently setting SF = 1 if the lepton is out of the tools validity range.
In either case, there will be no WARNING messages printed if the provided lepton is out of the validity range unless running with DEBUG message level.https://gitlab.cern.ch/atlas/athena/-/merge_requests/2443321.2: Fix some uninitialized member variables2019-06-25T23:13:36+02:00Adam Edward Barton21.2: Fix some uninitialized member variablesFix some uninitialized member variables, in a not widely used algorithm.
cc @wwalkoFix some uninitialized member variables, in a not widely used algorithm.
cc @wwalkohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24329Add quark/gluon tagging variables to STDM3, STDM4, STDM52019-06-19T23:45:58+02:00Evgeny SoldatovAdd quark/gluon tagging variables to STDM3, STDM4, STDM5This modifies STDM3, STDM4 and STDM5 adding the quark/gluon tagging variables (both BDT-based and non-BDT-based) for AntiKt4EMTopoJets and AntiKt4EMPFlowJets.
This new information is useful for ongoing and future SM VBF/VBS analyses.This modifies STDM3, STDM4 and STDM5 adding the quark/gluon tagging variables (both BDT-based and non-BDT-based) for AntiKt4EMTopoJets and AntiKt4EMPFlowJets.
This new information is useful for ongoing and future SM VBF/VBS analyses.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20947WIP: TrackParticle Compression Update, 21.2 branch (2019.02.06.)2019-06-17T11:06:12+02:00Attila KrasznahorkayWIP: TrackParticle Compression Update, 21.2 branch (2019.02.06.)This will need a **lot** of description...
This MR is meant to help with !20144, providing a generalisation of what that MR was/is trying to do. For this I made some significant changes to `xAODMaker::TrackParticleCompressorTool`, which...This will need a **lot** of description...
This MR is meant to help with !20144, providing a generalisation of what that MR was/is trying to do. For this I made some significant changes to `xAODMaker::TrackParticleCompressorTool`, which is used by the `xAOD::TrackParticleAuxContainer` POOL converter.
I started experimenting with some complications in the tool. My goal would be to be able to define multiple rules for how the compression should go. To be able to specify rules specific to
- streams;
- containers;
- selections on objects inside the container.
So, to be able to set up something like let's say:
- For DAOD_PHYSLITE/InDetTrackParticles:
* For pT > 10 GeV reduce the precision on the off-diagonal covariance matrix elements;
* For 5 < pT < 10 GeV drop the off-diagonal elements, and reduce the precision of the diagonal ones;
* For pT < 5 GeV drop all covariance matrix elements.
- For DAOD_PHYS/InDetForwardTrackParticles:
* Use the above settings...
- For DAOD_PHYS/InDetTrackParticles:
* Use something a bit more forgiving...
Which seemed like a nice idea... But as you can see, the code turned out pretty complicated. :frowning:
I'll list some more technicalities/concerns in further comments, but let me just state that things seem to work like this. Using a Zee test sample as input, I was able to get these results:
- Original size 337.9 kB/event, with the covariance matrix taking up 42.7 kB/event.
- When just compressing the off-diagonal elements, as we did during the AOD size reduction efforts, we get 328.1 kB/event, with the covariance matrix taking up 32.8 kB/event. I.e. not super impressive.
- With the "aggressive compression" outlined above, I got down to 295.7 kB/event, with the covariance matrix taking up just ~0.5 kB/event.
So there seems to be reason for doing complicated stuff like this. :wink:
Tagging relevant people: @jcatmore, @mnowak, @gemmeren.https://gitlab.cern.ch/atlas/athena/-/merge_requests/24212WIP: Add syst for r21 vs r20.7 differences to defaults2019-06-15T00:07:15+02:00Federico SforzaWIP: Add syst for r21 vs r20.7 differences to defaultsDear all,
this merge request updates the default calibration files to "Recs2019_05_30", which include an additional systematic uncertainty extracted from the MC-to-MC comparison of rel20.7 vs rel21.
The studies are documented here: htt...Dear all,
this merge request updates the default calibration files to "Recs2019_05_30", which include an additional systematic uncertainty extracted from the MC-to-MC comparison of rel20.7 vs rel21.
The studies are documented here: https://indico.cern.ch/event/784539/contributions/3449224/attachments/1852942/3042527/190528_r21_vs_r20p7.pdf
Several analyses (e.g. H->mm) are already using this systematic uncertainty, that was indeed needed from some time.
Best,
Federico (for MCP)https://gitlab.cern.ch/atlas/athena/-/merge_requests/24210WIP: Add syst for r21 vs r20.7 differences to defaults2019-06-14T23:40:20+02:00Federico SforzaWIP: Add syst for r21 vs r20.7 differences to defaultsDear all,
this merge request updates the default calibration files to "Recs2019_05_30", which include an additional systematic uncertainty extracted from the MC-to-MC comparison of rel20.7 vs rel21.
The studies are documented here:...Dear all,
this merge request updates the default calibration files to "Recs2019_05_30", which include an additional systematic uncertainty extracted from the MC-to-MC comparison of rel20.7 vs rel21.
The studies are documented here: https://indico.cern.ch/event/784539/contributions/3449224/attachments/1852942/3042527/190528_r21_vs_r20p7.pdf
Several analyses (e.g. H->mm) are already using this systematic uncertainty, that was indeed needed from some time.
Best,
Federico (for MCP)https://gitlab.cern.ch/atlas/athena/-/merge_requests/20144WIP: Tool for decorating ID tracks with a covariance matrix2019-06-07T18:03:13+02:00James CatmoreWIP: Tool for decorating ID tracks with a covariance matrixThis tool can be used to decorate ID tracks with a covariance matrix, according to some criteria, for writing into DAODs. The eventual aim is to drop the full covariance from the tracks at DAOD level and instead rely on these decorations...This tool can be used to decorate ID tracks with a covariance matrix, according to some criteria, for writing into DAODs. The eventual aim is to drop the full covariance from the tracks at DAOD level and instead rely on these decorations, for which the full matrix would only be written for a small subset of tracks. Since the criteria for writing or not writing the covariance is not yet agreed (currently it is association with a primary vertex) and since it is not yet clear whether decoration with a new matrix or modification of the existing one is the best approach, this is left as WIP for now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23873(ATLSUSYDPD-1919) added TruthWZ jets2019-06-03T15:46:47+02:00Rachael Ann Creager(ATLSUSYDPD-1919) added TruthWZ jetsAdded `AntiKt4TruthWZJets` to SUSY1. 3.2% size increase per event (see JIRA for more information).Added `AntiKt4TruthWZJets` to SUSY1. 3.2% size increase per event (see JIRA for more information).Rachael Ann CreagerRachael Ann Creagerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23333downgrade warning to INFO since it doesn't seem important2019-05-23T11:09:44+02:00Dan Guestdowngrade warning to INFO since it doesn't seem importantHaving spent a while trying to track down the meaning of this warning
```
ToolSvc.SUSYTools WARNING Your baseline tau - lep OR/Veto settings look suspicious! You have enabled tau-e/mu OR (cone based), but set (EleOLR,MuonOLR)=(0,0) i...Having spent a while trying to track down the meaning of this warning
```
ToolSvc.SUSYTools WARNING Your baseline tau - lep OR/Veto settings look suspicious! You have enabled tau-e/mu OR (cone based), but set (EleOLR,MuonOLR)=(0,0) in your config file! PLEASE CHECK!
```
I can only conclude that this isn't very important: quoting a few people I've asked, we have (@ykeisuke)
```
Just ignoring the warning or set tau-lep OR to false should eliminate the warning
```
and according to @jojungge
```
In principle, you buy the risk of fake-taus which are in fact electrons or muons. I've observed this as well in the XAMPPmultilep && XAMPPstau packages and ignored it quite successful
```
I don't think we should have warnings if the expert advice is to ignore them, so I'm changing it to `INFO`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23233Add mt2 package2019-05-20T12:04:33+02:00Dan GuestAdd mt2 packageThis tool is used by a lot of people, but for some reason it's not part of a release. Maybe we should add it?
Pinging @bnachman, @lester, @zmarshal, @jojunggeThis tool is used by a lot of people, but for some reason it's not part of a release. Maybe we should add it?
Pinging @bnachman, @lester, @zmarshal, @jojunggehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23110Remove error message if files from dev area loaded2019-05-12T10:04:47+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRemove error message if files from dev area loadedHi @akraszna,
in the MuonPerformanceAnalysis we've introduced now the pile-up reweighting during n-tuple production since the run-II data-taking is over. In order not to maintain our own config files, we'd like to rely on the central ...Hi @akraszna,
in the MuonPerformanceAnalysis we've introduced now the pile-up reweighting during n-tuple production since the run-II data-taking is over. In order not to maintain our own config files, we'd like to rely on the central files maintained by the SUSY group. The problem is that the `PathResolver` is prompting an Error message in `AthDerivation` making our jobs to fail on the grid.
I've removed the `ifdef flag` in this MR such that we can also use the central pile-up and cross-section files from `AthDerivation`
Tagging: @fsforza, @szambito, @egramsta, @guirriec, @boeriu, @krumnack, @nkoehler https://gitlab.cern.ch/atlas/athena/-/merge_requests/21857WIP: Externals Update, 21.2 branch (2019.03.12.)2019-04-16T16:50:47+02:00Attila KrasznahorkayWIP: Externals Update, 21.2 branch (2019.03.12.)Updated all projects to [atlasexternals-1.0.49](https://gitlab.cern.ch/atlas/atlasexternals/tags/1.0.49). The full list of changes (https://gitlab.cern.ch/atlas/atlasexternals/compare/1.0.48...1.0.49) is:
- Added `FindHJets.cmake` for...Updated all projects to [atlasexternals-1.0.49](https://gitlab.cern.ch/atlas/atlasexternals/tags/1.0.49). The full list of changes (https://gitlab.cern.ch/atlas/atlasexternals/compare/1.0.48...1.0.49) is:
- Added `FindHJets.cmake` for finding the HJets generator (meant for the 21.6 branch, should not affect this one);
- Fixed the generation of `.d` files for Ninja, to make dictionary generation behave correctly with this build tool (thanks to @fwinkl);
- Added some extra python find-modules to AtlasLCG;
- Stopped setting up the `Cairo` and `Pango` packages when using `graphviz`.
The last one is meant to get [emacs](https://www.gnu.org/software/emacs/) to work once again in the AthAnalysis/AthDerivation runtime environment. Note that this should make it unnecessary to rely on the alias set up by asetup. Though keeping that alias around will not hurt.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20489WIP: Add new electron iso track core subtraction2019-04-10T16:09:50+02:00Matthew Henry KleinWIP: Add new electron iso track core subtractionAdds updated electron track core calculators and adds them to electron smart slimming list. This is a work in progress and may change.Adds updated electron track core calculators and adds them to electron smart slimming list. This is a work in progress and may change.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22511ATLSUSYDPD-1850 21.2 Add Xbb Tagger to SUSY12019-04-09T04:09:53+02:00Rachael Ann CreagerATLSUSYDPD-1850 21.2 Add Xbb Tagger to SUSY1Adding Xbb tagging for VR jets to SUSY1 for fully-hadronic electroweak SUSY group studies. Size increase documented in JIRA ticket (ATLSUSYDPD-1850)Adding Xbb tagging for VR jets to SUSY1 for fully-hadronic electroweak SUSY group studies. Size increase documented in JIRA ticket (ATLSUSYDPD-1850)Jeff DandoyJeff Dandoyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21543fix bug for missing jets in ttH mode2019-03-15T11:02:16+01:00R D Schafferfix bug for missing jets in ttH modeIn H4l, we were comparing the STXS truth jets vs AntiKt4TruthWZJets and noticed that for ttH that the jets coming from some of the W's were missing. This is because the ttH W's collected were not the last one in the parent/child hierarch...In H4l, we were comparing the STXS truth jets vs AntiKt4TruthWZJets and noticed that for ttH that the jets coming from some of the W's were missing. This is because the ttH W's collected were not the last one in the parent/child hierarchy and so they failed the test that the W's must have quark as children.
I know that @nberger and @okiverny are working on a new version, so this fix should be incorporated there as well. Also I see that @zmarshal put in this version...
This is used in the derivation release.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21837Switching to expert tagger list for VRTrackjets for adding flipped taggers2019-03-12T10:16:45+01:00Sanmay GangulySwitching to expert tagger list for VRTrackjets for adding flipped taggersChanging the taggerlist for VRTrackjets from StandardTaggers to ExpertTaggers in order to include flipped taggersChanging the taggerlist for VRTrackjets from StandardTaggers to ExpertTaggers in order to include flipped taggershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21705Revert "Merge branch 'athena-my21.2-2019-03-06' into '21.2'"2019-03-07T14:57:31+01:00Nils Erik KrumnackRevert "Merge branch 'athena-my21.2-2019-03-06' into '21.2'"This reverts merge request !21691
That one broke stuff, so let's revert it.This reverts merge request !21691
That one broke stuff, so let's revert it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21115SUSY15 modifications for VH4b Analysis2019-02-26T14:19:04+01:00Amber Roepe-GierSUSY15 modifications for VH4b AnalysisProposed modification of SUSY15.py file in the SUSY Derivation Framework. The motivations, code changes, and size increases can be found in the attached slides. Please let us know of any feedback![SUSY15_Modification.pdf](/uploads/2d2298...Proposed modification of SUSY15.py file in the SUSY Derivation Framework. The motivations, code changes, and size increases can be found in the attached slides. Please let us know of any feedback![SUSY15_Modification.pdf](/uploads/2d229836f2d1858512b173a135d6d1ab/SUSY15_Modification.pdf) @jstupak @verducci @leejrhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20973WIP: Adding tool to retrieve generator level MET2019-02-22T10:03:20+01:00Jon BurrWIP: Adding tool to retrieve generator level METI added a new tool that adds the generator level MET as a float.
I also figured out/remembered that the generator level particles all have barcodes less than 10000 so I put a mode into the tool that calculates it either way. I double ch...I added a new tool that adds the generator level MET as a float.
I also figured out/remembered that the generator level particles all have barcodes less than 10000 so I put a mode into the tool that calculates it either way. I double checked by running over 10000 events of one of the filtered samples and the MET values were always exactly equal and bounded by the expected filter values, so we can probably just pick one version and stick with it.
Adding @dguest, @sargyrop and @anghosh for comments.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20798Updating EXOT27 to include inputs for TAR jets2019-02-20T00:25:54+01:00Jason Robert VeatchUpdating EXOT27 to include inputs for TAR jetsThis adds the necessary anti-kt R = 0.2 jets and associated tracks for TAR jets to EXOT27 for use in the mono-S(WW) analysis. Please see https://its.cern.ch/jira/browse/AMH-59 for more details. Additionally, anti-kt R = 0.2 jet calibra...This adds the necessary anti-kt R = 0.2 jets and associated tracks for TAR jets to EXOT27 for use in the mono-S(WW) analysis. Please see https://its.cern.ch/jira/browse/AMH-59 for more details. Additionally, anti-kt R = 0.2 jet calibrations are added to ExtendedJetCommon. These calibrations are not used in these changes to EXOT27, but may be useful in future modifications or other derivations. Minor issues in the comments in DeltaRTool that were found are also fixed.
Tagging @fnapolit, @dguest, and @jburr.