athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2018-12-20T03:03:36+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20009Add Tau slice for Physics Validation ART2018-12-20T03:03:36+01:00Alexander MannAdd Tau slice for Physics Validation ARTAdding Tau slice (and Summary) for weekly PhysVal tests in ART.Adding Tau slice (and Summary) for weekly PhysVal tests in ART.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20093Adds missing L1 triggers to MC skim for H5D32018-12-30T03:02:31+01:00Matthew Henry KleinAdds missing L1 triggers to MC skim for H5D3Adds 2017-18 L1 triggers for MC skim for HIGG5D3.Adds 2017-18 L1 triggers for MC skim for HIGG5D3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20023New map in ElectronEfficiencyCorrection and example for 2e17 in TrigGlobalEff...2019-01-03T11:24:25+01:00Philip SommerNew map in ElectronEfficiencyCorrection and example for 2e17 in TrigGlobalEfficiencyCorrectionChanges related to an update in the trigger scale factors:
- new map file in ElectronEfficiencyCorrection which includes the full set of supported electron triggers, see ATR-18843, ATR-18903
- amongst others, this includes the 2e17 diel...Changes related to an update in the trigger scale factors:
- new map file in ElectronEfficiencyCorrection which includes the full set of supported electron triggers, see ATR-18843, ATR-18903
- amongst others, this includes the 2e17 dielectron trigger which was accidentally prescaled for a short period in 2017, see discussion in ATR-17746
- a small example how the scale factors for 2e17 can be used in TrigGlobalEfficiencyCorrection
Cheers,
Philip and @jmaurer, @thrynova, @fernandohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20120Add track selection to DL22019-01-05T03:02:43+01:00Dan GuestAdd track selection to DL2We train IPRNN with a track selection similar to IP3D. In DL2 there
was previously no way to apply a track selection, so I've added it
with this commit. For now there are two hardcoded track selections:
- ALL: select all the tracks.
-...We train IPRNN with a track selection similar to IP3D. In DL2 there
was previously no way to apply a track selection, so I've added it
with this commit. For now there are two hardcoded track selections:
- ALL: select all the tracks.
- IP3D_2018: what we were using in IP3D around the end of 2018.
As with many of the DL2 input behaviors, the track order is currently
determined via regexes that parse the NN file. The list of regular
expressions is currently hardcoded in DL2HighLevel.cxx.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20160Updating electron trigger efficiency SF maps in AT2019-01-05T03:02:44+01:00Baptiste Ravinabaptiste.ravina@cern.chUpdating electron trigger efficiency SF maps in ATImplement update in egamma recommendations, see !20023.Implement update in egamma recommendations, see !20023.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20048Add Fake tau Task force variables2019-01-07T12:23:53+01:00Luca FioriniAdd Fake tau Task force variablesNew tool to add variables for the Tau Fake Task Force both in Derivations and THOR.
* Added a **TauRecTool** to add tau width variable to xAOD
* Added **TauAODProcessor** configured to run over AOD and that only loads this tool
* Ad...New tool to add variables for the Tau Fake Task Force both in Derivations and THOR.
* Added a **TauRecTool** to add tau width variable to xAOD
* Added **TauAODProcessor** configured to run over AOD and that only loads this tool
* Added call in **DerivationFrameworkTau/TauCommon.py** to load the TauAODProcessor.
* Added variable in **DerivationFrameworkTau/TauJetsCPContent.py
All problems are now solved, thanks in particular to @fscutti
@martindl : Do you want to remove the same variable from **DerivationFrameworkSUSY** in the same MR? https://gitlab.cern.ch/atlas/athena/-/merge_requests/20216TauAnalysisTools: Add support for RNN based Tau ID2019-01-09T03:03:21+01:00David KirchmeierTauAnalysisTools: Add support for RNN based Tau IDThis MR adds support for RNN based Tau ID in the TauSelectionTool (jira issue: ATLTAU-1607).
TauSelectionTool is now able to apply cuts on 4 new ID working points: JETIDRNNVERYLOOSE, JETIDRNNLOOSE, JETIDRNNMEDIUM, JETIDRNNTIGHT.
O...This MR adds support for RNN based Tau ID in the TauSelectionTool (jira issue: ATLTAU-1607).
TauSelectionTool is now able to apply cuts on 4 new ID working points: JETIDRNNVERYLOOSE, JETIDRNNLOOSE, JETIDRNNMEDIUM, JETIDRNNTIGHT.
One could also apply cuts on the transformed RNN score (using JetRNNSigTransMin, JetRNNSigTransMax or JetRNNSigTransRegion). The interface here is equivalent to the cuts on the BDT score.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20217Unprotected string replacement in TopEGammaCPTools2019-01-09T03:03:23+01:00Baptiste Ravinabaptiste.ravina@cern.chUnprotected string replacement in TopEGammaCPToolsCloses ANALYSISTO-726Closes ANALYSISTO-726https://gitlab.cern.ch/atlas/athena/-/merge_requests/20077Minor PRW algorithm improvements2019-01-09T03:03:27+01:00Tadej Novaktadej.novak@cern.chMinor PRW algorithm improvementsMinor PRW algorithm improvements:
- add some additional EventInfo decorations that are not done with `apply`
- use default PRW tool settings for data scale factors (current ones were for MC15)Minor PRW algorithm improvements:
- add some additional EventInfo decorations that are not done with `apply`
- use default PRW tool settings for data scale factors (current ones were for MC15)https://gitlab.cern.ch/atlas/athena/-/merge_requests/20221ElectronAnalysisSequence updates2019-01-09T03:03:28+01:00Tadej Novaktadej.novak@cern.chElectronAnalysisSequence updatesElectronAnalysisSequence updates:
- isolation correction should be disabled by default (there is actually no need to run it in rel. 21 for electrons)
- handle `NonIso` case properly
- do not hardcode efficiency map - the recommendatio...ElectronAnalysisSequence updates:
- isolation correction should be disabled by default (there is actually no need to run it in rel. 21 for electrons)
- handle `NonIso` case properly
- do not hardcode efficiency map - the recommendation is to use the tool defaulthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20231TopExamples: TopExamples.grid.checkPRWFile(...) does not properly ignore comm...2019-01-09T03:03:31+01:00Yu-Heng Chenyu-heng.chen@cern.chTopExamples: TopExamples.grid.checkPRWFile(...) does not properly ignore comments in cutfiles. (ANALYSISTO-722)More information can be found in the JIRA ticket (ANALYSISTO-722)More information can be found in the JIRA ticket (ANALYSISTO-722)https://gitlab.cern.ch/atlas/athena/-/merge_requests/20196convenient output file with rucio commands is produced2019-01-10T03:02:55+01:00Ruggero Turraconvenient output file with rucio commands is producedVery small change in the python script used to generate PRW files. The commands to download NTUP files from grid in addition to be shown on the screen as in present case, they are also saved in a `.sh` file which can be executed by the u...Very small change in the python script used to generate PRW files. The commands to download NTUP files from grid in addition to be shown on the screen as in present case, they are also saved in a `.sh` file which can be executed by the user. Presently the user has to copy-and-paste manually the commands which is tedious and error prone (for some reason in my case some dataset names are truncated when doing copy-and-paste on my terminal...)
Not sure: this should be cherry picker to everything >=21.2 and master.
Tagging @willhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20253PixeldEdxTrackParticleThinning fixing2019-01-11T03:03:04+01:00Hideyuki OidePixeldEdxTrackParticleThinning fixingThis quick/small MR fixes a rare issue of falling in `FATAL` in the `SUSY6` derivation production observed in the previous derivation during the EOY break, due to the presence of rare, very small pT tracks below 100 MeV in the track part...This quick/small MR fixes a rare issue of falling in `FATAL` in the `SUSY6` derivation production observed in the previous derivation during the EOY break, due to the presence of rare, very small pT tracks below 100 MeV in the track particle container.
Tagging @ljeanty, @passaggi, @rysawada, @mehlhase, @spagan, @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20224Use FJVT in MET analysis sequence2019-01-11T03:03:05+01:00Tadej Novaktadej.novak@cern.chUse FJVT in MET analysis sequenceAs we use forward jets by default in the analysis sequences we should also use FJVT at MET calculation.
Tagging @krumnack if he wants to review already as we should wait for !20222.As we use forward jets by default in the analysis sequences we should also use FJVT at MET calculation.
Tagging @krumnack if he wants to review already as we should wait for !20222.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20222Update jet analysis sequence2019-01-11T03:03:07+01:00Tadej Novaktadej.novak@cern.chUpdate jet analysis sequenceJet analysis sequence updates:
- Add `JetGhostMuonAssociationAlg` - needed for MET. Probably not the best place, but fits better in this package and sequence than in MET. SUSYTools also runs this on base Jets.
- Do not run jet cleaning...Jet analysis sequence updates:
- Add `JetGhostMuonAssociationAlg` - needed for MET. Probably not the best place, but fits better in this package and sequence than in MET. SUSYTools also runs this on base Jets.
- Do not run jet cleaning - now recommended to run event-based selection after OR (will open a separate MR for this, but needs discussion).
- Update systematics support - separate jet smearing no longer needed, all done while applying uncertainties (keeping the algorithm for now)
- The default MET prefers tight forward JVT.
- Do not apply JVT selection by default (just decorate). More improvements on this coming in a follow-up MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20275Adding HLT_mu6_bJpsi_lowpt_TrkPEB to MUON12019-01-11T03:03:09+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chAdding HLT_mu6_bJpsi_lowpt_TrkPEB to MUON1Hi everybody,
@miholzbo and @fkrieter noticed that `HLT_mu6_bJpsi_lowpt_TrkPEB` is missing from the MUON1 derivation. However, this trigger is urgently needed to derive the low-pt reconstruction scale-factors from 2018 data.
Adding @sz...Hi everybody,
@miholzbo and @fkrieter noticed that `HLT_mu6_bJpsi_lowpt_TrkPEB` is missing from the MUON1 derivation. However, this trigger is urgently needed to derive the low-pt reconstruction scale-factors from 2018 data.
Adding @szambito, @fsforza, @maklein and our well admired friend the @atlasbot .https://gitlab.cern.ch/atlas/athena/-/merge_requests/20193BPHY19 derivation placeholder for di-muon analyses with photon conversions2019-01-11T03:03:11+01:00Wolfgang WalkowiakBPHY19 derivation placeholder for di-muon analyses with photon conversionsThis merge request adds BPHY19 to the derivation framework and supplies a placeholder BPHY19.py file.
The BPHY19 derivation format is intended for di-muon analyses with photon conversions like radiative chi_b/c decays.
The development ...This merge request adds BPHY19 to the derivation framework and supplies a placeholder BPHY19.py file.
The BPHY19 derivation format is intended for di-muon analyses with photon conversions like radiative chi_b/c decays.
The development is followed up in https://its.cern.ch/jira/browse/ATLBPHYS-103 .
cc: @abartonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20215MuonEfficiencyScaleFactorAlg updates + adding of trigger (ATLASG-1474)2019-01-11T03:03:13+01:00Tadej Novaktadej.novak@cern.chMuonEfficiencyScaleFactorAlg updates + adding of trigger (ATLASG-1474)This MR makes updates to `MuonEfficiencyScaleFactorAlg` to support reading SF, MC eff. and data eff. in the same algorithm at once.
Additionally a new `MuonTriggerEfficiencyScaleFactorAlg` is added looking mostly the same with the follo...This MR makes updates to `MuonEfficiencyScaleFactorAlg` to support reading SF, MC eff. and data eff. in the same algorithm at once.
Additionally a new `MuonTriggerEfficiencyScaleFactorAlg` is added looking mostly the same with the following differences:
- has a `trigger` property to set the trigger leg/working point
- has `minRunNumber` and `maxRunNumber` properties as some trigger efficiencies are only available for specific runs/periods
@krumnack, I'm open to suggestions if we need to change property names for SF and efficiencies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20073DFSUSY: drop tau seed jet width and cleanup2019-01-11T09:03:13+01:00Bertrand Martin Dit LatourDFSUSY: drop tau seed jet width and cleanupHello,
This MR drops what had been implemented in https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16344, namely the decoration of taus with the seed jet width, because this functionality is being migrated to DerivationFramewo...Hello,
This MR drops what had been implemented in https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16344, namely the decoration of taus with the seed jet width, because this functionality is being migrated to DerivationFrameworkTau by @lfiorini in !20048 .
I also made some cleanup of old comments and the 'AppendToDict' dictionary, because most collections are now declared in
https://gitlab.cern.ch/atlas/athena/blob/21.2/PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore/python/ContainersOnTheFly.py
and no longer need to be declared in each format.
Thanks.
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20248DerivationFrameworkHiggs Add new derivation (HDBS1) and implement code modifi...2019-01-12T08:15:13+01:00Nadav Michael TamirDerivationFrameworkHiggs Add new derivation (HDBS1) and implement code modifications required for itThis MR is made in order to add a new derivation (named HDBS1), deemed necessary for ttX(X->tautau) analysis. The derivation was modified from HIGG4D6 and implemented through rather simple code modifications in HIGG4Dx files that it uses...This MR is made in order to add a new derivation (named HDBS1), deemed necessary for ttX(X->tautau) analysis. The derivation was modified from HIGG4D6 and implemented through rather simple code modifications in HIGG4Dx files that it uses.
An addition to HIGG4DxJets.py is implemented in the last code block that runs a custom boosted Ditau reconstruction which is crucial to the analysis (default DiTauRec for AODs uses high-pt seed jets while the analysis requires a lower pt cut on seed jets). Skimming is defined in HIGG4DxSkimming.py, runs in two steps (similar to HIGG4D6). Thinning is implemented in HIGG4DxThinning.py, where an addition was made of a tool to thin the newly created low-pt ditau container. Slimming is implemented in HIGG4DxSlimming, where some additions and modifications were implemented (adding the low-pt ditau container to the output, removing some jet containers from the output to reduce size).
The derivation was used privately (as a modified HIGG4D6) to produce signal and background DAODs from simulation (both locally and on the grid) and runs without crashing, the output DAODs have been checked on multiple occasions using both the checkxAOD.py scripts and the CxAOD framework that runs on these samples. The derivation was also tested on data AODs and events were found and saved (and DAODs were processed successfully in CxAOD framwork).
Much effort was made to minimize the output DAOD file sizes without compromising the analysis. The derivation yields an AOD->DAOD size fraction of ~5.5% for signal samples and ~4% for background samples (tested for two of the most major backgrounds to analysis, ttbar and ttZ), and the go-ahead to submit this merge request was agreed upon in the analysis group meeting on January 8th (https://indico.cern.ch/event/785501).