athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-08-12T03:05:12+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/34798sTGC charge2020-08-12T03:05:12+02:00Dylan PizzisTGC chargeImplementing an improved energy to charge description and converting that charge to actual detector response of PDO counts. A more detailed model is coming soon and this is only the preliminary working set of changes. This full conversio...Implementing an improved energy to charge description and converting that charge to actual detector response of PDO counts. A more detailed model is coming soon and this is only the preliminary working set of changes. This full conversion will be moved to a calibration tool in the future.
The conversion from energy to charge was determined using average values from Garfield studies, the charge to mV and mV to PDO conversions were from VMM configurations for cosmic studies. Also, the VMM main threshold was changed due to the charge scaling being affected in the conversion.
@alaurier @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34781Redefine sTGC staggered strip Position2020-08-12T03:05:13+02:00Alexandre LaurierRedefine sTGC staggered strip PositionTo match the aramys alignement software, we change the definition of the position of the staggered strips in the sTGC.
Only the first or last strips are staggered (half-strip), so now we return the position of those strips to coincide to...To match the aramys alignement software, we change the definition of the position of the staggered strips in the sTGC.
Only the first or last strips are staggered (half-strip), so now we return the position of those strips to coincide to the centre of the copper of the strip instead of the centre of the strip pitch (the full strip + gap).https://gitlab.cern.ch/atlas/athena/-/merge_requests/34772Set EM granularity to 1GeV in CTPEmulation2020-08-12T03:05:12+02:00Joerg StelzerSet EM granularity to 1GeV in CTPEmulationSet EM granularity to 1 for emulation of the CTP response for eFEX EM objects
Addresses ATR-21457 and ATR-21261Set EM granularity to 1 for emulation of the CTP response for eFEX EM objects
Addresses ATR-21457 and ATR-21261https://gitlab.cern.ch/atlas/athena/-/merge_requests/34764Fix definition of L1_4jJ15.0ETA25 item (ATR-21484)2020-08-12T03:05:12+02:00Joerg StelzerFix definition of L1_4jJ15.0ETA25 item (ATR-21484)The multiplicity was specified incorrectly (3 instead of 4) leading to a higher rate than expected)
Closes ATR-21484The multiplicity was specified incorrectly (3 instead of 4) leading to a higher rate than expected)
Closes ATR-21484https://gitlab.cern.ch/atlas/athena/-/merge_requests/34759PROCTools: Updating q221 21.3 reference file, see ATLASRECTS-55832020-08-12T03:05:13+02:00Alaettin Serhan MetePROCTools: Updating q221 21.3 reference file, see ATLASRECTS-5583Closes ATLASRECTS-5583Closes ATLASRECTS-5583https://gitlab.cern.ch/atlas/athena/-/merge_requests/34739Sweeping !34689 from master to 21.3.
Add Run2 muon reconstruction ART test2020-08-12T03:05:12+02:00Atlas NightlybuildSweeping !34689 from master to 21.3.
Add Run2 muon reconstruction ART testAdd Run2 muon reconstruction ART test
See merge request atlas/athena!34689Add Run2 muon reconstruction ART test
See merge request atlas/athena!34689https://gitlab.cern.ch/atlas/athena/-/merge_requests/34691fix ART tags in TrigInDetValidation tests2020-08-12T03:05:13+02:00Tim Adyefix ART tags in TrigInDetValidation tests* add missing colon in `# art-html:` tag (`test/test_*_art.sh` jobs only)
* Note for reviewers: there's no need to review the scripts in the `TrigInDetValidation/test/` directory, as these are autogenerated from a template by the other s...* add missing colon in `# art-html:` tag (`test/test_*_art.sh` jobs only)
* Note for reviewers: there's no need to review the scripts in the `TrigInDetValidation/test/` directory, as these are autogenerated from a template by the other scripts.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34631TrigL1CaloUpgrade: eFEX egamma update2020-10-28T12:32:42+01:00Alan WatsonTrigL1CaloUpgrade: eFEX egamma update@bcarlson @viveiros
Updates to e/gamma algorithm (or any other based in TrigT1CaloBaseFex)
* update seeding algorithm to match firmware
- unlikely user will see any effect
* update handling of regions with unusual supercell ge...@bcarlson @viveiros
Updates to e/gamma algorithm (or any other based in TrigT1CaloBaseFex)
* update seeding algorithm to match firmware
- unlikely user will see any effect
* update handling of regions with unusual supercell geometry
(1.4-1.5, 1.8-2.0, 2.4-2.5)
- some visible changes in all algorithm aspects around barrel-endcap transition
- visible changes in L1Width in regions 1.8-2.0, 2.4-2.5
- RetaL12 will also change for |eta|>2.3
* update L1Width with integer weights and special handling of 1.8-2.0 region
- large change in scale of variable
- 1.8-2.0 no longer has narrower distribution than the norm (as does not
use finer granularity than will be available in reality)
* update RHad algorithm to match the clusters used in the firmware
- modest changes in values
For reference, here is a summary:
https://indico.cern.ch/event/939184/contributions/3946427/attachments/2073972/3482312/egamma_Simulation_Update.pdfhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34619Merge 21.0.115 into 21.32020-08-12T03:05:13+02:00John Derek ChapmanMerge 21.0.115 into 21.3This merge request merges all the changes that were made to the ~"21.0" branch between the release [release/21.0.115](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.115)
and the previous release [release/21.0.114](https://gitlab.c...This merge request merges all the changes that were made to the ~"21.0" branch between the release [release/21.0.115](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.115)
and the previous release [release/21.0.114](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.114).
Below is the full list of merge requests that were included between these two tags:
* !34393 : Manual sweep of !29581 to 21.0: Make Birks' Law parameters configurable for Tile and MBTS
* !34076 : RadiationMapsMaker: Particle directions added; Memory footprint improved in finalize
* !34043 : Add ART comparison of AtlasG4 and FullG4
* !34077 : Add readme and instructions to CaloSamplingFractionAnalysis package
* !33867 : Sweeping !33790 from master to 21.0.
* !33402 : Adding SCT tracks with holes in SCTLorentzMonTool
* !34089 : Deleting ART tests for Track overlay
* !34141 : Update ISF_HitAnalysis.cxx: check StatusCode retrieving MuonEntry
* !33769 : Adding low-pt tracking with region of interest
* !33757 : Improve handling of Frontier warnings
Link to the full diff between [release/21.0.115](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.115) and
[release/21.0.114](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.114)
is available at
https://gitlab.cern.ch/atlas/athena/compare/release/21.0.114...release/21.0.115https://gitlab.cern.ch/atlas/athena/-/merge_requests/34592Add ATLAS ART test scripts for TrigInDetValidation2020-08-12T03:05:13+02:00Tim AdyeAdd ATLAS ART test scripts for TrigInDetValidation * Previously we had one ATLAS ART test script, now we have 37 (`test/test_*_art.sh`). Note that these will run in parallel with the old ID Trigger ART tests (in this same package) until the new tests are validated and the old ones remov... * Previously we had one ATLAS ART test script, now we have 37 (`test/test_*_art.sh`). Note that these will run in parallel with the old ID Trigger ART tests (in this same package) until the new tests are validated and the old ones removed.
* the new test script files were generated with the new `mkartlist --art` option.
* `art-include` now for 21.3, 21.9, and master. This MR is just for 21.3, so the others don't count yet.
* add `art-html` directive to link PanDA ART display to TrigInDetValidation results web pages.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34581Small fixes in RIO_OnTrackCreator and MuonClusterOnTrackCreator2020-08-12T03:05:13+02:00Patrick ScholerSmall fixes in RIO_OnTrackCreator and MuonClusterOnTrackCreatorThis MR applies fixes in the RIO_OnTrack messaging which were missed in https://gitlab.cern.ch/atlas/athena/-/merge_requests/34440. I also reverts one change which was introduced in the MMCLusterOnTrackCreator in the same MR. In the swee...This MR applies fixes in the RIO_OnTrack messaging which were missed in https://gitlab.cern.ch/atlas/athena/-/merge_requests/34440. I also reverts one change which was introduced in the MMCLusterOnTrackCreator in the same MR. In the sweep to master of the original MR these things have already been fixed. Therefore this MR is only ~"alsoTargeting:21.9"https://gitlab.cern.ch/atlas/athena/-/merge_requests/34451Sweeping !33757 from 21.0 to 21.3.
Improve handling of Frontier warnings2020-08-12T03:05:14+02:00Atlas NightlybuildSweeping !33757 from 21.0 to 21.3.
Improve handling of Frontier warningsImprove handling of Frontier warnings
See merge request atlas/athena!33757Improve handling of Frontier warnings
See merge request atlas/athena!33757https://gitlab.cern.ch/atlas/athena/-/merge_requests/34440Introduce MMClusterOnTrackCreator2020-08-12T03:05:13+02:00Patrick ScholerIntroduce MMClusterOnTrackCreatorFor the reconstruction or the MMs, a calibration based on the track position will be introduced in the future. This MR is the first step in this calibration, introducing the MMClusterOnTrackCreator which will host the calibration code. F...For the reconstruction or the MMs, a calibration based on the track position will be introduced in the future. This MR is the first step in this calibration, introducing the MMClusterOnTrackCreator which will host the calibration code. For now just the structure is introduced, maintaining the current functionalities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34420MM geometry fixes2020-10-28T12:32:39+01:00Chara KitsakiMM geometry fixesThis MR deals with:
1. new stations.v2.08.xml/stations.v2.08_Aside.xml:
* MM: The proper values of the top/bottom frames (ie frame+empty space due to missing strips) are updated.
* MM: The active areas are expanded by 1pitch in total, t...This MR deals with:
1. new stations.v2.08.xml/stations.v2.08_Aside.xml:
* MM: The proper values of the top/bottom frames (ie frame+empty space due to missing strips) are updated.
* MM: The active areas are expanded by 1pitch in total, to include the whole strips in the active volume.
2. In the MMReadoutElement:
* The active areas are moved by half difference of the top/bottom frames and are placed at the center of the quadruplet.
* localToGlobalCoords() returns correctly the positions in the global ATLAS reference frame
3. In the sTgcReadoutElement:
* add stripGlobalPosition() returns the strip position in ATLAS global reference frame
* localToGlobalCoords() returns correctly the positions in the global ATLAS reference frame
4. In Micromegas.cxx / sTGC.cxx of the MuonGeoModel, the correct frame parameters are initialized and used depending on the module.
adding @alaurier, @rosati and @nkoehlerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34397Create summary txt also for MuonPerformanceAlg and MuonSegmentPerformanceAlg2020-09-14T22:20:43+02:00Nicolas KoehlerCreate summary txt also for MuonPerformanceAlg and MuonSegmentPerformanceAlgHi,
up to now if the MuonPerformanceAlg and the MuonSegmentPerformanceAlg were added, they were printing their summary inside the athena reconstruction log, which increased the log and made it difficult to find the information later. ...Hi,
up to now if the MuonPerformanceAlg and the MuonSegmentPerformanceAlg were added, they were printing their summary inside the athena reconstruction log, which increased the log and made it difficult to find the information later. Now, as it is done already in the MuonTrackPerformanceAlg, the summary is saved into a text file. Also adapting the ART test accordingly.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34320Add Run3 reco NSW performance test2020-08-12T03:05:14+02:00Nicolas KoehlerAdd Run3 reco NSW performance testHi,
this MR adds an ART test for the performance of the NSW reconstruction running on 1000 di-muon events for 1.3<|eta|<2.7 using the symmetric NSW layout.
Adding @kluit, @pscholer, @rosati for their information
Best, NicoHi,
this MR adds an ART test for the performance of the NSW reconstruction running on 1000 di-muon events for 1.3<|eta|<2.7 using the symmetric NSW layout.
Adding @kluit, @pscholer, @rosati for their information
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34258NSW readout and identifier fixes2020-08-12T03:05:14+02:00Alexandre LaurierNSW readout and identifier fixesChanged the MM strip numbering scheme to start from 1 instead of 0 to protect the identifiers. Positions in the active MM volume which have no strips now return strip number 1 to protect against bad identifiers. Strip#1 are never readout...Changed the MM strip numbering scheme to start from 1 instead of 0 to protect the identifiers. Positions in the active MM volume which have no strips now return strip number 1 to protect against bad identifiers. Strip#1 are never readout in the MMs so strip#1 is a way to reduce errors and warnings.
MM channelPosition now returns the centre of the strip instead of the lower edge. This change is also mirrored in the stripNumber scheme.
Fixed a flaw in the sTGC strip position not returning exactly centre of the strips.
Cleaned a few glaring bad coding practices and indentations (always WIP).
Adding @ckitsaki, @nkoehler to this MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34123Merge 21.0.114 into 21.32020-08-12T03:05:14+02:00John Derek ChapmanMerge 21.0.114 into 21.3This merge request merges all the changes that were made to the ~"21.0" branch between the release [release/21.0.114](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.114)
and the previous release [release/21.0.113](https://gitlab.c...This merge request merges all the changes that were made to the ~"21.0" branch between the release [release/21.0.114](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.114)
and the previous release [release/21.0.113](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.113).
Below is the full list of merge requests that were included between these two tags:
* !33671 : AtlantisJava: remove external dependency JavaSDK to fix AA-16
* !33510 : Fix wrong IBL error IDs and broken service-record histograms in monitoring
* !33494 : Add Z counting grid submission scripts
* !33422 : Core dump message improvement to 21.0 (ATLASJT-401)
* !31506 : Pass hadrons below a certain kinetic energy to Geant for G4FastCalo simulator (ATLASSIM-4110)
* !33332 : Fix bug found in DATREP-183
* !33151 : Radiation Damage Digitizer code (SensorSimPlanarTool) speedup
* !33226 : Added NTruthParticles option to FCS_Ntup_tf
* !33232 : Athena: Remove non-existent packages from package filter
* !33185 : Fix precision of cell energy (ATLASSIM-4584)
* !32979 : Improve LAr sampling fraction calculation with feedback from Guillaume
* !33013 : TileCellSelector.cxx: adding possibility to detect underflows in digits container
Link to the full diff between [release/21.0.114](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.114) and
[release/21.0.113](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.113)
is available at
https://gitlab.cern.ch/atlas/athena/compare/release/21.0.113...release/21.0.114https://gitlab.cern.ch/atlas/athena/-/merge_requests/34096Sweeping !34039 from 21.9 to 21.3.
Avoid import from MuonRecExample to allow ...2020-08-12T03:05:14+02:00Atlas NightlybuildSweeping !34039 from 21.9 to 21.3.
Avoid import from MuonRecExample to allow usage also in digiAvoid import from MuonRecExample to allow usage also in digi
See merge request atlas/athena!34039Avoid import from MuonRecExample to allow usage also in digi
See merge request atlas/athena!34039https://gitlab.cern.ch/atlas/athena/-/merge_requests/33999Check for stgc in MuonLayerHoughTool2020-08-12T03:05:14+02:00Nicolas KoehlerCheck for stgc in MuonLayerHoughToolHi,
this MR adds a check for sTGCs as well in MuonLayerHoughTool. It is part of a fix for ATLASRECTS-5551.
Best, NicoHi,
this MR adds a check for sTGCs as well in MuonLayerHoughTool. It is part of a fix for ATLASRECTS-5551.
Best, Nico